Re: [Buildroot] [URGENT 1/1] package/util-linux: fix host build failure

[Peter Seiderer <ps.report@gmx.net>]

Hello Arnout, Giulio,

On Wed, 2 Feb 2022 08:41:34 +0100, Arnout Vandecappelle <arnout@mind.be> wrote:

> On 02/02/2022 00:22, Giulio Benetti wrote:
> > The UTIL_LINUX_FIX_DISK_UTILS_COMPILE workaround is needed for host
> > building too. So let's add it to HOST_UTIL_LINUX_POST_PATCH_HOOKS.
> > host-util-linux is used a lot, so this patch fixes a lot of future
> > builds.
>
>   Darn, I tested that, both with and without BR2_PACKAGE_HOST_UTIL_LINUX set. I
> don't understand what went wrong in my test...

The raw support depends on the available toolchain headers, see e.g.
package/util-linux/Config.in:

	config BR2_PACKAGE_UTIL_LINUX_RAW
	        bool "raw"
	        depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_14
	        help
	          Build a linux raw character device

Or according to [1] '--disable-raw' for the host build should do
the trick too...

Regards,
Peter

[1] https://github.com/util-linux/util-linux/issues/1577

>
>   Anyway, applied to master, thanks.
>
>   Regards,
>   Arnout
>
>
> >
> > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> > ---
> >   package/util-linux/util-linux.mk | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk
> > index e59ef7dadc..5a4ff64d01 100644
> > --- a/package/util-linux/util-linux.mk
> > +++ b/package/util-linux/util-linux.mk
> > @@ -41,6 +41,7 @@ define UTIL_LINUX_FIX_DISK_UTILS_COMPILE
> >   	touch $(@D)/disk-utils/raw.8
> >   endef
> >   UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE
> > +HOST_UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE
> >
> >   HOST_UTIL_LINUX_DEPENDENCIES = host-pkgconf
> >

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot