[Buildroot] [PATCH v2] package/libcamera: fix uclibc/musl compile with libexecinfo enabled

[Buildroot] [PATCH v2] package/libcamera: fix uclibc/musl compile with libexecinfo enabled

[Peter Seiderer]

- depend and link against libexecinfo if enabled to fix linking failure
  in case execinfo.h is detected, see
  libcamera-40f5fddca7f774944a53f58eeaebc4db79c373d8/meson.build:

   32 if cc.has_header_symbol('execinfo.h', 'backtrace')
   33     config_h.set('HAVE_BACKTRACE', 1)
   34 endif

- libexecinfo already depends on !BR2_TOOLCHAIN_USES_GLIBC

Fixes:

  - http://autobuild.buildroot.net/results/a1077815895ab847c5ca82ec17c7d13fe97cff53

  .../powerpc-buildroot-linux-uclibc/bin/ld: src/libcamera/base/libcamera-base.so.p/log.cpp.o: in function `libcamera::Logger::backtrace()':
  log.cpp:(.text+0x34b0): undefined reference to `backtrace'
  .../powerpc-buildroot-linux-uclibc/bin/ld: log.cpp:(.text+0x34c0): undefined reference to `backtrace_symbols'

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Changes v1 -> v2:
  - preserver original TARGET_LDFLAGS while setting LIBCAMERA_LDFLAGS
---
 package/libcamera/libcamera.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk
index 524cf07e03..534d8d2637 100644
--- a/package/libcamera/libcamera.mk
+++ b/package/libcamera/libcamera.mk
@@ -99,4 +99,9 @@ else
 LIBCAMERA_CONF_OPTS += -Dtracing=disabled
 endif
 
+ifeq ($(BR2_PACKAGE_LIBEXECINFO),y)
+LIBCAMERA_DEPENDENCIES += libexecinfo
+LIBCAMERA_LDFLAGS = $(TARGET_LDFLAGS) -lexecinfo
+endif
+
 $(eval $(meson-package))
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/libcamera: fix uclibc/musl compile with libexecinfo enabled

[Thomas Petazzoni via buildroot]

On Fri,  4 Feb 2022 00:23:21 +0100
Peter Seiderer <ps.report@gmx.net> wrote:

> - depend and link against libexecinfo if enabled to fix linking failure
>   in case execinfo.h is detected, see
>   libcamera-40f5fddca7f774944a53f58eeaebc4db79c373d8/meson.build:
> 
>    32 if cc.has_header_symbol('execinfo.h', 'backtrace')
>    33     config_h.set('HAVE_BACKTRACE', 1)
>    34 endif
> 
> - libexecinfo already depends on !BR2_TOOLCHAIN_USES_GLIBC
> 
> Fixes:
> 
>   - http://autobuild.buildroot.net/results/a1077815895ab847c5ca82ec17c7d13fe97cff53
> 
>   .../powerpc-buildroot-linux-uclibc/bin/ld: src/libcamera/base/libcamera-base.so.p/log.cpp.o: in function `libcamera::Logger::backtrace()':
>   log.cpp:(.text+0x34b0): undefined reference to `backtrace'
>   .../powerpc-buildroot-linux-uclibc/bin/ld: log.cpp:(.text+0x34c0): undefined reference to `backtrace_symbols'
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Changes v1 -> v2:
>   - preserver original TARGET_LDFLAGS while setting LIBCAMERA_LDFLAGS
> ---
>  package/libcamera/libcamera.mk | 5 +++++
>  1 file changed, 5 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot