Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: <yann.morin@orange.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 3/5 v2] package/pkg-cargo: host-rustc is also a build dependency
Date: Wed, 9 Feb 2022 20:55:18 +0100	[thread overview]
Message-ID: <20220209205518.18d720ef@windsurf> (raw)
In-Reply-To: <9430_1644422939_6203E71B_9430_485_1_951512fc2010b31a4d2d50fe12c2ad86f3a0c1a1.1644422916.git.yann.morin@orange.com>

On Wed, 9 Feb 2022 17:08:45 +0100
<yann.morin@orange.com> wrote:

> From: "Yann E. MORIN" <yann.morin@orange.com>
> 
> Currently, host-rustc is a download dependency, because we need cargo
> for the vendoring during the downlaod step.

                                ^^^^^^^^ download

> However, when using a package in override-srcdir, there is no download
> step, so host-rustc is not pulled in as a dependency which breaks
> running the build of a single pcakge from scratch:

                                ^^^^^^  package

>     $ make clean
>     $ make my-rust-package
>     [...]
>     [...] cargo build --offline --release --manifest-path Cargo.toml --locked
>     /bin/sh: cargo: command not found
> 
> We fix that by adding host-rustc as a standard dependency too.
> 
> Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-02-09 19:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1644422916.git.yann.morin@orange.com>
2022-02-09 16:08 ` [Buildroot] [PATCH 1/5 v2] package/pkg-cargo: allow packages to define download environment yann.morin
2022-02-09 19:50   ` Thomas Petazzoni via buildroot
2022-02-09 19:52   ` Thomas Petazzoni via buildroot
2022-02-09 20:55     ` Yann E. MORIN
2022-02-09 21:48       ` Thomas Petazzoni via buildroot
2022-02-09 16:08 ` [Buildroot] [PATCH 2/5 v2] package/pkg-cargo: allow building in a sub-directory yann.morin
2022-02-09 19:54   ` Thomas Petazzoni via buildroot
2022-02-10 15:08     ` yann.morin
     [not found]     ` <20220210150850.GA2599@tl-lnx-nyma7486>
2022-02-10 15:19       ` yann.morin
2022-02-09 16:08 ` [Buildroot] [PATCH 3/5 v2] package/pkg-cargo: host-rustc is also a build dependency yann.morin
2022-02-09 19:55   ` Thomas Petazzoni via buildroot [this message]
2022-02-09 16:08 ` [Buildroot] [PATCH 4/5 v2] package/pkg-golang: allow packages to define download environment yann.morin
2022-02-09 19:55   ` Thomas Petazzoni via buildroot
2022-02-09 20:12   ` Christian Stewart via buildroot
2022-02-09 16:08 ` [Buildroot] [PATCH 5/5 v2] package/pkg-golang: host-go is also a build dependency yann.morin
2022-02-09 20:03   ` Thomas Petazzoni via buildroot
2022-02-09 20:11   ` Christian Stewart via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220209205518.18d720ef@windsurf \
    --to=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin@orange.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox