From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: <yann.morin@orange.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/5 v2] package/pkg-cargo: allow building in a sub-directory
Date: Wed, 9 Feb 2022 20:54:10 +0100 [thread overview]
Message-ID: <20220209205410.071f193a@windsurf> (raw)
In-Reply-To: <20175_1644422934_6203E716_20175_175_1_fea7d1545892211e01cb6660dc5fba16b0851c47.1644422916.git.yann.morin@orange.com>
On Wed, 9 Feb 2022 17:08:44 +0100
<yann.morin@orange.com> wrote:
> +# If building in a sub directory, use that to find the Cargo.toml, unless
> +# the package already provided its location.
> +ifneq ($$($(2)_SUBDIR),)
> +ifeq ($$(filter BR_CARGO_MANIFEST_PATH=%,$$($(2)_DL_ENV)),)
> +$(2)_DL_ENV += BR_CARGO_MANIFEST_PATH=$$($(2)_SUBDIR)/Cargo.toml
I find that a bit "meh". Should we have an explicit package variable
that tells the location of the Cargo.toml, instead of directly have
packages pass this "magic" BR_CARGO_MANIFEST_PATH variable ?
Should $(2)_SUBDIR be documented for the cargo-package infra in the
documentation ?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-02-09 19:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1644422916.git.yann.morin@orange.com>
2022-02-09 16:08 ` [Buildroot] [PATCH 1/5 v2] package/pkg-cargo: allow packages to define download environment yann.morin
2022-02-09 19:50 ` Thomas Petazzoni via buildroot
2022-02-09 19:52 ` Thomas Petazzoni via buildroot
2022-02-09 20:55 ` Yann E. MORIN
2022-02-09 21:48 ` Thomas Petazzoni via buildroot
2022-02-09 16:08 ` [Buildroot] [PATCH 2/5 v2] package/pkg-cargo: allow building in a sub-directory yann.morin
2022-02-09 19:54 ` Thomas Petazzoni via buildroot [this message]
2022-02-10 15:08 ` yann.morin
[not found] ` <20220210150850.GA2599@tl-lnx-nyma7486>
2022-02-10 15:19 ` yann.morin
2022-02-09 16:08 ` [Buildroot] [PATCH 3/5 v2] package/pkg-cargo: host-rustc is also a build dependency yann.morin
2022-02-09 19:55 ` Thomas Petazzoni via buildroot
2022-02-09 16:08 ` [Buildroot] [PATCH 4/5 v2] package/pkg-golang: allow packages to define download environment yann.morin
2022-02-09 19:55 ` Thomas Petazzoni via buildroot
2022-02-09 20:12 ` Christian Stewart via buildroot
2022-02-09 16:08 ` [Buildroot] [PATCH 5/5 v2] package/pkg-golang: host-go is also a build dependency yann.morin
2022-02-09 20:03 ` Thomas Petazzoni via buildroot
2022-02-09 20:11 ` Christian Stewart via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220209205410.071f193a@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin@orange.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox