From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Julien Olivain <ju.o@free.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] Revert "package/ola: drop autoreconf"
Date: Sun, 13 Mar 2022 14:20:24 +0100 [thread overview]
Message-ID: <20220313142024.56b9493e@windsurf> (raw)
In-Reply-To: <20220313103737.751528-1-fontaine.fabrice@gmail.com>
On Sun, 13 Mar 2022 11:37:36 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> This reverts commit 66d348ae18c6e73d6ff9d935a241e55a65948be6 because
> for an unknown reason, the build fails if autoreconf is dropped:
>
> /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/i686-buildroot-linux-uclibc/9.3.0/../../../../i686-buildroot-linux-uclibc/bin/ld: warning: libolauartdmx.so.0, needed by olad/.libs/libolaserver.so, not found (try using -rpath or -rpath-link)
> /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/i686-buildroot-linux-uclibc/9.3.0/../../../../i686-buildroot-linux-uclibc/bin/ld: warning: libolaserverplugininterface.so.0, needed by olad/.libs/libolaserver.so, not found (try using -rpath or -rpath-link)
>
> Fixes:
> - http://autobuild.buildroot.org/results/f8164c69da0b9fa38081e8b785d8234f0f297ae1
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/ola/ola.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/ola/ola.mk b/package/ola/ola.mk
> index 1874350784..5090076175 100644
> --- a/package/ola/ola.mk
> +++ b/package/ola/ola.mk
> @@ -9,6 +9,7 @@ OLA_SITE = https://github.com/OpenLightingProject/ola/releases/download/$(OLA_VE
> OLA_LICENSE = LGPL-2.1+ (libola, libolacommon, Python bindings), GPL-2.0+ (libolaserver, olad, Python examples and tests)
> OLA_LICENSE_FILES = COPYING GPL LGPL LICENCE
> OLA_INSTALL_STAGING = YES
> +OLA_AUTORECONF = YES
Perhaps a comment above this line would be useful, to explain why
AUTORECONF is needed, otherwise there are risks for it to get dropped
again in the future.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-03-13 13:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-13 10:37 [Buildroot] [PATCH 1/2] Revert "package/ola: drop autoreconf" Fabrice Fontaine
2022-03-13 10:37 ` [Buildroot] [PATCH 2/2] package/ola: fix build with libexecinfo Fabrice Fontaine
2022-03-13 13:20 ` Thomas Petazzoni via buildroot [this message]
2022-03-23 20:24 ` [Buildroot] [PATCH 1/2] Revert "package/ola: drop autoreconf" Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220313142024.56b9493e@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=ju.o@free.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox