Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] Revert "package/ola: drop autoreconf"
@ 2022-03-13 10:37 Fabrice Fontaine
  2022-03-13 10:37 ` [Buildroot] [PATCH 2/2] package/ola: fix build with libexecinfo Fabrice Fontaine
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2022-03-13 10:37 UTC (permalink / raw)
  To: buildroot; +Cc: Julien Olivain, Fabrice Fontaine

This reverts commit 66d348ae18c6e73d6ff9d935a241e55a65948be6 because
for an unknown reason, the build fails if autoreconf is dropped:

/home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/i686-buildroot-linux-uclibc/9.3.0/../../../../i686-buildroot-linux-uclibc/bin/ld: warning: libolauartdmx.so.0, needed by olad/.libs/libolaserver.so, not found (try using -rpath or -rpath-link)
/home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/i686-buildroot-linux-uclibc/9.3.0/../../../../i686-buildroot-linux-uclibc/bin/ld: warning: libolaserverplugininterface.so.0, needed by olad/.libs/libolaserver.so, not found (try using -rpath or -rpath-link)

Fixes:
 - http://autobuild.buildroot.org/results/f8164c69da0b9fa38081e8b785d8234f0f297ae1
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/ola/ola.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/ola/ola.mk b/package/ola/ola.mk
index 1874350784..5090076175 100644
--- a/package/ola/ola.mk
+++ b/package/ola/ola.mk
@@ -9,6 +9,7 @@ OLA_SITE = https://github.com/OpenLightingProject/ola/releases/download/$(OLA_VE
 OLA_LICENSE = LGPL-2.1+ (libola, libolacommon, Python bindings), GPL-2.0+ (libolaserver, olad, Python examples and tests)
 OLA_LICENSE_FILES = COPYING GPL LGPL LICENCE
 OLA_INSTALL_STAGING = YES
+OLA_AUTORECONF = YES
 
 # util-linux provides uuid lib
 OLA_DEPENDENCIES = protobuf util-linux host-bison host-flex host-ola
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 2/2] package/ola: fix build with libexecinfo
  2022-03-13 10:37 [Buildroot] [PATCH 1/2] Revert "package/ola: drop autoreconf" Fabrice Fontaine
@ 2022-03-13 10:37 ` Fabrice Fontaine
  2022-03-13 13:20 ` [Buildroot] [PATCH 1/2] Revert "package/ola: drop autoreconf" Thomas Petazzoni via buildroot
  2022-03-23 20:24 ` Arnout Vandecappelle
  2 siblings, 0 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2022-03-13 10:37 UTC (permalink / raw)
  To: buildroot; +Cc: Julien Olivain, Fabrice Fontaine

Fix the following build failure raised on uclibc and musl since the
reintroduction of the package in commit
16ff948444c3978d63f483344a3d92d994c64312:

/home/giuliobenetti/autobuild/run/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/arc-buildroot-linux-uclibc/10.2.0/../../../../arc-buildroot-linux-uclibc/bin/ld: common/.libs/libolacommon.so: undefined reference to `backtrace'

Fixes:
 - http://autobuild.buildroot.org/results/4362b20d786a0f44268ec32a689c23ac6d3b71c6

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/ola/ola.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/ola/ola.mk b/package/ola/ola.mk
index 5090076175..471ae8ed9b 100644
--- a/package/ola/ola.mk
+++ b/package/ola/ola.mk
@@ -53,6 +53,11 @@ endef
 OLA_CONF_ENV = PYTHONPATH=$(TARGET_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)/site-packages
 OLA_MAKE_ENV = PYTHONPATH=$(TARGET_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)/site-packages
 
+ifeq ($(BR2_PACKAGE_LIBEXECINFO),y)
+OLA_DEPENDENCIES += libexecinfo
+OLA_CONF_ENV += LDFLAGS="$(TARGET_LDFLAGS) -lexecinfo"
+endif
+
 ## OLA Bindings and Interface selections
 
 ifeq ($(BR2_PACKAGE_OLA_WEB),y)
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/2] Revert "package/ola: drop autoreconf"
  2022-03-13 10:37 [Buildroot] [PATCH 1/2] Revert "package/ola: drop autoreconf" Fabrice Fontaine
  2022-03-13 10:37 ` [Buildroot] [PATCH 2/2] package/ola: fix build with libexecinfo Fabrice Fontaine
@ 2022-03-13 13:20 ` Thomas Petazzoni via buildroot
  2022-03-23 20:24 ` Arnout Vandecappelle
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-03-13 13:20 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Julien Olivain, buildroot

On Sun, 13 Mar 2022 11:37:36 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> This reverts commit 66d348ae18c6e73d6ff9d935a241e55a65948be6 because
> for an unknown reason, the build fails if autoreconf is dropped:
> 
> /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/i686-buildroot-linux-uclibc/9.3.0/../../../../i686-buildroot-linux-uclibc/bin/ld: warning: libolauartdmx.so.0, needed by olad/.libs/libolaserver.so, not found (try using -rpath or -rpath-link)
> /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/i686-buildroot-linux-uclibc/9.3.0/../../../../i686-buildroot-linux-uclibc/bin/ld: warning: libolaserverplugininterface.so.0, needed by olad/.libs/libolaserver.so, not found (try using -rpath or -rpath-link)
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/f8164c69da0b9fa38081e8b785d8234f0f297ae1
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/ola/ola.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/ola/ola.mk b/package/ola/ola.mk
> index 1874350784..5090076175 100644
> --- a/package/ola/ola.mk
> +++ b/package/ola/ola.mk
> @@ -9,6 +9,7 @@ OLA_SITE = https://github.com/OpenLightingProject/ola/releases/download/$(OLA_VE
>  OLA_LICENSE = LGPL-2.1+ (libola, libolacommon, Python bindings), GPL-2.0+ (libolaserver, olad, Python examples and tests)
>  OLA_LICENSE_FILES = COPYING GPL LGPL LICENCE
>  OLA_INSTALL_STAGING = YES
> +OLA_AUTORECONF = YES

Perhaps a comment above this line would be useful, to explain why
AUTORECONF is needed, otherwise there are risks for it to get dropped
again in the future.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/2] Revert "package/ola: drop autoreconf"
  2022-03-13 10:37 [Buildroot] [PATCH 1/2] Revert "package/ola: drop autoreconf" Fabrice Fontaine
  2022-03-13 10:37 ` [Buildroot] [PATCH 2/2] package/ola: fix build with libexecinfo Fabrice Fontaine
  2022-03-13 13:20 ` [Buildroot] [PATCH 1/2] Revert "package/ola: drop autoreconf" Thomas Petazzoni via buildroot
@ 2022-03-23 20:24 ` Arnout Vandecappelle
  2 siblings, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2022-03-23 20:24 UTC (permalink / raw)
  To: Fabrice Fontaine, buildroot; +Cc: Julien Olivain



On 13/03/2022 11:37, Fabrice Fontaine wrote:
> This reverts commit 66d348ae18c6e73d6ff9d935a241e55a65948be6 because
> for an unknown reason, the build fails if autoreconf is dropped:
> 
> /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/i686-buildroot-linux-uclibc/9.3.0/../../../../i686-buildroot-linux-uclibc/bin/ld: warning: libolauartdmx.so.0, needed by olad/.libs/libolaserver.so, not found (try using -rpath or -rpath-link)
> /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/i686-buildroot-linux-uclibc/9.3.0/../../../../i686-buildroot-linux-uclibc/bin/ld: warning: libolaserverplugininterface.so.0, needed by olad/.libs/libolaserver.so, not found (try using -rpath or -rpath-link)
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/f8164c69da0b9fa38081e8b785d8234f0f297ae1
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Both applied to master. I also added a commit that adds a comment to 
AUTORECONF, as suggested by Thomas.

  Regards,
  Arnout

> ---
>   package/ola/ola.mk | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/package/ola/ola.mk b/package/ola/ola.mk
> index 1874350784..5090076175 100644
> --- a/package/ola/ola.mk
> +++ b/package/ola/ola.mk
> @@ -9,6 +9,7 @@ OLA_SITE = https://github.com/OpenLightingProject/ola/releases/download/$(OLA_VE
>   OLA_LICENSE = LGPL-2.1+ (libola, libolacommon, Python bindings), GPL-2.0+ (libolaserver, olad, Python examples and tests)
>   OLA_LICENSE_FILES = COPYING GPL LGPL LICENCE
>   OLA_INSTALL_STAGING = YES
> +OLA_AUTORECONF = YES
>   
>   # util-linux provides uuid lib
>   OLA_DEPENDENCIES = protobuf util-linux host-bison host-flex host-ola
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-23 20:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-13 10:37 [Buildroot] [PATCH 1/2] Revert "package/ola: drop autoreconf" Fabrice Fontaine
2022-03-13 10:37 ` [Buildroot] [PATCH 2/2] package/ola: fix build with libexecinfo Fabrice Fontaine
2022-03-13 13:20 ` [Buildroot] [PATCH 1/2] Revert "package/ola: drop autoreconf" Thomas Petazzoni via buildroot
2022-03-23 20:24 ` Arnout Vandecappelle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox