[Buildroot] [PATCH v3 0/7] boot/optee-os: support new optee-os 3.16.0 build dependencies

[Buildroot] [PATCH v3 0/7] boot/optee-os: support new optee-os 3.16.0 build dependencies

[Clément Léger via buildroot]

Newer versions of optee-os (>= 3.16.0) uses python-cryptography instead
of python-pycryptodomex to build. This series adds support to build
host-python-cryptography and uses it in optee-os package to build the
3.16.0 version. Also bump optee-client, optee-benchmark, optee-examples
and optee-test which needs to be aligned with optee-os version.

----
Changes in v3:
- Fix authorship for commits that were copied from Etienne ones.
- Fix package URL for optee-os
- Added Acked-by Etienne Carriere

Changes in v2:
- Bump optee-client, optee-benchmark, optee-examples and optee-test

Clément Léger (7):
  package/python-cryptography: enable host package
  boot/optee-os: add support to build with python-cryptography
  boot/optee-os: bump to version 3.16.0
  package/optee-test: bump to version 3.16.0
  package/optee-examples: bump to version 3.16.0
  package/optee-client: bump to version 3.16.0
  package/optee-benchmark: bump to version 3.16.0

 boot/optee-os/Config.in                            | 13 +++++++++++--
 boot/optee-os/optee-os.hash                        |  4 ++--
 boot/optee-os/optee-os.mk                          |  7 ++++++-
 package/optee-benchmark/optee-benchmark.hash       |  4 ++--
 package/optee-benchmark/optee-benchmark.mk         |  2 +-
 package/optee-client/optee-client.hash             |  4 ++--
 package/optee-client/optee-client.mk               |  2 +-
 package/optee-examples/optee-examples.hash         |  4 ++--
 package/optee-examples/optee-examples.mk           |  2 +-
 package/optee-test/optee-test.hash                 |  4 ++--
 package/optee-test/optee-test.mk                   |  2 +-
 package/python-cryptography/python-cryptography.mk |  7 +++++++
 12 files changed, 38 insertions(+), 17 deletions(-)

-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v3 1/7] package/python-cryptography: enable host package

[Clément Léger via buildroot]

Enable host package and add needed dependencies.

Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Clément Léger <clement.leger@bootlin.com>
---
 package/python-cryptography/python-cryptography.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/python-cryptography/python-cryptography.mk b/package/python-cryptography/python-cryptography.mk
index a524f729c8..4ff61c7f86 100644
--- a/package/python-cryptography/python-cryptography.mk
+++ b/package/python-cryptography/python-cryptography.mk
@@ -17,6 +17,11 @@ PYTHON_CRYPTOGRAPHY_DEPENDENCIES = \
 	host-python-cffi \
 	host-rustc \
 	openssl
+HOST_PYTHON_CRYPTOGRAPHY_DEPENDENCIES = \
+	host-python-setuptools-rust \
+	host-python-cffi \
+	host-rustc \
+	openssl
 PYTHON_CRYPTOGRAPHY_ENV = \
 	$(PKG_CARGO_ENV) \
 	PYO3_CROSS_LIB_DIR="$(STAGING_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)"
@@ -27,4 +32,6 @@ PYTHON_CRYPTOGRAPHY_DL_ENV = \
 	$(PKG_CARGO_ENV) \
 	BR_CARGO_MANIFEST_PATH=src/rust/Cargo.toml
 
+
 $(eval $(python-package))
+$(eval $(host-python-package))
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v3 2/7] boot/optee-os: add support to build with python-cryptography

[Clément Léger via buildroot]

Newer version of optee-os (>= 3.16) uses python-cryptography instead of
python-pycryptodomex in python scripts. Add support to build these
newer versions by adding a new
BR2_TARGET_OPTEE_OS_NEEDS_PYTHON_CRYPTOGRAPHY option which will
select host-python-cryptography dependency when building optee-os.

Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Clément Léger <clement.leger@bootlin.com>
---
 boot/optee-os/Config.in   | 8 ++++++++
 boot/optee-os/optee-os.mk | 7 ++++++-
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/boot/optee-os/Config.in b/boot/optee-os/Config.in
index 0974578484..f8426f9ab2 100644
--- a/boot/optee-os/Config.in
+++ b/boot/optee-os/Config.in
@@ -48,6 +48,14 @@ config BR2_TARGET_OPTEE_OS_CUSTOM_REPO_VERSION
 
 endif
 
+config BR2_TARGET_OPTEE_OS_NEEDS_PYTHON_CRYPTOGRAPHY
+	bool "optee-os needs host-python-cryptography to build"
+	help
+	  OP-TEE version below 3.16 used python-pycryptodomex package
+	  in python scripts. Newer version uses python-cryptography.
+	  Select this option if optee-os needs python-cryptography to
+	  be built.
+
 config BR2_TARGET_OPTEE_OS_VERSION
 	string
 	default "3.15.0"	if BR2_TARGET_OPTEE_OS_LATEST
diff --git a/boot/optee-os/optee-os.mk b/boot/optee-os/optee-os.mk
index 166b5e693c..57f9a17bb6 100644
--- a/boot/optee-os/optee-os.mk
+++ b/boot/optee-os/optee-os.mk
@@ -21,7 +21,12 @@ else
 OPTEE_OS_SITE = $(call github,OP-TEE,optee_os,$(OPTEE_OS_VERSION))
 endif
 
-OPTEE_OS_DEPENDENCIES = host-openssl host-python3 host-python-pycryptodomex host-python-pyelftools
+OPTEE_OS_DEPENDENCIES = host-openssl host-python3 host-python-pyelftools
+ifeq ($(BR2_TARGET_OPTEE_OS_NEEDS_PYTHON_CRYPTOGRAPHY),y)
+OPTEE_OS_DEPENDENCIES += host-python-cryptography
+else
+OPTEE_OS_DEPENDENCIES += host-python-pycryptodomex
+endif
 
 # On 64bit targets, OP-TEE OS can be built in 32bit mode, or
 # can be built in 64bit mode and support 32bit and 64bit
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v3 3/7] boot/optee-os: bump to version 3.16.0

[Clément Léger via buildroot]

Bump OP-TEE OS package version to OP-TEE release 3.16.0 and set
BR2_TARGET_OPTEE_OS_NEEDS_PYTHON_CRYPTOGRAPHY default to 'y' since
python-cryptography is now needed to build optee-os.

Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Clément Léger <clement.leger@bootlin.com>
---
 boot/optee-os/Config.in     | 5 +++--
 boot/optee-os/optee-os.hash | 4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/boot/optee-os/Config.in b/boot/optee-os/Config.in
index f8426f9ab2..6fe2ae95ac 100644
--- a/boot/optee-os/Config.in
+++ b/boot/optee-os/Config.in
@@ -18,7 +18,7 @@ choice
 	  Select the version of OP-TEE OS you want to use
 
 config BR2_TARGET_OPTEE_OS_LATEST
-	bool "3.15.0"
+	bool "3.16.0"
 	help
 	  Use the latest release tag from the OP-TEE OS official Git
 	  repository.
@@ -50,6 +50,7 @@ endif
 
 config BR2_TARGET_OPTEE_OS_NEEDS_PYTHON_CRYPTOGRAPHY
 	bool "optee-os needs host-python-cryptography to build"
+	default y
 	help
 	  OP-TEE version below 3.16 used python-pycryptodomex package
 	  in python scripts. Newer version uses python-cryptography.
@@ -58,7 +59,7 @@ config BR2_TARGET_OPTEE_OS_NEEDS_PYTHON_CRYPTOGRAPHY
 
 config BR2_TARGET_OPTEE_OS_VERSION
 	string
-	default "3.15.0"	if BR2_TARGET_OPTEE_OS_LATEST
+	default "3.16.0"	if BR2_TARGET_OPTEE_OS_LATEST
 	default BR2_TARGET_OPTEE_OS_CUSTOM_REPO_VERSION \
 				if BR2_TARGET_OPTEE_OS_CUSTOM_GIT
 
diff --git a/boot/optee-os/optee-os.hash b/boot/optee-os/optee-os.hash
index 3c32e25b36..b9b0e5b43f 100644
--- a/boot/optee-os/optee-os.hash
+++ b/boot/optee-os/optee-os.hash
@@ -1,4 +1,4 @@
-# From https://github.com/OP-TEE/optee_os/archive/3.15.0/optee-os-3.15.0.tar.gz
-sha256 e5bb3d9eedaf7785af091602addac5b52118f4cdc108af9cd6f6c96b21503ab8  optee-os-3.15.0.tar.gz
+# From https://github.com/OP-TEE/optee_os/archive/3.16.0/optee-os-3.16.0.tar.gz
+sha256 ebc8e18ad2039ee97c34f74a7546de9119e26f04c368b6c7fd0c55f93d33d2d6  optee-os-3.16.0.tar.gz
 # Locally computed
 sha256 1247ee90858f4037b6cac63cbffddfed435d0d73c631b37d78c1e6e6ab3e5d1a  LICENSE
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v3 4/7] package/optee-test: bump to version 3.16.0

[Clément Léger via buildroot]

Bump OP-TEE test package version to OP-TEE release 3.16.0.

Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Clément Léger <clement.leger@bootlin.com>
---
 package/optee-test/optee-test.hash | 4 ++--
 package/optee-test/optee-test.mk   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/optee-test/optee-test.hash b/package/optee-test/optee-test.hash
index 5d68f94fbd..7806d9a1af 100644
--- a/package/optee-test/optee-test.hash
+++ b/package/optee-test/optee-test.hash
@@ -1,4 +1,4 @@
-# From https://github.com/OP-TEE/optee_test/archive/3.15.0/optee-test-3.15.0.tar.gz
-sha256 9c2b6b80055cbef0f9bccce17dde494725bc71d9013dacaeb3e46d0926191098  optee-test-3.15.0.tar.gz
+# From https://github.com/OP-TEE/optee_test/archive/3.16.0/optee-test-3.16.0.tar.gz
+sha256 b24a3871605a341fa87e6d4e111f97001f11a72c025e75d6739ed78841b6acba  optee-test-3.16.0.tar.gz
 # Locally computed
 sha256 6e6810981f0ddab9e0d44399d0700a15d9f760a3c2843cc866659c2074139ae7  LICENSE.md
diff --git a/package/optee-test/optee-test.mk b/package/optee-test/optee-test.mk
index f2117c0d00..7b27558b36 100644
--- a/package/optee-test/optee-test.mk
+++ b/package/optee-test/optee-test.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-OPTEE_TEST_VERSION = 3.15.0
+OPTEE_TEST_VERSION = 3.16.0
 OPTEE_TEST_SITE = $(call github,OP-TEE,optee_test,$(OPTEE_TEST_VERSION))
 OPTEE_TEST_LICENSE = GPL-2.0, BSD-2-Clause,
 OPTEE_TEST_LICENSE_FILES = LICENSE.md
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v3 5/7] package/optee-examples: bump to version 3.16.0

[Clément Léger via buildroot]

Bump OP-TEE Examples package version to OP-TEE release 3.16.0.

Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Clément Léger <clement.leger@bootlin.com>
---
 package/optee-examples/optee-examples.hash | 4 ++--
 package/optee-examples/optee-examples.mk   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/optee-examples/optee-examples.hash b/package/optee-examples/optee-examples.hash
index f88904c795..afd50afea0 100644
--- a/package/optee-examples/optee-examples.hash
+++ b/package/optee-examples/optee-examples.hash
@@ -1,4 +1,4 @@
-# From https://github.com/linaro-swg/optee_examples/archive/3.15.0/optee-examples-3.15.0.tar.gz
-sha256 9770827292eea85068913077d3406070f6182389779c5d4a5c0876bffd962353  optee-examples-3.15.0.tar.gz
+# From https://github.com/linaro-swg/optee_examples/archive/3.16.0/optee-examples-3.16.0.tar.gz
+sha256 45e06dc5520f3097cc124434acafc26b8db28db87df62f3ad2ddff06cacce969  optee-examples-3.16.0.tar.gz
 # Locally computed
 sha256 6f1ef8449cb82ae79d2155605f7985bdf0f08e7ab5007de9b4362e8bf28733b9  LICENSE
diff --git a/package/optee-examples/optee-examples.mk b/package/optee-examples/optee-examples.mk
index 2b46dcc1eb..31e5f260df 100644
--- a/package/optee-examples/optee-examples.mk
+++ b/package/optee-examples/optee-examples.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-OPTEE_EXAMPLES_VERSION = 3.15.0
+OPTEE_EXAMPLES_VERSION = 3.16.0
 OPTEE_EXAMPLES_SITE = $(call github,linaro-swg,optee_examples,$(OPTEE_EXAMPLES_VERSION))
 OPTEE_EXAMPLES_LICENSE = BSD-2-Clause
 OPTEE_EXAMPLES_LICENSE_FILES = LICENSE
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v3 6/7] package/optee-client: bump to version 3.16.0

[Clément Léger via buildroot]

Bump OP-TEE Client package version to OP-TEE release 3.16.0.

Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Clément Léger <clement.leger@bootlin.com>
---
 package/optee-client/optee-client.hash | 4 ++--
 package/optee-client/optee-client.mk   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/optee-client/optee-client.hash b/package/optee-client/optee-client.hash
index 3ae06f2afb..26b0a6ced4 100644
--- a/package/optee-client/optee-client.hash
+++ b/package/optee-client/optee-client.hash
@@ -1,4 +1,4 @@
-# From https://github.com/OP-TEE/optee_client/archive/3.15.0/optee-client-3.15.0.tar.gz
-sha256 e1ea6c953e3584248d7a62050813e5ac0f0112933447954c44236a233a4cbba5  optee-client-3.15.0.tar.gz
+# From https://github.com/OP-TEE/optee_client/archive/3.16.0/optee-client-3.16.0.tar.gz
+sha256 cba92bedc9f8c39c19e50a22259066eaad5ceb248308edee27e221f11f5d8064  optee-client-3.16.0.tar.gz
 # Locally computed
 sha256 fda8385993f112d7ca61b88b54ba5b4cbeec7e43a0f9b317d5186703c1985e8f  LICENSE
diff --git a/package/optee-client/optee-client.mk b/package/optee-client/optee-client.mk
index dda9a2855d..2cadc564f0 100644
--- a/package/optee-client/optee-client.mk
+++ b/package/optee-client/optee-client.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-OPTEE_CLIENT_VERSION = 3.15.0
+OPTEE_CLIENT_VERSION = 3.16.0
 OPTEE_CLIENT_SITE = $(call github,OP-TEE,optee_client,$(OPTEE_CLIENT_VERSION))
 OPTEE_CLIENT_LICENSE = BSD-2-Clause
 OPTEE_CLIENT_LICENSE_FILES = LICENSE
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v3 7/7] package/optee-benchmark: bump to version 3.16.0

[Clément Léger via buildroot]

Bump OP-TEE Benchmark package version to OP-TEE release 3.16.0.

Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Clément Léger <clement.leger@bootlin.com>
---
 package/optee-benchmark/optee-benchmark.hash | 4 ++--
 package/optee-benchmark/optee-benchmark.mk   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/optee-benchmark/optee-benchmark.hash b/package/optee-benchmark/optee-benchmark.hash
index 3797920c35..f36e074eec 100644
--- a/package/optee-benchmark/optee-benchmark.hash
+++ b/package/optee-benchmark/optee-benchmark.hash
@@ -1,4 +1,4 @@
-# From https://github.com/linaro-swg/optee_benchmark/archive/3.15.0/optee-benchmark-3.15.0.tar.gz
-sha256 f1ddac5e9f58333194eb302e6d9840fa334300bc103abb3d9f783bf009a78c50 optee-benchmark-3.15.0.tar.gz
+# From https://github.com/linaro-swg/optee_benchmark/archive/3.16.0/optee-benchmark-3.16.0.tar.gz
+sha256 55b24525f08ffda6799f90ab7bab2125f1c3f17d5cbd1b34480cd28b5f46fca9 optee-benchmark-3.16.0.tar.gz
 # Locally computed
 sha256 0571be5b739142dc3e40e0a4e7e30d4ab8bff0d4d606a3f2db2010745587d383  LICENSE
diff --git a/package/optee-benchmark/optee-benchmark.mk b/package/optee-benchmark/optee-benchmark.mk
index 1357f9f270..493f407a44 100644
--- a/package/optee-benchmark/optee-benchmark.mk
+++ b/package/optee-benchmark/optee-benchmark.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-OPTEE_BENCHMARK_VERSION = 3.15.0
+OPTEE_BENCHMARK_VERSION = 3.16.0
 OPTEE_BENCHMARK_SITE = $(call github,linaro-swg,optee_benchmark,$(OPTEE_BENCHMARK_VERSION))
 OPTEE_BENCHMARK_LICENSE = BSD-2-Clause
 OPTEE_BENCHMARK_LICENSE_FILES = LICENSE
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 1/7] package/python-cryptography: enable host package

[Thomas Petazzoni via buildroot]

Hello Clément,

On Fri, 11 Mar 2022 13:36:30 +0100
Clément Léger <clement.leger@bootlin.com> wrote:

> +HOST_PYTHON_CRYPTOGRAPHY_DEPENDENCIES = \
> +	host-python-setuptools-rust \
> +	host-python-cffi \
> +	host-rustc \
> +	openssl

This openssl dependency seems extremely dubious. Why would a host
package depend on the target variant of openssl?

>  PYTHON_CRYPTOGRAPHY_ENV = \
>  	$(PKG_CARGO_ENV) \
>  	PYO3_CROSS_LIB_DIR="$(STAGING_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)"
> @@ -27,4 +32,6 @@ PYTHON_CRYPTOGRAPHY_DL_ENV = \
>  	$(PKG_CARGO_ENV) \
>  	BR_CARGO_MANIFEST_PATH=src/rust/Cargo.toml
>  
> +

Spurious newline added.

>  $(eval $(python-package))
> +$(eval $(host-python-package))

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 2/7] boot/optee-os: add support to build with python-cryptography

[Thomas Petazzoni via buildroot]

Hello Clément,

On Fri, 11 Mar 2022 13:36:31 +0100
Clément Léger <clement.leger@bootlin.com> wrote:

> Newer version of optee-os (>= 3.16) uses python-cryptography instead of
> python-pycryptodomex in python scripts. Add support to build these
> newer versions by adding a new
> BR2_TARGET_OPTEE_OS_NEEDS_PYTHON_CRYPTOGRAPHY option which will
> select host-python-cryptography dependency when building optee-os.
> 
> Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> ---
>  boot/optee-os/Config.in   | 8 ++++++++
>  boot/optee-os/optee-os.mk | 7 ++++++-
>  2 files changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/boot/optee-os/Config.in b/boot/optee-os/Config.in
> index 0974578484..f8426f9ab2 100644
> --- a/boot/optee-os/Config.in
> +++ b/boot/optee-os/Config.in
> @@ -48,6 +48,14 @@ config BR2_TARGET_OPTEE_OS_CUSTOM_REPO_VERSION
>  
>  endif
>  
> +config BR2_TARGET_OPTEE_OS_NEEDS_PYTHON_CRYPTOGRAPHY
> +	bool "optee-os needs host-python-cryptography to build"

Just:

	bool "optee-os needs host-python-cryptography"

you also need to add some dependencies, because rust is not supported
on all host architectures, so you need:

	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS

> -OPTEE_OS_DEPENDENCIES = host-openssl host-python3 host-python-pycryptodomex host-python-pyelftools
> +OPTEE_OS_DEPENDENCIES = host-openssl host-python3 host-python-pyelftools
> +ifeq ($(BR2_TARGET_OPTEE_OS_NEEDS_PYTHON_CRYPTOGRAPHY),y)
> +OPTEE_OS_DEPENDENCIES += host-python-cryptography
> +else
> +OPTEE_OS_DEPENDENCIES += host-python-pycryptodomex
> +endif

Semantically speaking, it's a bit odd that enabling
BR2_TARGET_OPTEE_OS_NEEDS_PYTHON_CRYPTOGRAPHY drops the
host-python-pycryptodomex dependency. But I guess this is what makes
the most sense in that situation.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 3/7] boot/optee-os: bump to version 3.16.0

[Thomas Petazzoni via buildroot]

Hello Clément,

On Fri, 11 Mar 2022 13:36:32 +0100
Clément Léger <clement.leger@bootlin.com> wrote:

> Bump OP-TEE OS package version to OP-TEE release 3.16.0 and set
> BR2_TARGET_OPTEE_OS_NEEDS_PYTHON_CRYPTOGRAPHY default to 'y' since
> python-cryptography is now needed to build optee-os.
> 
> Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> ---
>  boot/optee-os/Config.in     | 5 +++--
>  boot/optee-os/optee-os.hash | 4 ++--
>  2 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/boot/optee-os/Config.in b/boot/optee-os/Config.in
> index f8426f9ab2..6fe2ae95ac 100644
> --- a/boot/optee-os/Config.in
> +++ b/boot/optee-os/Config.in
> @@ -18,7 +18,7 @@ choice
>  	  Select the version of OP-TEE OS you want to use
>  
>  config BR2_TARGET_OPTEE_OS_LATEST
> -	bool "3.15.0"
> +	bool "3.16.0"
>  	help
>  	  Use the latest release tag from the OP-TEE OS official Git
>  	  repository.
> @@ -50,6 +50,7 @@ endif
>  
>  config BR2_TARGET_OPTEE_OS_NEEDS_PYTHON_CRYPTOGRAPHY
>  	bool "optee-os needs host-python-cryptography to build"
> +	default y

Rather than a "default y", I would instead make
BR2_TARGET_OPTEE_OS_LATEST select
BR2_TARGET_OPTEE_OS_NEEDS_PYTHON_CRYPTOGRAPHY, so that if the latest
version of OP-TEE is used,
BR2_TARGET_OPTEE_OS_NEEDS_PYTHON_CRYPTOGRAPHY is forcefully selected.

However, you will have to propagate the
BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS to the OP-TEE package.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 1/7] package/python-cryptography: enable host package

[Thomas Petazzoni via buildroot]

Hello,

On Fri, 11 Mar 2022 13:36:30 +0100
Clément Léger <clement.leger@bootlin.com> wrote:

> Enable host package and add needed dependencies.
> 
> Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> ---
>  package/python-cryptography/python-cryptography.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/python-cryptography/python-cryptography.mk b/package/python-cryptography/python-cryptography.mk
> index a524f729c8..4ff61c7f86 100644
> --- a/package/python-cryptography/python-cryptography.mk
> +++ b/package/python-cryptography/python-cryptography.mk
> @@ -17,6 +17,11 @@ PYTHON_CRYPTOGRAPHY_DEPENDENCIES = \
>  	host-python-cffi \
>  	host-rustc \
>  	openssl
> +HOST_PYTHON_CRYPTOGRAPHY_DEPENDENCIES = \
> +	host-python-setuptools-rust \
> +	host-python-cffi \
> +	host-rustc \
> +	openssl

Also, I am actually surprised this is enough. Indeed, there are some
parts in Rust in python-cryptography, so we have quite some extra
variables for the target packages to handle this:

PYTHON_CRYPTOGRAPHY_ENV = \
        $(PKG_CARGO_ENV) \
        PYO3_CROSS_LIB_DIR="$(STAGING_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)"
# We need to vendor the Cargo crates at download time
PYTHON_CRYPTOGRAPHY_DOWNLOAD_POST_PROCESS = cargo
PYTHON_CRYPTOGRAPHY_DOWNLOAD_DEPENDENCIES = host-rustc
PYTHON_CRYPTOGRAPHY_DL_ENV = \
        BR_CARGO_MANIFEST_PATH=src/rust/Cargo.toml

For the last 3 variables, I can explain that it possibly worked for you
because you perhaps already had the python-cryptography tarball in
DL_DIR downloaded by the host variant of the package. But if you remove
this tarball, and build just the host variant, I would suspect that it
will fail to build.

However, I can't really explain why your package works without
HOST_PYTHON_CRYTOGRAPHY_ENV.

Make sure to do a clean build in a Docker container that doesn't have
Rust installed (there is an official Buildroot Docker image that is
available for this kind of testing).

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 0/7] boot/optee-os: support new optee-os 3.16.0 build dependencies

[Yann E. MORIN]

Clément, All,

On 2022-03-11 13:36 +0100, Clément Léger via buildroot spake thusly:
> Newer versions of optee-os (>= 3.16.0) uses python-cryptography instead
> of python-pycryptodomex to build. This series adds support to build
> host-python-cryptography and uses it in optee-os package to build the
> 3.16.0 version. Also bump optee-client, optee-benchmark, optee-examples
> and optee-test which needs to be aligned with optee-os version.

Following the important review from Thomas on patch 1, I've marked this
series as changes requested in Patchwork.

Please, can you add me in Cc of patch 1 in a future respin (I too may
have to deal with python-cryptography on the host in short order).

Regards,
Yann E. MORIN.

> ----
> Changes in v3:
> - Fix authorship for commits that were copied from Etienne ones.
> - Fix package URL for optee-os
> - Added Acked-by Etienne Carriere
> 
> Changes in v2:
> - Bump optee-client, optee-benchmark, optee-examples and optee-test
> 
> Clément Léger (7):
>   package/python-cryptography: enable host package
>   boot/optee-os: add support to build with python-cryptography
>   boot/optee-os: bump to version 3.16.0
>   package/optee-test: bump to version 3.16.0
>   package/optee-examples: bump to version 3.16.0
>   package/optee-client: bump to version 3.16.0
>   package/optee-benchmark: bump to version 3.16.0
> 
>  boot/optee-os/Config.in                            | 13 +++++++++++--
>  boot/optee-os/optee-os.hash                        |  4 ++--
>  boot/optee-os/optee-os.mk                          |  7 ++++++-
>  package/optee-benchmark/optee-benchmark.hash       |  4 ++--
>  package/optee-benchmark/optee-benchmark.mk         |  2 +-
>  package/optee-client/optee-client.hash             |  4 ++--
>  package/optee-client/optee-client.mk               |  2 +-
>  package/optee-examples/optee-examples.hash         |  4 ++--
>  package/optee-examples/optee-examples.mk           |  2 +-
>  package/optee-test/optee-test.hash                 |  4 ++--
>  package/optee-test/optee-test.mk                   |  2 +-
>  package/python-cryptography/python-cryptography.mk |  7 +++++++
>  12 files changed, 38 insertions(+), 17 deletions(-)
> 
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 0/7] boot/optee-os: support new optee-os 3.16.0 build dependencies

[Clément Léger via buildroot]

Le Sat, 12 Mar 2022 21:36:27 +0100,
"Yann E. MORIN" <yann.morin.1998@free.fr> a écrit :

> Clément, All,
> 
> On 2022-03-11 13:36 +0100, Clément Léger via buildroot spake thusly:
> > Newer versions of optee-os (>= 3.16.0) uses python-cryptography instead
> > of python-pycryptodomex to build. This series adds support to build
> > host-python-cryptography and uses it in optee-os package to build the
> > 3.16.0 version. Also bump optee-client, optee-benchmark, optee-examples
> > and optee-test which needs to be aligned with optee-os version.  
> 
> Following the important review from Thomas on patch 1, I've marked this
> series as changes requested in Patchwork.
> 
> Please, can you add me in Cc of patch 1 in a future respin (I too may
> have to deal with python-cryptography on the host in short order).

Ok, I'll do so !

Thanks,

Clément

> 
> Regards,
> Yann E. MORIN.
> 
> > ----
> > Changes in v3:
> > - Fix authorship for commits that were copied from Etienne ones.
> > - Fix package URL for optee-os
> > - Added Acked-by Etienne Carriere
> > 
> > Changes in v2:
> > - Bump optee-client, optee-benchmark, optee-examples and optee-test
> > 
> > Clément Léger (7):
> >   package/python-cryptography: enable host package
> >   boot/optee-os: add support to build with python-cryptography
> >   boot/optee-os: bump to version 3.16.0
> >   package/optee-test: bump to version 3.16.0
> >   package/optee-examples: bump to version 3.16.0
> >   package/optee-client: bump to version 3.16.0
> >   package/optee-benchmark: bump to version 3.16.0
> > 
> >  boot/optee-os/Config.in                            | 13 +++++++++++--
> >  boot/optee-os/optee-os.hash                        |  4 ++--
> >  boot/optee-os/optee-os.mk                          |  7 ++++++-
> >  package/optee-benchmark/optee-benchmark.hash       |  4 ++--
> >  package/optee-benchmark/optee-benchmark.mk         |  2 +-
> >  package/optee-client/optee-client.hash             |  4 ++--
> >  package/optee-client/optee-client.mk               |  2 +-
> >  package/optee-examples/optee-examples.hash         |  4 ++--
> >  package/optee-examples/optee-examples.mk           |  2 +-
> >  package/optee-test/optee-test.hash                 |  4 ++--
> >  package/optee-test/optee-test.mk                   |  2 +-
> >  package/python-cryptography/python-cryptography.mk |  7 +++++++
> >  12 files changed, 38 insertions(+), 17 deletions(-)
> > 
> > -- 
> > 2.34.1
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot  
> 



-- 
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 1/7] package/python-cryptography: enable host package

[Clément Léger via buildroot]

Le Fri, 11 Mar 2022 21:43:32 +0100,
Thomas Petazzoni <thomas.petazzoni@bootlin.com> a écrit :

> Hello Clément,
> 
> On Fri, 11 Mar 2022 13:36:30 +0100
> Clément Léger <clement.leger@bootlin.com> wrote:
> 
> > +HOST_PYTHON_CRYPTOGRAPHY_DEPENDENCIES = \
> > +	host-python-setuptools-rust \
> > +	host-python-cffi \
> > +	host-rustc \
> > +	openssl  
> 
> This openssl dependency seems extremely dubious. Why would a host
> package depend on the target variant of openssl?

Yes, of course that is a host-openssl dependency that is needed.

> 
> >  PYTHON_CRYPTOGRAPHY_ENV = \
> >  	$(PKG_CARGO_ENV) \
> >  	PYO3_CROSS_LIB_DIR="$(STAGING_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)"
> > @@ -27,4 +32,6 @@ PYTHON_CRYPTOGRAPHY_DL_ENV = \
> >  	$(PKG_CARGO_ENV) \
> >  	BR_CARGO_MANIFEST_PATH=src/rust/Cargo.toml
> >  
> > +  
> 
> Spurious newline added.
> 
> >  $(eval $(python-package))
> > +$(eval $(host-python-package))  
> 
> Thomas



-- 
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 1/7] package/python-cryptography: enable host package

[Clément Léger via buildroot]

Le Sat, 12 Mar 2022 15:59:13 +0100,
Thomas Petazzoni <thomas.petazzoni@bootlin.com> a écrit :

> Hello,
> 
> On Fri, 11 Mar 2022 13:36:30 +0100
> Clément Léger <clement.leger@bootlin.com> wrote:
> 
> > Enable host package and add needed dependencies.
> > 
> > Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
> > Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> > ---
> >  package/python-cryptography/python-cryptography.mk | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/package/python-cryptography/python-cryptography.mk b/package/python-cryptography/python-cryptography.mk
> > index a524f729c8..4ff61c7f86 100644
> > --- a/package/python-cryptography/python-cryptography.mk
> > +++ b/package/python-cryptography/python-cryptography.mk
> > @@ -17,6 +17,11 @@ PYTHON_CRYPTOGRAPHY_DEPENDENCIES = \
> >  	host-python-cffi \
> >  	host-rustc \
> >  	openssl
> > +HOST_PYTHON_CRYPTOGRAPHY_DEPENDENCIES = \
> > +	host-python-setuptools-rust \
> > +	host-python-cffi \
> > +	host-rustc \
> > +	openssl  
> 
> Also, I am actually surprised this is enough. Indeed, there are some
> parts in Rust in python-cryptography, so we have quite some extra
> variables for the target packages to handle this:
> 
> PYTHON_CRYPTOGRAPHY_ENV = \
>         $(PKG_CARGO_ENV) \
>         PYO3_CROSS_LIB_DIR="$(STAGING_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)"
> # We need to vendor the Cargo crates at download time
> PYTHON_CRYPTOGRAPHY_DOWNLOAD_POST_PROCESS = cargo
> PYTHON_CRYPTOGRAPHY_DOWNLOAD_DEPENDENCIES = host-rustc
> PYTHON_CRYPTOGRAPHY_DL_ENV = \
>         BR_CARGO_MANIFEST_PATH=src/rust/Cargo.toml
> 
> For the last 3 variables, I can explain that it possibly worked for you
> because you perhaps already had the python-cryptography tarball in
> DL_DIR downloaded by the host variant of the package. But if you remove
> this tarball, and build just the host variant, I would suspect that it
> will fail to build.

Indeed, I'm using a shared BR2_DL_DIR which might explain why it worked.

> 
> However, I can't really explain why your package works without
> HOST_PYTHON_CRYTOGRAPHY_ENV.
> 
> Make sure to do a clean build in a Docker container that doesn't have
> Rust installed (there is an official Buildroot Docker image that is
> available for this kind of testing).

Ok, I'll do that.

> 
> Thanks!
> 
> Thomas



-- 
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot