[Buildroot] [PATCH] package/wireplumber: make dbus optional

[Buildroot] [PATCH] package/wireplumber: make dbus optional

[Théo Lebrun via buildroot]

Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
---
 package/wireplumber/wireplumber.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/package/wireplumber/wireplumber.mk b/package/wireplumber/wireplumber.mk
index 327138391d..763e3d7639 100644
--- a/package/wireplumber/wireplumber.mk
+++ b/package/wireplumber/wireplumber.mk
@@ -9,13 +9,17 @@ WIREPLUMBER_SOURCE = wireplumber-$(WIREPLUMBER_VERSION).tar.bz2
 WIREPLUMBER_SITE = https://gitlab.freedesktop.org/pipewire/wireplumber/-/archive/$(WIREPLUMBER_VERSION)
 WIREPLUMBER_LICENSE = MIT
 WIREPLUMBER_LICENSE_FILES = LICENSE
-WIREPLUMBER_DEPENDENCIES = host-pkgconf dbus pipewire libglib2 lua
+WIREPLUMBER_DEPENDENCIES = host-pkgconf pipewire libglib2 lua
 
 WIREPLUMBER_CONF_OPTS = \
 	-Ddoc=disabled \
 	-Dsystem-lua=true \
 	-Dsystem-lua-version=
 
+ifeq ($(BR2_PACKAGE_DBUS),y)
+WIREPLUMBER_DEPENDENCIES += dbus
+endif
+
 ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
 WIREPLUMBER_DEPENDENCIES += host-doxygen host-python-lxml gobject-introspection
 WIREPLUMBER_CONF_OPTS += -Dintrospection=enabled
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/wireplumber: make dbus optional

[Thomas Petazzoni via buildroot]

On Mon, 11 Apr 2022 15:01:06 +0200
Théo Lebrun via buildroot <buildroot@buildroot.org> wrote:

> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
> ---
>  package/wireplumber/wireplumber.mk | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

I've applied to master, but after significantly expanding the commit
log, and changing the commit title. Indeed your patch is a fix for a
real problem: wireplumber was depending on dbus at the makefile level,
but this dependency was not captured at the Kconfig level, which is
bad, and causes a build failure.

Thanks for your fix!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/wireplumber: make dbus optional

[Peter Korsgaard]

>>>>> "Théo" == Théo Lebrun via buildroot <buildroot@buildroot.org> writes:

 > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot