[Buildroot] [PATCH] package/libwebsockets: Require C++ toolchain

[Buildroot] [PATCH] package/libwebsockets: Require C++ toolchain

[Johannes Agricola]

Autobuild for libwebsockets failed as a C++ toolchain is required:

http://autobuild.buildroot.net/results/f9631db632211e610b8a146e22bffda0ffb8fa28/build-end.log

Signed-off-by: Johannes Agricola <johannes.agricola@work-microwave.com>
---
 package/libwebsockets/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/libwebsockets/Config.in b/package/libwebsockets/Config.in
index d7b529cafd..59d1e1097f 100644
--- a/package/libwebsockets/Config.in
+++ b/package/libwebsockets/Config.in
@@ -1,6 +1,6 @@
 config BR2_PACKAGE_LIBWEBSOCKETS
 	bool "libwebsockets"
-	depends on !BR2_STATIC_LIBS
+	depends on !BR2_STATIC_LIBS && BR2_INSTALL_LIBSTDCPP
 	select BR2_PACKAGE_ZLIB
 	help
 	  Libwebsockets is a lightweight pure C library built to use
@@ -9,5 +9,5 @@ config BR2_PACKAGE_LIBWEBSOCKETS
 
 	  https://libwebsockets.org/
 
-comment "libwebsockets needs a toolchain w/ dynamic library"
-	depends on BR2_STATIC_LIBS
+comment "libwebsockets needs a toolchain w/ dynamic library and C++ support"
+	depends on BR2_STATIC_LIBS || !BR2_INSTALL_LIBSTDCPP
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/libwebsockets: Require C++ toolchain

[Johannes Agricola]

[-- Attachment #1.1.1.1.1: Type: text/plain, Size: 367 bytes --]

This patch is obsolete with Fabrice Fontaine's,

 > 
https://patchwork.ozlabs.org/project/buildroot/patch/20220413190815.888854-1-fontaine.fabrice@gmail.com/

which has also already been merged into libwebsockets master.

 > 
https://github.com/warmcat/libwebsockets/commit/a04aaad7f0db685e4d8acbee1952ff2c4be51ee0

Please ignore this one. :)

Cheeers


[-- Attachment #1.1.1.1.2: Type: text/html, Size: 858 bytes --]

[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3207 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/libwebsockets: Require C++ toolchain

[Thomas Petazzoni via buildroot]

On Wed, 13 Apr 2022 22:28:42 +0200
Johannes Agricola <johannes.agricola@work-microwave.com> wrote:

> Please ignore this one. :)

Thanks for your patch. I've marked it as Rejected, as you suggested.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot