Re: [Buildroot] [PATCH 1/2] package/byacc: add new package

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Thomas Perrot <thomas.perrot@bootlin.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/byacc: add new package
Date: Tue, 19 Apr 2022 14:12:44 +0200	[thread overview]
Message-ID: <20220419141244.1ef13dd4@windsurf> (raw)
In-Reply-To: <20220419092151.91638-2-thomas.perrot@bootlin.com>

Hello Thomas,

Thanks for your contribution.

Commit title should be just:

	package/byacc: new package

On Tue, 19 Apr 2022 11:21:50 +0200
Thomas Perrot <thomas.perrot@bootlin.com> wrote:

> This package provides a Berkeley LALR Yacc parser generator that has been use
> by i.MX Code Signing tool.
> 
> Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
> ---
>  DEVELOPERS                   |  3 +++
>  package/byacc/Config.in.host | 10 ++++++++++

Config.in.host not needed, this package is merely a build dependency of
another, so we don't need to see it in menuconfig.

> +N:	Thomas Perrot <thomas.perrot@bootlin.com>
> +F:	package/byacc

Please add a trailing slash, like other entries in this file.

> diff --git a/package/byacc/byacc.hash b/package/byacc/byacc.hash
> new file mode 100644
> index 000000000000..d2ad441df39f
> --- /dev/null
> +++ b/package/byacc/byacc.hash
> @@ -0,0 +1,3 @@
> +# Locally calculated
> +sha256  42c1805cc529314e6a76326fe1b33e80c70862a44b01474da362e2f7db2d749c  byacc-20220128.tgz
> +sha256  654a231fe9cd4d36e580214962fa777a1df0771d6889cfc74d19a3d414f14711  LICENSE
> diff --git a/package/byacc/byacc.mk b/package/byacc/byacc.mk
> new file mode 100644
> index 000000000000..103970aac9d2
> --- /dev/null
> +++ b/package/byacc/byacc.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# byacc
> +#
> +################################################################################
> +
> +BYACC_SITE = https://invisible-mirror.net/archives/byacc
> +BYACC_VERSION = 20220128
> +BYACC_SOURCE = byacc-$(BYACC_VERSION).tgz
> +BYACC_LICENSE = Public Domain
> +BYACC_LICENSE_FILES = LICENSE
> +
> +HOST_BYACC_CONF_OPTS = --program-transform-name='s,^,b,'

Please add a comment above this that explains why this is needed, it
looks strange.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot