Re: [Buildroot] [PATCH 2/2] package/imx-cst: add new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Tue, 19 Apr 2022 14:26:35 +0200
Thomas Petazzoni via buildroot <buildroot@buildroot.org> wrote:

> This looks strange. Flags are normally passed using CFLAGS, and $(CC)
> in Buildroot doesn't exist, it's $(HOSTCC) that should be used.
> 
> Also, I think the list of header paths is properly set with:
> 
> CINCLUDES := $(SUBSYS:%=-I$(CST_CODE_PATH)/%/hdr)
> 
> but it gets overridden by the fact that you override CFLAGS.
> 
> I believe there's a better way, let me have a look.

Here is what I could come up with:

ifneq ($(filter %64,$(HOSTARCH)),)
HOST_IMX_CST_OSTYPE = linux64
else
HOST_IMX_CST_OSTYPE = linux32
endif

# We don't use HOST_CONFIGURE_OPTS when building cst, because we need
# to preserve the CFLAGS/LDFLAGS used by their Makefile.
define HOST_IMX_CST_BUILD_CMDS
	$(HOST_MAKE_ENV) $(MAKE) \
		OSTYPE=$(HOST_IMX_CST_OSTYPE) \
		ENCRYPTION=yes \
		AR="$(HOSTAR)" \
		CC="$(HOSTCC)" \
		LD="$(HOSTCC)" \
		OBJCOPY="$(HOSTOBJCOPY)" \
		RANLIB="$(HOSTRANLIB)" \
		EXTRACFLAGS="$(HOST_CFLAGS) $(HOST_CPPFLAGS)" \
		EXTRALDFLAGS="$(HOST_LDFLAGS)" \
		PWD=$(@D)/code/cst \
		-C $(@D)/code/cst \
		build
	$(HOST_MAKE_ENV) $(MAKE) $(HOST_CONFIGURE_OPTS) \
		COPTS="$(HOST_CFLAGS) $(HOST_CPPFLAGS) $(HOST_LDFLAGS)" \
		-C $(@D)/code/hab_csf_parser
endef

define HOST_IMX_CST_INSTALL_CMDS
	$(INSTALL) -D -m 755 $(@D)/code/cst/code/obj.$(HOST_IMX_CST_OSTYPE)/cst $(HOST_DIR)/bin/cst
	$(INSTALL) -D -m 755 $(@D)/code/cst/code/obj.$(HOST_IMX_CST_OSTYPE)/srktool $(HOST_DIR)/bin/srktool
	$(INSTALL) -D -m 755 $(@D)/code/hab_csf_parser/csf_parser $(HOST_DIR)/bin/csf_parser
endef

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot