From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/nodejs: clean up DEPENDENCIES
Date: Thu, 12 May 2022 22:18:27 +0200 [thread overview]
Message-ID: <20220512201827.GH1597494@scaer> (raw)
In-Reply-To: <20220512121217.176652-1-arnout@mind.be>
Arnout, All,
On 2022-05-12 14:12 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> One per line, and alphabetical (was already the case for host).
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> package/nodejs/nodejs.mk | 17 ++++++++++++++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
> index 6dcaf34aa4..909347eb2e 100644
> --- a/package/nodejs/nodejs.mk
> +++ b/package/nodejs/nodejs.mk
> @@ -7,10 +7,21 @@
> NODEJS_VERSION = 16.15.0
> NODEJS_SOURCE = node-v$(NODEJS_VERSION).tar.xz
> NODEJS_SITE = http://nodejs.org/dist/v$(NODEJS_VERSION)
> -NODEJS_DEPENDENCIES = host-qemu host-pkgconf host-python3 host-nodejs c-ares \
> - libuv zlib nghttp2 \
> +NODEJS_DEPENDENCIES = \
> + c-ares \
> + host-nodejs \
> + host-pkgconf \
> + host-python3 \
> + host-qemu \
I prefer when all host dependencies go first, then all target
dependencies, so I've also lightly re-oredered.
Applied to master, thanks.
Regards,
Yann E. MORIN.
> + libuv \
> + nghttp2 \
> + zlib \
> $(call qstrip,$(BR2_PACKAGE_NODEJS_MODULES_ADDITIONAL_DEPS))
> -HOST_NODEJS_DEPENDENCIES = host-icu host-libopenssl host-pkgconf host-python3 \
> +HOST_NODEJS_DEPENDENCIES = \
> + host-icu \
> + host-libopenssl \
> + host-pkgconf \
> + host-python3 \
> host-zlib
> NODEJS_INSTALL_STAGING = YES
> NODEJS_LICENSE = MIT (core code); MIT, Apache and BSD family licenses (Bundled components)
> --
> 2.35.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-05-12 20:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 12:12 [Buildroot] [PATCH 1/2] package/nodejs: clean up DEPENDENCIES Arnout Vandecappelle (Essensium/Mind)
2022-05-12 12:12 ` [Buildroot] [PATCH 2/2] package/nodejs: use ninja for build Arnout Vandecappelle (Essensium/Mind)
2022-05-12 20:18 ` Yann E. MORIN
2022-05-12 20:18 ` Yann E. MORIN [this message]
2022-05-12 22:34 ` [Buildroot] [PATCH 1/2] package/nodejs: clean up DEPENDENCIES Arnout Vandecappelle
2022-05-28 10:46 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512201827.GH1597494@scaer \
--to=yann.morin.1998@free.fr \
--cc=arnout@mind.be \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox