From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/nodejs: use ninja for build
Date: Thu, 12 May 2022 22:18:52 +0200 [thread overview]
Message-ID: <20220512201852.GI1597494@scaer> (raw)
In-Reply-To: <20220512121217.176652-2-arnout@mind.be>
Arnout, All,
On 2022-05-12 14:12 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> Not only is ninja much faster, it also avoids the following build
> failure:
> make[3]: printf: Argument list too long
>
> This failure happens when the output directory is about 6 levels deep.
> It's due to the make generator of gyp that uses some crazy shell
> processing for splitting up paths on /. The ninja generator does no such
> thing.
>
> While we're at it, remove redundant parenthesis in
> HOST_NODEJS_CONFIGURE_CMDS.
Thank you! \o/
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/nodejs/nodejs.mk | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
> index 909347eb2e..70febca74f 100644
> --- a/package/nodejs/nodejs.mk
> +++ b/package/nodejs/nodejs.mk
> @@ -10,6 +10,7 @@ NODEJS_SITE = http://nodejs.org/dist/v$(NODEJS_VERSION)
> NODEJS_DEPENDENCIES = \
> c-ares \
> host-nodejs \
> + host-ninja \
> host-pkgconf \
> host-python3 \
> host-qemu \
> @@ -20,6 +21,7 @@ NODEJS_DEPENDENCIES = \
> HOST_NODEJS_DEPENDENCIES = \
> host-icu \
> host-libopenssl \
> + host-ninja \
> host-pkgconf \
> host-python3 \
> host-zlib
> @@ -37,7 +39,8 @@ NODEJS_CONF_OPTS = \
> --without-dtrace \
> --without-etw \
> --cross-compiling \
> - --dest-os=linux
> + --dest-os=linux \
> + --ninja
>
> HOST_NODEJS_MAKE_OPTS = \
> $(HOST_CONFIGURE_OPTS) \
> @@ -82,7 +85,7 @@ NODEJS_CONF_OPTS += --without-npm
> endif
>
> define HOST_NODEJS_CONFIGURE_CMDS
> - (cd $(@D); \
> + cd $(@D); \
> $(HOST_CONFIGURE_OPTS) \
> PATH=$(@D)/bin:$(BR_PATH) \
> PYTHON=$(HOST_DIR)/bin/python3 \
> @@ -96,7 +99,7 @@ define HOST_NODEJS_CONFIGURE_CMDS
> --shared-zlib \
> --no-cross-compiling \
> --with-intl=system-icu \
> - )
> + --ninja
> endef
>
> NODEJS_HOST_TOOLS_V8 = \
> --
> 2.35.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-05-12 20:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 12:12 [Buildroot] [PATCH 1/2] package/nodejs: clean up DEPENDENCIES Arnout Vandecappelle (Essensium/Mind)
2022-05-12 12:12 ` [Buildroot] [PATCH 2/2] package/nodejs: use ninja for build Arnout Vandecappelle (Essensium/Mind)
2022-05-12 20:18 ` Yann E. MORIN [this message]
2022-05-12 20:18 ` [Buildroot] [PATCH 1/2] package/nodejs: clean up DEPENDENCIES Yann E. MORIN
2022-05-12 22:34 ` Arnout Vandecappelle
2022-05-28 10:46 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512201852.GI1597494@scaer \
--to=yann.morin.1998@free.fr \
--cc=arnout@mind.be \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox