From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/pinentry: add missing !BR2_ARM_CPU_ARMV4 dependency
Date: Tue, 17 May 2022 21:56:33 +0200 [thread overview]
Message-ID: <20220517215633.216b348e@windsurf> (raw)
In-Reply-To: <20220514224200.1156944-1-james.hilliard1@gmail.com>
Hello James,
On Sat, 14 May 2022 16:42:00 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> Propagate this missing BR2_PACKAGE_QT5 dependency.
>
> Fixes:
> WARNING: unmet direct dependencies detected for BR2_PACKAGE_QT5
> Depends on [n]: BR2_INSTALL_LIBSTDCPP [=y] && BR2_USE_WCHAR [=y] && BR2_TOOLCHAIN_HAS_THREADS_NPTL [=y] && BR2_HOST_GCC_AT_LEAST_5 [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_5 [=y] && !BR2_ARM_CPU_ARMV4 [=y] && !BR2_STATIC_LIBS [=n]
> Selected by [y]:
> - BR2_PACKAGE_PINENTRY_QT5 [=y] && BR2_PACKAGE_PINENTRY [=y] && BR2_INSTALL_LIBSTDCPP [=y] && BR2_USE_WCHAR [=y] && BR2_TOOLCHAIN_HAS_THREADS_NPTL [=y] && BR2_HOST_GCC_AT_LEAST_5 [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_5 [=y] && !BR2_arc [=n] && !BR2_STATIC_LIBS [=n]
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
I have applied, but after also updating the Config.in comment with this
new dependency:
comment "pinentry-qt5 needs a host gcc >= 5.0, and a toolchain w/ wchar, NPTL, gcc >= 5.0, C++, dynamic library"
depends on !BR2_arc
depends on !BR2_ARM_CPU_ARMV4
depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
!BR2_TOOLCHAIN_HAS_THREADS_NPTL || !BR2_TOOLCHAIN_GCC_AT_LEAST_5 || \
BR2_STATIC_LIBS || !BR2_HOST_GCC_AT_LEAST_5
However, I noticed that the !BR2_arc dependency no longer makes sense.
It was dropped from Qt5 in commit
16ffc6549465cb5d68b751f10603e8b0363bf9b0.
This means that commit 16ffc6549465cb5d68b751f10603e8b0363bf9b0 did not
properly drop this !BR2_arc dependency from reverse dependencies of
Qt5. Reviewing this shows that package/wireshark also had a !BR2_arc
dependency due to Qt5, which probably should be dropped.
It would be good to fix that as well.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-05-17 19:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-14 22:42 [Buildroot] [PATCH 1/1] package/pinentry: add missing !BR2_ARM_CPU_ARMV4 dependency James Hilliard
2022-05-17 19:56 ` Thomas Petazzoni via buildroot [this message]
2022-05-29 8:42 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517215633.216b348e@windsurf \
--to=buildroot@buildroot.org \
--cc=Alexey.Brodkin@synopsys.com \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox