[Buildroot] [PATCH 1/1] package/pinentry: add missing !BR2_ARM_CPU_ARMV4 dependency

[Buildroot] [PATCH 1/1] package/pinentry: add missing !BR2_ARM_CPU_ARMV4 dependency

[James Hilliard]

Propagate this missing BR2_PACKAGE_QT5 dependency.

Fixes:
WARNING: unmet direct dependencies detected for BR2_PACKAGE_QT5
  Depends on [n]: BR2_INSTALL_LIBSTDCPP [=y] && BR2_USE_WCHAR [=y] && BR2_TOOLCHAIN_HAS_THREADS_NPTL [=y] && BR2_HOST_GCC_AT_LEAST_5 [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_5 [=y] && !BR2_ARM_CPU_ARMV4 [=y] && !BR2_STATIC_LIBS [=n]
  Selected by [y]:
  - BR2_PACKAGE_PINENTRY_QT5 [=y] && BR2_PACKAGE_PINENTRY [=y] && BR2_INSTALL_LIBSTDCPP [=y] && BR2_USE_WCHAR [=y] && BR2_TOOLCHAIN_HAS_THREADS_NPTL [=y] && BR2_HOST_GCC_AT_LEAST_5 [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_5 [=y] && !BR2_arc [=n] && !BR2_STATIC_LIBS [=n]

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 package/pinentry/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/pinentry/Config.in b/package/pinentry/Config.in
index 3f005f8c58..24acf4c478 100644
--- a/package/pinentry/Config.in
+++ b/package/pinentry/Config.in
@@ -74,6 +74,7 @@ config BR2_PACKAGE_PINENTRY_QT5
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	depends on BR2_HOST_GCC_AT_LEAST_5
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5
+	depends on !BR2_ARM_CPU_ARMV4
 	depends on !BR2_arc
 	depends on !BR2_STATIC_LIBS
 	select BR2_PACKAGE_QT5
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/pinentry: add missing !BR2_ARM_CPU_ARMV4 dependency

[Thomas Petazzoni via buildroot]

Hello James,

On Sat, 14 May 2022 16:42:00 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> Propagate this missing BR2_PACKAGE_QT5 dependency.
> 
> Fixes:
> WARNING: unmet direct dependencies detected for BR2_PACKAGE_QT5
>   Depends on [n]: BR2_INSTALL_LIBSTDCPP [=y] && BR2_USE_WCHAR [=y] && BR2_TOOLCHAIN_HAS_THREADS_NPTL [=y] && BR2_HOST_GCC_AT_LEAST_5 [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_5 [=y] && !BR2_ARM_CPU_ARMV4 [=y] && !BR2_STATIC_LIBS [=n]
>   Selected by [y]:
>   - BR2_PACKAGE_PINENTRY_QT5 [=y] && BR2_PACKAGE_PINENTRY [=y] && BR2_INSTALL_LIBSTDCPP [=y] && BR2_USE_WCHAR [=y] && BR2_TOOLCHAIN_HAS_THREADS_NPTL [=y] && BR2_HOST_GCC_AT_LEAST_5 [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_5 [=y] && !BR2_arc [=n] && !BR2_STATIC_LIBS [=n]
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

I have applied, but after also updating the Config.in comment with this
new dependency:

comment "pinentry-qt5 needs a host gcc >= 5.0, and a toolchain w/ wchar, NPTL, gcc >= 5.0, C++, dynamic library"
        depends on !BR2_arc
        depends on !BR2_ARM_CPU_ARMV4
        depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
                !BR2_TOOLCHAIN_HAS_THREADS_NPTL || !BR2_TOOLCHAIN_GCC_AT_LEAST_5 || \
                BR2_STATIC_LIBS || !BR2_HOST_GCC_AT_LEAST_5

However, I noticed that the !BR2_arc dependency no longer makes sense.
It was dropped from Qt5 in commit
16ffc6549465cb5d68b751f10603e8b0363bf9b0.

This means that commit 16ffc6549465cb5d68b751f10603e8b0363bf9b0 did not
properly drop this !BR2_arc dependency from reverse dependencies of
Qt5. Reviewing this shows that package/wireshark also had a !BR2_arc
dependency due to Qt5, which probably should be dropped.

It would be good to fix that as well.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/pinentry: add missing !BR2_ARM_CPU_ARMV4 dependency

[Peter Korsgaard]

>>>>> "James" == James Hilliard <james.hilliard1@gmail.com> writes:

 > Propagate this missing BR2_PACKAGE_QT5 dependency.
 > Fixes:
 > WARNING: unmet direct dependencies detected for BR2_PACKAGE_QT5
 >   Depends on [n]: BR2_INSTALL_LIBSTDCPP [=y] && BR2_USE_WCHAR [=y] && BR2_TOOLCHAIN_HAS_THREADS_NPTL [=y] && BR2_HOST_GCC_AT_LEAST_5 [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_5 [=y] && !BR2_ARM_CPU_ARMV4 [=y] && !BR2_STATIC_LIBS [=n]
 >   Selected by [y]:
 >   - BR2_PACKAGE_PINENTRY_QT5 [=y] && BR2_PACKAGE_PINENTRY [=y] && BR2_INSTALL_LIBSTDCPP [=y] && BR2_USE_WCHAR [=y] && BR2_TOOLCHAIN_HAS_THREADS_NPTL [=y] && BR2_HOST_GCC_AT_LEAST_5 [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_5 [=y] && !BR2_arc [=n] && !BR2_STATIC_LIBS [=n]

 > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot