From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Gary Bisson <bisson.gary@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/gst1-imx: add missing BR2_INSTALL_LIBSTDCPP dependency
Date: Tue, 17 May 2022 21:59:24 +0200 [thread overview]
Message-ID: <20220517215924.133d18c6@windsurf> (raw)
In-Reply-To: <20220514225732.3102078-1-james.hilliard1@gmail.com>
Hello James,
On Sat, 14 May 2022 16:57:32 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> Fixes:
> WARNING: unmet direct dependencies detected for BR2_PACKAGE_GST1_PLUGINS_BAD
> Depends on [n]: BR2_PACKAGE_GSTREAMER1 [=y] && BR2_INSTALL_LIBSTDCPP [=n]
> Selected by [y]:
> - BR2_PACKAGE_GST1_IMX_V4L2VIDEOSRC [=y] && BR2_PACKAGE_GSTREAMER1 [=y] && BR2_PACKAGE_GST1_IMX [=y]
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
The commit title prefix should have been package/gstreamer1/gst1-imx.
But more importantly, you had forgotten to add a Config.in comment
about this C++ dependency.
I've fixed both issues, and applied. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-05-17 19:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-14 22:57 [Buildroot] [PATCH 1/1] package/gst1-imx: add missing BR2_INSTALL_LIBSTDCPP dependency James Hilliard
2022-05-17 19:59 ` Thomas Petazzoni via buildroot [this message]
2022-05-29 8:45 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517215924.133d18c6@windsurf \
--to=buildroot@buildroot.org \
--cc=bisson.gary@gmail.com \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox