Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/gst1-imx: add missing BR2_INSTALL_LIBSTDCPP dependency
@ 2022-05-14 22:57 James Hilliard
  2022-05-17 19:59 ` Thomas Petazzoni via buildroot
  2022-05-29  8:45 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: James Hilliard @ 2022-05-14 22:57 UTC (permalink / raw)
  To: buildroot; +Cc: Gary Bisson, James Hilliard

Fixes:
WARNING: unmet direct dependencies detected for BR2_PACKAGE_GST1_PLUGINS_BAD
  Depends on [n]: BR2_PACKAGE_GSTREAMER1 [=y] && BR2_INSTALL_LIBSTDCPP [=n]
  Selected by [y]:
  - BR2_PACKAGE_GST1_IMX_V4L2VIDEOSRC [=y] && BR2_PACKAGE_GSTREAMER1 [=y] && BR2_PACKAGE_GST1_IMX [=y]

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 package/gstreamer1/gst1-imx/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/gstreamer1/gst1-imx/Config.in b/package/gstreamer1/gst1-imx/Config.in
index 41ef8548c5..18ffd1f7f5 100644
--- a/package/gstreamer1/gst1-imx/Config.in
+++ b/package/gstreamer1/gst1-imx/Config.in
@@ -81,6 +81,7 @@ comment "imxvpu needs the VPU imxvpuapi library"
 
 config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSRC
 	bool "imxv4l2videosrc"
+	depends on BR2_INSTALL_LIBSTDCPP # gst1-plugins-bad
 	select BR2_PACKAGE_GST1_PLUGINS_BAD
 	help
 	  Elements for V4L2 capture
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/gst1-imx: add missing BR2_INSTALL_LIBSTDCPP dependency
  2022-05-14 22:57 [Buildroot] [PATCH 1/1] package/gst1-imx: add missing BR2_INSTALL_LIBSTDCPP dependency James Hilliard
@ 2022-05-17 19:59 ` Thomas Petazzoni via buildroot
  2022-05-29  8:45 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-05-17 19:59 UTC (permalink / raw)
  To: James Hilliard; +Cc: Gary Bisson, buildroot

Hello James,

On Sat, 14 May 2022 16:57:32 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> Fixes:
> WARNING: unmet direct dependencies detected for BR2_PACKAGE_GST1_PLUGINS_BAD
>   Depends on [n]: BR2_PACKAGE_GSTREAMER1 [=y] && BR2_INSTALL_LIBSTDCPP [=n]
>   Selected by [y]:
>   - BR2_PACKAGE_GST1_IMX_V4L2VIDEOSRC [=y] && BR2_PACKAGE_GSTREAMER1 [=y] && BR2_PACKAGE_GST1_IMX [=y]
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

The commit title prefix should have been package/gstreamer1/gst1-imx.

But more importantly, you had forgotten to add a Config.in comment
about this C++ dependency.

I've fixed both issues, and applied. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/gst1-imx: add missing BR2_INSTALL_LIBSTDCPP dependency
  2022-05-14 22:57 [Buildroot] [PATCH 1/1] package/gst1-imx: add missing BR2_INSTALL_LIBSTDCPP dependency James Hilliard
  2022-05-17 19:59 ` Thomas Petazzoni via buildroot
@ 2022-05-29  8:45 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2022-05-29  8:45 UTC (permalink / raw)
  To: James Hilliard; +Cc: Gary Bisson, buildroot

>>>>> "James" == James Hilliard <james.hilliard1@gmail.com> writes:

 > Fixes:
 > WARNING: unmet direct dependencies detected for BR2_PACKAGE_GST1_PLUGINS_BAD
 >   Depends on [n]: BR2_PACKAGE_GSTREAMER1 [=y] && BR2_INSTALL_LIBSTDCPP [=n]
 >   Selected by [y]:
 >   - BR2_PACKAGE_GST1_IMX_V4L2VIDEOSRC [=y] && BR2_PACKAGE_GSTREAMER1 [=y] && BR2_PACKAGE_GST1_IMX [=y]

 > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-05-29  8:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-14 22:57 [Buildroot] [PATCH 1/1] package/gst1-imx: add missing BR2_INSTALL_LIBSTDCPP dependency James Hilliard
2022-05-17 19:59 ` Thomas Petazzoni via buildroot
2022-05-29  8:45 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox