From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Francis Laniel <flaniel@linux.microsoft.com>,
Asaf Kahlon <asafka7@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/grpc: propagate reverse dependencies
Date: Tue, 17 May 2022 23:12:28 +0200 [thread overview]
Message-ID: <20220517231228.21043bb1@windsurf> (raw)
In-Reply-To: <20220514221623.3147598-1-james.hilliard1@gmail.com>
Hello,
On Sat, 14 May 2022 16:16:23 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> diff --git a/package/collectd/Config.in b/package/collectd/Config.in
> index dc6ecd2b72..e471872896 100644
> --- a/package/collectd/Config.in
> +++ b/package/collectd/Config.in
> @@ -683,16 +683,15 @@ config BR2_PACKAGE_COLLECTD_GRPC
> depends on BR2_TOOLCHAIN_HAS_SYNC_4 || BR2_TOOLCHAIN_HAS_ATOMIC # grpc
> depends on BR2_INSTALL_LIBSTDCPP # grpc -> protobuf
> depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS # grpc -> protobuf
> - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # grpc -> libabseil-cpp
> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # grpc -> libabseil-cpp
> depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS # grpc
> select BR2_PACKAGE_GRPC
> help
> Send/receive values using the gRPC protocol.
>
> -comment "grpc needs a toolchain w/ C++, gcc >= 4.9, host gcc >= 4.9"
> +comment "grpc needs a toolchain w/ C++, gcc >= 5, host gcc >= 4.9"
> depends on BR2_TOOLCHAIN_HAS_SYNC_4 || BR2_TOOLCHAIN_HAS_ATOMIC
> - depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 \
> - || !BR2_HOST_GCC_AT_LEAST_4_9
It's good that you dropped BR2_HOST_GCC_AT_LEAST_4_9 because it was
indeed no longer a dependency of BR2_PACKAGE_COLLECTD_GRPC since commit
8251d8c2559b25f11684776fc343059cf100657d, but you had forgotten to
update the Config.in comment (and to also indicate this change in the
commit log, which strictly speaking isn't related to the reverse
dependencies).
> diff --git a/package/falcosecurity-libs/Config.in b/package/falcosecurity-libs/Config.in
> index e0b5a3d134..157bc8ef6d 100644
> --- a/package/falcosecurity-libs/Config.in
> +++ b/package/falcosecurity-libs/Config.in
> @@ -1,11 +1,13 @@
> config BR2_PACKAGE_FALCOSECURITY_LIBS
> bool
Good to update this, but you had forgotten to update the reverse
dependency of BR2_PACKAGE_FALCOSECURITY_LIBS, namely package/sysdig.
I fixed both issues when applying to master.
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-05-17 21:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-14 22:16 [Buildroot] [PATCH 1/1] package/grpc: propagate reverse dependencies James Hilliard
2022-05-17 21:12 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517231228.21043bb1@windsurf \
--to=buildroot@buildroot.org \
--cc=asafka7@gmail.com \
--cc=flaniel@linux.microsoft.com \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox