* [Buildroot] [PATCH 1/1] package/grpc: propagate reverse dependencies
@ 2022-05-14 22:16 James Hilliard
2022-05-17 21:12 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 2+ messages in thread
From: James Hilliard @ 2022-05-14 22:16 UTC (permalink / raw)
To: buildroot; +Cc: Francis Laniel, James Hilliard, Asaf Kahlon
It appears some grpc reverse dependencies aren't propagated properly.
Fixes:
WARNING: unmet direct dependencies detected for BR2_PACKAGE_GRPC
Depends on [n]: BR2_INSTALL_LIBSTDCPP [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_5 [=y] && !BR2_STATIC_LIBS [=n] && (BR2_TOOLCHAIN_HAS_SYNC_4 [=y] || BR2_TOOLCHAIN_HAS_ATOMIC [=y]) && BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS [=n]
Selected by [y]:
- BR2_PACKAGE_FALCOSECURITY_LIBS [=y] && BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS [=y] && BR2_LINUX_KERNEL [=y] && BR2_INSTALL_LIBSTDCPP [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && !BR2_STATIC_LIBS [=n] && BR2_TOOLCHAIN_USES_GLIBC [=y] && BR2_PACKAGE_LUAINTERPRETER_ABI_VERSION_5_1 [=y]
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
package/collectd/Config.in | 7 +++----
package/falcosecurity-libs/Config.in | 4 +++-
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/package/collectd/Config.in b/package/collectd/Config.in
index dc6ecd2b72..e471872896 100644
--- a/package/collectd/Config.in
+++ b/package/collectd/Config.in
@@ -683,16 +683,15 @@ config BR2_PACKAGE_COLLECTD_GRPC
depends on BR2_TOOLCHAIN_HAS_SYNC_4 || BR2_TOOLCHAIN_HAS_ATOMIC # grpc
depends on BR2_INSTALL_LIBSTDCPP # grpc -> protobuf
depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS # grpc -> protobuf
- depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # grpc -> libabseil-cpp
+ depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # grpc -> libabseil-cpp
depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS # grpc
select BR2_PACKAGE_GRPC
help
Send/receive values using the gRPC protocol.
-comment "grpc needs a toolchain w/ C++, gcc >= 4.9, host gcc >= 4.9"
+comment "grpc needs a toolchain w/ C++, gcc >= 5, host gcc >= 4.9"
depends on BR2_TOOLCHAIN_HAS_SYNC_4 || BR2_TOOLCHAIN_HAS_ATOMIC
- depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 \
- || !BR2_HOST_GCC_AT_LEAST_4_9
+ depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_5
depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS
depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS # grpc
diff --git a/package/falcosecurity-libs/Config.in b/package/falcosecurity-libs/Config.in
index e0b5a3d134..157bc8ef6d 100644
--- a/package/falcosecurity-libs/Config.in
+++ b/package/falcosecurity-libs/Config.in
@@ -1,11 +1,13 @@
config BR2_PACKAGE_FALCOSECURITY_LIBS
bool
+ depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS # grpc
depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS # protobuf
depends on BR2_LINUX_KERNEL
depends on BR2_INSTALL_LIBSTDCPP # jsoncpp, protobuf, tbb
- depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # protobuf
+ depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # grpc
depends on BR2_TOOLCHAIN_HAS_THREADS # jq, protobuf, tbb
depends on !BR2_STATIC_LIBS # protobuf, tbb
+ depends on BR2_TOOLCHAIN_HAS_SYNC_4 || BR2_TOOLCHAIN_HAS_ATOMIC # grpc
depends on BR2_TOOLCHAIN_USES_GLIBC # tbb
depends on BR2_PACKAGE_LUAINTERPRETER_ABI_VERSION_5_1
select BR2_PACKAGE_C_ARES
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/grpc: propagate reverse dependencies
2022-05-14 22:16 [Buildroot] [PATCH 1/1] package/grpc: propagate reverse dependencies James Hilliard
@ 2022-05-17 21:12 ` Thomas Petazzoni via buildroot
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-05-17 21:12 UTC (permalink / raw)
To: James Hilliard; +Cc: Francis Laniel, Asaf Kahlon, buildroot
Hello,
On Sat, 14 May 2022 16:16:23 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> diff --git a/package/collectd/Config.in b/package/collectd/Config.in
> index dc6ecd2b72..e471872896 100644
> --- a/package/collectd/Config.in
> +++ b/package/collectd/Config.in
> @@ -683,16 +683,15 @@ config BR2_PACKAGE_COLLECTD_GRPC
> depends on BR2_TOOLCHAIN_HAS_SYNC_4 || BR2_TOOLCHAIN_HAS_ATOMIC # grpc
> depends on BR2_INSTALL_LIBSTDCPP # grpc -> protobuf
> depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS # grpc -> protobuf
> - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # grpc -> libabseil-cpp
> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # grpc -> libabseil-cpp
> depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS # grpc
> select BR2_PACKAGE_GRPC
> help
> Send/receive values using the gRPC protocol.
>
> -comment "grpc needs a toolchain w/ C++, gcc >= 4.9, host gcc >= 4.9"
> +comment "grpc needs a toolchain w/ C++, gcc >= 5, host gcc >= 4.9"
> depends on BR2_TOOLCHAIN_HAS_SYNC_4 || BR2_TOOLCHAIN_HAS_ATOMIC
> - depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 \
> - || !BR2_HOST_GCC_AT_LEAST_4_9
It's good that you dropped BR2_HOST_GCC_AT_LEAST_4_9 because it was
indeed no longer a dependency of BR2_PACKAGE_COLLECTD_GRPC since commit
8251d8c2559b25f11684776fc343059cf100657d, but you had forgotten to
update the Config.in comment (and to also indicate this change in the
commit log, which strictly speaking isn't related to the reverse
dependencies).
> diff --git a/package/falcosecurity-libs/Config.in b/package/falcosecurity-libs/Config.in
> index e0b5a3d134..157bc8ef6d 100644
> --- a/package/falcosecurity-libs/Config.in
> +++ b/package/falcosecurity-libs/Config.in
> @@ -1,11 +1,13 @@
> config BR2_PACKAGE_FALCOSECURITY_LIBS
> bool
Good to update this, but you had forgotten to update the reverse
dependency of BR2_PACKAGE_FALCOSECURITY_LIBS, namely package/sysdig.
I fixed both issues when applying to master.
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-17 21:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-14 22:16 [Buildroot] [PATCH 1/1] package/grpc: propagate reverse dependencies James Hilliard
2022-05-17 21:12 ` Thomas Petazzoni via buildroot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox