[Buildroot] [PATCH 1/1] package/dhcp: fix build without atomic

[Buildroot] [PATCH 1/1] package/dhcp: fix build without atomic

[Fabrice Fontaine]

Fix the following build failure without atomic raised since commit
fde21979427ffeb4fe9c0068310be195f2dec5ec:

/nvmedata/autobuild/instance-25/output-1/host/lib/gcc/mipsel-buildroot-linux-uclibc/10.3.0/../../../../mipsel-buildroot-linux-uclibc/bin/ld: cannot find -latomic: No such file or directory

Fixes:
 - http://autobuild.buildroot.org/results/db6/db6923915e36bcdb2953a3cdd2b450fa10794631

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/dhcp/dhcp.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/dhcp/dhcp.mk b/package/dhcp/dhcp.mk
index cbc95cb152..9628ffbe2a 100644
--- a/package/dhcp/dhcp.mk
+++ b/package/dhcp/dhcp.mk
@@ -62,6 +62,12 @@ else
 DHCP_BIND_EXTRA_CONFIG += --without-zlib
 endif
 
+ifeq ($(BR2_TOOLCHAIN_HAS_ATOMIC),y)
+DHCP_BIND_EXTRA_CONFIG += --enable-atomic
+else
+DHCP_BIND_EXTRA_CONFIG += --disable-atomic
+endif
+
 ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
 DHCP_CONF_ENV += LIBS=-latomic
 endif
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: fix build without atomic

[Yann E. MORIN]

Fabrice, All,

On 2022-05-26 00:02 +0200, Fabrice Fontaine spake thusly:
> Fix the following build failure without atomic raised since commit
> fde21979427ffeb4fe9c0068310be195f2dec5ec:
> 
> /nvmedata/autobuild/instance-25/output-1/host/lib/gcc/mipsel-buildroot-linux-uclibc/10.3.0/../../../../mipsel-buildroot-linux-uclibc/bin/ld: cannot find -latomic: No such file or directory
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/db6/db6923915e36bcdb2953a3cdd2b450fa10794631
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/dhcp/dhcp.mk | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/package/dhcp/dhcp.mk b/package/dhcp/dhcp.mk
> index cbc95cb152..9628ffbe2a 100644
> --- a/package/dhcp/dhcp.mk
> +++ b/package/dhcp/dhcp.mk
> @@ -62,6 +62,12 @@ else
>  DHCP_BIND_EXTRA_CONFIG += --without-zlib
>  endif
>  
> +ifeq ($(BR2_TOOLCHAIN_HAS_ATOMIC),y)
> +DHCP_BIND_EXTRA_CONFIG += --enable-atomic
> +else
> +DHCP_BIND_EXTRA_CONFIG += --disable-atomic
> +endif
> +
>  ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
>  DHCP_CONF_ENV += LIBS=-latomic

It feels very weird that we have the _HAS_LIBATOMIC and the _HAS_ATOMIC
conditional blocks completely independent...

Indeed, BR2_TOOLCHAIN_HAS_LIBATOMIC selects BR2_TOOLCHAIN_HAS_ATOMIC.
So, BR2_TOOLCHAIN_HAS_ATOMIC == y implies BR2_TOOLCHAIN_HAS_ATOMIC == y
too.

So, probably we would want tsoemthing like:

    ifeq ($(BR2_TOOLCHAIN_HAS_ATOMIC),y)
    DHCP_BIND_EXTRA_CONFIG += --enable-atomic
    ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
    DHCP_CONF_ENV += LIBS=-latomic
    endif
    else
    DHCP_BIND_EXTRA_CONFIG += --disable-atomic
    endif

Thoughts?

Regards,
Yann E. MORIN.

>  endif
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot