Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH/next] package/linux-firmware: install all RTL_RTW88 blobs
@ 2022-05-24 14:32 Arnout Vandecappelle (Essensium/Mind)
  2022-05-28 21:36 ` Yann E. MORIN
  0 siblings, 1 reply; 2+ messages in thread
From: Arnout Vandecappelle (Essensium/Mind) @ 2022-05-24 14:32 UTC (permalink / raw)
  To: buildroot

Rather than installing just the three blobs mentioned explicitly in the
.mk file, use a wildcard to install all blobs. At the time of this
writing, this matches the following:

-rw-r--r-- 1 arnout arnout  29K Mar  9 13:28 rtw8723d_fw.bin
-rw-r--r-- 1 arnout arnout 136K Mar  9 13:28 rtw8821c_fw.bin
-rw-r--r-- 1 arnout arnout 148K Mar  9 13:28 rtw8822b_fw.bin
-rw-r--r-- 1 arnout arnout 198K Mar  9 13:28 rtw8822c_fw.bin
-rw-r--r-- 1 arnout arnout 142K Mar  9 13:28 rtw8822c_wow_fw.bin

I.e. rtw8821c_fw.bin and rtw8822c_wow_fw.bin were missing.

Although including all blobs nearly doubles the size, it still totals to
just 660K which wouldn't warrant making more refined sub-options.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 package/linux-firmware/linux-firmware.mk | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/package/linux-firmware/linux-firmware.mk b/package/linux-firmware/linux-firmware.mk
index 0c725737d0..64d096df14 100644
--- a/package/linux-firmware/linux-firmware.mk
+++ b/package/linux-firmware/linux-firmware.mk
@@ -154,9 +154,7 @@ endif
 # rtw88
 ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_RTL_RTW88),y)
 LINUX_FIRMWARE_FILES += \
-	rtw88/rtw8723d_fw.bin \
-	rtw88/rtw8822b_fw.bin \
-	rtw88/rtw8822c_fw.bin
+	rtw88/rtw*.bin
 LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.rtlwifi_firmware.txt
 endif
 
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH/next] package/linux-firmware: install all RTL_RTW88 blobs
  2022-05-24 14:32 [Buildroot] [PATCH/next] package/linux-firmware: install all RTL_RTW88 blobs Arnout Vandecappelle (Essensium/Mind)
@ 2022-05-28 21:36 ` Yann E. MORIN
  0 siblings, 0 replies; 2+ messages in thread
From: Yann E. MORIN @ 2022-05-28 21:36 UTC (permalink / raw)
  To: Arnout Vandecappelle (Essensium/Mind); +Cc: buildroot

Arnout, All,

On 2022-05-24 16:32 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> Rather than installing just the three blobs mentioned explicitly in the
> .mk file, use a wildcard to install all blobs. At the time of this
> writing, this matches the following:
> 
> -rw-r--r-- 1 arnout arnout  29K Mar  9 13:28 rtw8723d_fw.bin
> -rw-r--r-- 1 arnout arnout 136K Mar  9 13:28 rtw8821c_fw.bin
> -rw-r--r-- 1 arnout arnout 148K Mar  9 13:28 rtw8822b_fw.bin
> -rw-r--r-- 1 arnout arnout 198K Mar  9 13:28 rtw8822c_fw.bin
> -rw-r--r-- 1 arnout arnout 142K Mar  9 13:28 rtw8822c_wow_fw.bin
> 
> I.e. rtw8821c_fw.bin and rtw8822c_wow_fw.bin were missing.
> 
> Although including all blobs nearly doubles the size, it still totals to
> just 660K which wouldn't warrant making more refined sub-options.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Applied to next, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/linux-firmware/linux-firmware.mk | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/package/linux-firmware/linux-firmware.mk b/package/linux-firmware/linux-firmware.mk
> index 0c725737d0..64d096df14 100644
> --- a/package/linux-firmware/linux-firmware.mk
> +++ b/package/linux-firmware/linux-firmware.mk
> @@ -154,9 +154,7 @@ endif
>  # rtw88
>  ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_RTL_RTW88),y)
>  LINUX_FIRMWARE_FILES += \
> -	rtw88/rtw8723d_fw.bin \
> -	rtw88/rtw8822b_fw.bin \
> -	rtw88/rtw8822c_fw.bin
> +	rtw88/rtw*.bin
>  LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.rtlwifi_firmware.txt
>  endif
>  
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-05-28 21:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-24 14:32 [Buildroot] [PATCH/next] package/linux-firmware: install all RTL_RTW88 blobs Arnout Vandecappelle (Essensium/Mind)
2022-05-28 21:36 ` Yann E. MORIN

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox