From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Julien Olivain <ju.o@free.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/ola: stageprofi and usbdmx needs gcc >= 4.9
Date: Sun, 29 May 2022 00:29:52 +0200 [thread overview]
Message-ID: <20220528222952.GQ301044@scaer> (raw)
In-Reply-To: <20220527205505.1749320-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2022-05-27 22:55 +0200, Fabrice Fontaine spake thusly:
> Fix the following build failure raised since re-introduction of the
> package in commit 16ff948444c3978d63f483344a3d92d994c64312:
>
> configure: error: compiler with C11 support is required to build libusb
>
> Fixes:
> - http://autobuild.buildroot.org/results/7b15e23392805f5109c136a5aa870ddf49f48814
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/ola/Config.in | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/package/ola/Config.in b/package/ola/Config.in
> index 399f7702fc..cfca09a936 100644
> --- a/package/ola/Config.in
> +++ b/package/ola/Config.in
> @@ -153,10 +153,14 @@ config BR2_PACKAGE_OLA_PLUGIN_SPI
>
> config BR2_PACKAGE_OLA_PLUGIN_STAGEPROFI
> bool "stageprofi"
> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb
It is my opinion that, when selecting a package from a package
sub-option, all thes dependencies of the selected package should be
propagated, even if the main package already depends on some of then.
It makes it easier to see that everything is accounted for; it also
makes it automatically correct when the main package is updated and
loses that dependency.
However, this is not a written rule, if is far from being systematically
enforced, and I am not even sure all maintainers agree...
Ergo, applied to master, thanks.
Regards,
Yann E. MORIN.
> select BR2_PACKAGE_LIBUSB
> help
> Build StageProfi plugin for OLA.
>
> +comment "stageprofi needs a toolchain w/ gcc >= 4.9"
> + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> +
> config BR2_PACKAGE_OLA_PLUGIN_UARTDMX
> bool "uartdmx"
> help
> @@ -164,10 +168,14 @@ config BR2_PACKAGE_OLA_PLUGIN_UARTDMX
>
> config BR2_PACKAGE_OLA_PLUGIN_USBDMX
> bool "usbdmx"
> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb
> select BR2_PACKAGE_LIBUSB
> help
> Build USB DMX plugin for OLA.
>
> +comment "usbdmx needs a toolchain w/ gcc >= 4.9"
> + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> +
> config BR2_PACKAGE_OLA_PLUGIN_USBPRO
> bool "usbpro"
> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb
> --
> 2.35.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-05-28 22:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 20:55 [Buildroot] [PATCH 1/1] package/ola: stageprofi and usbdmx needs gcc >= 4.9 Fabrice Fontaine
2022-05-28 22:29 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220528222952.GQ301044@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=ju.o@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox