[Buildroot] [PATCH 1/1] package/ola: stageprofi and usbdmx needs gcc >= 4.9

[Buildroot] [PATCH 1/1] package/ola: stageprofi and usbdmx needs gcc >= 4.9

[Fabrice Fontaine]

Fix the following build failure raised since re-introduction of the
package in commit 16ff948444c3978d63f483344a3d92d994c64312:

configure: error: compiler with C11 support is required to build libusb

Fixes:
 - http://autobuild.buildroot.org/results/7b15e23392805f5109c136a5aa870ddf49f48814

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/ola/Config.in | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/package/ola/Config.in b/package/ola/Config.in
index 399f7702fc..cfca09a936 100644
--- a/package/ola/Config.in
+++ b/package/ola/Config.in
@@ -153,10 +153,14 @@ config BR2_PACKAGE_OLA_PLUGIN_SPI
 
 config BR2_PACKAGE_OLA_PLUGIN_STAGEPROFI
 	bool "stageprofi"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb
 	select BR2_PACKAGE_LIBUSB
 	help
 	  Build StageProfi plugin for OLA.
 
+comment "stageprofi needs a toolchain w/ gcc >= 4.9"
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+
 config BR2_PACKAGE_OLA_PLUGIN_UARTDMX
 	bool "uartdmx"
 	help
@@ -164,10 +168,14 @@ config BR2_PACKAGE_OLA_PLUGIN_UARTDMX
 
 config BR2_PACKAGE_OLA_PLUGIN_USBDMX
 	bool "usbdmx"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb
 	select BR2_PACKAGE_LIBUSB
 	help
 	  Build USB DMX plugin for OLA.
 
+comment "usbdmx needs a toolchain w/ gcc >= 4.9"
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+
 config BR2_PACKAGE_OLA_PLUGIN_USBPRO
 	bool "usbpro"
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/ola: stageprofi and usbdmx needs gcc >= 4.9

[Yann E. MORIN]

Fabrice, All,

On 2022-05-27 22:55 +0200, Fabrice Fontaine spake thusly:
> Fix the following build failure raised since re-introduction of the
> package in commit 16ff948444c3978d63f483344a3d92d994c64312:
> 
> configure: error: compiler with C11 support is required to build libusb
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/7b15e23392805f5109c136a5aa870ddf49f48814
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/ola/Config.in | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/package/ola/Config.in b/package/ola/Config.in
> index 399f7702fc..cfca09a936 100644
> --- a/package/ola/Config.in
> +++ b/package/ola/Config.in
> @@ -153,10 +153,14 @@ config BR2_PACKAGE_OLA_PLUGIN_SPI
>  
>  config BR2_PACKAGE_OLA_PLUGIN_STAGEPROFI
>  	bool "stageprofi"
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb

It is my opinion that, when selecting a package from a package
sub-option, all thes dependencies of the selected package should be
propagated, even if the main package already depends on some of then.

It makes it easier to see that everything is accounted for; it also
makes it automatically correct when the main package is updated and
loses that dependency.

However, this is not a written rule, if is far from being systematically
enforced, and I am not even sure all maintainers agree...

Ergo, applied to master, thanks.

Regards,
Yann E. MORIN.

>  	select BR2_PACKAGE_LIBUSB
>  	help
>  	  Build StageProfi plugin for OLA.
>  
> +comment "stageprofi needs a toolchain w/ gcc >= 4.9"
> +	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> +
>  config BR2_PACKAGE_OLA_PLUGIN_UARTDMX
>  	bool "uartdmx"
>  	help
> @@ -164,10 +168,14 @@ config BR2_PACKAGE_OLA_PLUGIN_UARTDMX
>  
>  config BR2_PACKAGE_OLA_PLUGIN_USBDMX
>  	bool "usbdmx"
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb
>  	select BR2_PACKAGE_LIBUSB
>  	help
>  	  Build USB DMX plugin for OLA.
>  
> +comment "usbdmx needs a toolchain w/ gcc >= 4.9"
> +	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> +
>  config BR2_PACKAGE_OLA_PLUGIN_USBPRO
>  	bool "usbpro"
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot