From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Romain Naour <romain.naour@gmail.com>
Cc: "Yann E . MORIN" <yann.morin@orange.com>,
Sergio Prado <sergio.prado@e-labworks.com>,
Matthew Weber <matthew.weber@collins.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] support/testing: test_oci: update to _OCI_CMD option
Date: Sun, 29 May 2022 22:36:51 +0200 [thread overview]
Message-ID: <20220529203651.GD993669@scaer> (raw)
In-Reply-To: <20220529202017.822191-1-romain.naour@gmail.com>
Romain, All,
On 2022-05-29 22:20 +0200, Romain Naour spake thusly:
> BR2_TARGET_ROOTFS_OCI_ENTRYPOINT_ARGS option has been
> replaced by BR2_TARGET_ROOTFS_OCI_CMD in commit [1].
>
> Since BR2_TARGET_ROOTFS_OCI_ENTRYPOINT_ARGS contains
> only one item, we can safely replace by
> BR2_TARGET_ROOTFS_OCI_CMD in the defconfig fragment
> used by the test_oci test case.
>
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/2491321058
>
> [1] 08d65d81d88418b0cd7edd3bd2227faa58d022f0
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Yann E. MORIN <yann.morin@orange.com>
I'll be sure to pass the message to that guy, that he should be a bit
more careful when he moves options to legacy. ;-)
Applied to master, thanks.
Regards,
Yann E. MORIN.
> Cc: Sergio Prado <sergio.prado@e-labworks.com>
> Cc: Matthew Weber <matthew.weber@collins.com>
> ---
> support/testing/tests/fs/test_oci.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/support/testing/tests/fs/test_oci.py b/support/testing/tests/fs/test_oci.py
> index 347332f30d..0ecf58f626 100644
> --- a/support/testing/tests/fs/test_oci.py
> +++ b/support/testing/tests/fs/test_oci.py
> @@ -20,7 +20,7 @@ class TestOci(infra.basetest.BRTest):
> BR2_TARGET_ROOTFS_EXT2_SIZE="600M"
> BR2_TARGET_ROOTFS_OCI=y
> BR2_TARGET_ROOTFS_OCI_ENTRYPOINT="df"
> - BR2_TARGET_ROOTFS_OCI_ENTRYPOINT_ARGS="-h"
> + BR2_TARGET_ROOTFS_OCI_CMD="-h"
> BR2_TARGET_ROOTFS_OCI_ARCHIVE=y
> # BR2_TARGET_ROOTFS_TAR is not set
> """
> --
> 2.35.3
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-05-29 20:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-29 20:20 [Buildroot] [PATCH] support/testing: test_oci: update to _OCI_CMD option Romain Naour
2022-05-29 20:36 ` Yann E. MORIN [this message]
2022-06-06 10:44 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220529203651.GD993669@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=matthew.weber@collins.com \
--cc=romain.naour@gmail.com \
--cc=sergio.prado@e-labworks.com \
--cc=yann.morin@orange.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox