[Buildroot] [PATCH] support/testing: test_oci: update to _OCI_CMD option

[Buildroot] [PATCH] support/testing: test_oci: update to _OCI_CMD option

[Romain Naour]

BR2_TARGET_ROOTFS_OCI_ENTRYPOINT_ARGS option has been
replaced by BR2_TARGET_ROOTFS_OCI_CMD in commit [1].

Since BR2_TARGET_ROOTFS_OCI_ENTRYPOINT_ARGS contains
only one item, we can safely replace by
BR2_TARGET_ROOTFS_OCI_CMD in the defconfig fragment
used by the test_oci test case.

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/2491321058

[1] 08d65d81d88418b0cd7edd3bd2227faa58d022f0

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Yann E. MORIN <yann.morin@orange.com>
Cc: Sergio Prado <sergio.prado@e-labworks.com>
Cc: Matthew Weber <matthew.weber@collins.com>
---
 support/testing/tests/fs/test_oci.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/support/testing/tests/fs/test_oci.py b/support/testing/tests/fs/test_oci.py
index 347332f30d..0ecf58f626 100644
--- a/support/testing/tests/fs/test_oci.py
+++ b/support/testing/tests/fs/test_oci.py
@@ -20,7 +20,7 @@ class TestOci(infra.basetest.BRTest):
         BR2_TARGET_ROOTFS_EXT2_SIZE="600M"
         BR2_TARGET_ROOTFS_OCI=y
         BR2_TARGET_ROOTFS_OCI_ENTRYPOINT="df"
-        BR2_TARGET_ROOTFS_OCI_ENTRYPOINT_ARGS="-h"
+        BR2_TARGET_ROOTFS_OCI_CMD="-h"
         BR2_TARGET_ROOTFS_OCI_ARCHIVE=y
         # BR2_TARGET_ROOTFS_TAR is not set
         """
-- 
2.35.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] support/testing: test_oci: update to _OCI_CMD option

[Yann E. MORIN]

Romain, All,

On 2022-05-29 22:20 +0200, Romain Naour spake thusly:
> BR2_TARGET_ROOTFS_OCI_ENTRYPOINT_ARGS option has been
> replaced by BR2_TARGET_ROOTFS_OCI_CMD in commit [1].
> 
> Since BR2_TARGET_ROOTFS_OCI_ENTRYPOINT_ARGS contains
> only one item, we can safely replace by
> BR2_TARGET_ROOTFS_OCI_CMD in the defconfig fragment
> used by the test_oci test case.
> 
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/2491321058
> 
> [1] 08d65d81d88418b0cd7edd3bd2227faa58d022f0
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Yann E. MORIN <yann.morin@orange.com>

I'll be sure to pass the message to that guy, that he should be a bit
more careful when he moves options to legacy. ;-)

Applied to master, thanks.

Regards,
Yann E. MORIN.

> Cc: Sergio Prado <sergio.prado@e-labworks.com>
> Cc: Matthew Weber <matthew.weber@collins.com>
> ---
>  support/testing/tests/fs/test_oci.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/support/testing/tests/fs/test_oci.py b/support/testing/tests/fs/test_oci.py
> index 347332f30d..0ecf58f626 100644
> --- a/support/testing/tests/fs/test_oci.py
> +++ b/support/testing/tests/fs/test_oci.py
> @@ -20,7 +20,7 @@ class TestOci(infra.basetest.BRTest):
>          BR2_TARGET_ROOTFS_EXT2_SIZE="600M"
>          BR2_TARGET_ROOTFS_OCI=y
>          BR2_TARGET_ROOTFS_OCI_ENTRYPOINT="df"
> -        BR2_TARGET_ROOTFS_OCI_ENTRYPOINT_ARGS="-h"
> +        BR2_TARGET_ROOTFS_OCI_CMD="-h"
>          BR2_TARGET_ROOTFS_OCI_ARCHIVE=y
>          # BR2_TARGET_ROOTFS_TAR is not set
>          """
> -- 
> 2.35.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] support/testing: test_oci: update to _OCI_CMD option

[Peter Korsgaard]

>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:

 > BR2_TARGET_ROOTFS_OCI_ENTRYPOINT_ARGS option has been
 > replaced by BR2_TARGET_ROOTFS_OCI_CMD in commit [1].

 > Since BR2_TARGET_ROOTFS_OCI_ENTRYPOINT_ARGS contains
 > only one item, we can safely replace by
 > BR2_TARGET_ROOTFS_OCI_CMD in the defconfig fragment
 > used by the test_oci test case.

 > Fixes:
 > https://gitlab.com/buildroot.org/buildroot/-/jobs/2491321058

 > [1] 08d65d81d88418b0cd7edd3bd2227faa58d022f0

 > Signed-off-by: Romain Naour <romain.naour@gmail.com>
 > Cc: Yann E. MORIN <yann.morin@orange.com>
 > Cc: Sergio Prado <sergio.prado@e-labworks.com>
 > Cc: Matthew Weber <matthew.weber@collins.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot