[Buildroot] [PATCH 1/1] package/libks: disable tests

[Buildroot] [PATCH 1/1] package/libks: disable tests

[Fabrice Fontaine]

Disables tests to avoid the following build failure with
BR2_SHARED_STATIC_LIBS:

[ 42%] Linking C executable teststring
../libks.so.1: undefined reference to `dlsym'

Fixes:
 - http://autobuild.buildroot.org/results/e61a683928795402375165adf686687f3305e0c2

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 ...-CMakeLists.txt-honour-BUILD_TESTING.patch | 41 +++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100644 package/libks/0001-CMakeLists.txt-honour-BUILD_TESTING.patch

diff --git a/package/libks/0001-CMakeLists.txt-honour-BUILD_TESTING.patch b/package/libks/0001-CMakeLists.txt-honour-BUILD_TESTING.patch
new file mode 100644
index 0000000000..fbe6cabd86
--- /dev/null
+++ b/package/libks/0001-CMakeLists.txt-honour-BUILD_TESTING.patch
@@ -0,0 +1,41 @@
+From c850e04898a9498d447b43bf346365646ff1b19c Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Date: Fri, 13 May 2022 23:12:31 +0200
+Subject: [PATCH] CMakeLists.txt:  honour BUILD_TESTING
+
+Allow the user to disable tests through the standard BUILD_TESTING
+option: https://cmake.org/cmake/help/latest/module/CTest.html
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+[Upstream status: https://github.com/signalwire/libks/pull/125]
+---
+ CMakeLists.txt | 7 +++++--
+ 1 file changed, 5 insertions(+), 2 deletions(-)
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 5bbac31..37e6bcd 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -1,5 +1,6 @@
+ cmake_minimum_required(VERSION 3.7.2)
+ 
++option(BUILD_TESTING "Build tests" ON)
+ option(KS_DEBUG_MUTEX "Debug mutexes, only works on linux for now" OFF)
+ option(KS_DEBUG_SPINLOCK "Debug spinlocks" OFF)
+ option(KS_DEBUG_POOL "Track pool allocations and provide hooks for rendering them" OFF)
+@@ -609,8 +610,10 @@ endif()
+ #cotire(ks)
+ 
+ # Add tests
+-enable_testing()
+-add_subdirectory(tests)
++if (BUILD_TESTING)
++	enable_testing()
++	add_subdirectory(tests)
++endif()
+ 
+ if (WITH_KS_TEST)
+ 	enable_testing()
+-- 
+2.35.1
+
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libks: disable tests

[Thomas Petazzoni via buildroot]

On Tue, 31 May 2022 21:26:57 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Disables tests to avoid the following build failure with
> BR2_SHARED_STATIC_LIBS:
> 
> [ 42%] Linking C executable teststring
> ../libks.so.1: undefined reference to `dlsym'
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/e61a683928795402375165adf686687f3305e0c2
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  ...-CMakeLists.txt-honour-BUILD_TESTING.patch | 41 +++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 package/libks/0001-CMakeLists.txt-honour-BUILD_TESTING.patch

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot