Re: [Buildroot] [PATCH 4/4] package/rtl8723ds: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Fri, 27 May 2022 12:33:35 +0200
Angelo Compagnucci <angelo@amarulasolutions.com> wrote:

> This package adds a driver for Realtek RTL8723DS wifi chip.
> 
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
> ---
>  package/Config.in              |  1 +
>  package/rtl8723ds/Config.in    | 10 ++++++++++
>  package/rtl8723ds/rtl8723ds.mk | 23 +++++++++++++++++++++++
>  3 files changed, 34 insertions(+)

This was missing an entry in the DEVELOPERS file.

> diff --git a/package/Config.in b/package/Config.in
> index 8892134133..52671dbf89 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -565,6 +565,7 @@ endmenu
>  	source "package/rtl8189es/Config.in"
>  	source "package/rtl8189fs/Config.in"
>  	source "package/rtl8723bs/Config.in"
> +	source "package/rtl8723ds/Config.in"
>  	source "package/rtl8723bu/Config.in"

Alphabetic ordering was not correct here (reported by check-package),
so I fixed that up.


> +RTL8723DS_VERSION = 76146e85847beb2427b1d4958fa275822f2b04ab
> +RTL8723DS_SITE = $(call github,lwfinger,rtl8723ds,$(RTL8723DS_VERSION))
> +RTL8723DS_LICENSE = GPL-2.0, proprietary (*.bin firmware blobs)

There are no firmware files in this Git repository, so it seems like
"proprietary (*.bin firmware blobs)" was copy/pasted from other rtlxxxx
packages. I dropped that, and kept only GPL-2.0.

Of course, if you have some evidence showing that there are some
proprietary firmware files in this package, let me know and we'll fix
things back.

Applied to next with those changes. Thanks!

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot