Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Angelo Compagnucci <angelo@amarulasolutions.com>
Cc: jagan@amarulasolutions.com, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/4] package/wpa_supplicant: fixing "Invalid configuration line"
Date: Tue, 7 Jun 2022 13:48:03 +0200	[thread overview]
Message-ID: <20220607134803.630edcd7@windsurf> (raw)
In-Reply-To: <CA+_SqVZiyKDxz=+0391_0jbdnE+Qt06NnT=i=n1e0zZiPN0G6g@mail.gmail.com>

On Tue, 7 Jun 2022 12:21:22 +0200
Angelo Compagnucci <angelo@amarulasolutions.com> wrote:

> The problem here is that wpa_supplicant.conf file will always be provided
> in a user overlay, because to connect to a wifi a proper `network=`
> configuration settings must be provided.

Then why do we provide an example configuration file? :-)

> Would we really like to mess with a user overlay provided configuration
> file? I think that a user must ensure the configuration file is in good
> shape for the service to work.

If the wpa_supplicant.conf provided by Buildroot is overridden by a
file in the rootfs overlay, then whatever we do in
WPA_SUPPLICANT_INSTALL_TARGET_HOOKS will have no effect, the file in
the rootfs overlay will win. So we are not "messing up" with the file
provided by the user.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-06-07 11:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-27 10:33 [Buildroot] [PATCH 0/4] Better wifi handling Angelo Compagnucci
2022-05-27 10:33 ` [Buildroot] [PATCH 1/4] package/wpa_supplicant: fixing "Invalid configuration line" Angelo Compagnucci
2022-06-01 19:21   ` Thomas Petazzoni via buildroot
2022-06-01 21:55     ` Angelo Compagnucci
2022-06-06 12:42       ` Arnout Vandecappelle
2022-06-07 10:21         ` Angelo Compagnucci
2022-06-07 11:48           ` Thomas Petazzoni via buildroot [this message]
2022-06-07 12:16             ` Angelo Compagnucci
2022-06-07 13:12               ` Thomas Petazzoni via buildroot
2022-06-07 13:22                 ` Angelo Compagnucci
2022-05-27 10:33 ` [Buildroot] [PATCH 2/4] package/wpa_supplicant: adding ifupdown support Angelo Compagnucci
2022-06-01 19:25   ` Thomas Petazzoni via buildroot
2022-06-01 22:06     ` Angelo Compagnucci
2022-06-06 15:09   ` Nicolas Cavallari
2022-06-07 15:00     ` Angelo Compagnucci
2022-05-27 10:33 ` [Buildroot] [PATCH 3/4] package/busybox: make udhcp discover faster Angelo Compagnucci
2022-06-01 19:26   ` Thomas Petazzoni via buildroot
2022-05-27 10:33 ` [Buildroot] [PATCH 4/4] package/rtl8723ds: new package Angelo Compagnucci
2022-06-01 19:55   ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220607134803.630edcd7@windsurf \
    --to=buildroot@buildroot.org \
    --cc=angelo@amarulasolutions.com \
    --cc=jagan@amarulasolutions.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox