* [Buildroot] [PATCH 1/1] package/wilc-driver: fix kconfig syntax
@ 2022-07-15 21:10 Kris Bahnsen via buildroot
2022-07-16 22:08 ` Yann E. MORIN
2022-08-04 15:05 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Kris Bahnsen via buildroot @ 2022-07-15 21:10 UTC (permalink / raw)
To: buildroot; +Cc: James Hilliard, Mark Featherston, Kris Bahnsen
Sub-options SPI and SDIO weren't rendering as nested options for
wilc-driver, instead showing on the same indent level. Move the
comment and depends on to bottom of file to correct this.
Fixes: 1a47c42b33 ("package/wilc-driver: add missing BR2_LINUX_KERNEL dependency")
Signed-off-by: Kris Bahnsen <kris@embeddedTS.com>
---
package/wilc-driver/Config.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/wilc-driver/Config.in b/package/wilc-driver/Config.in
index 24a7b05b17..7ed062bb66 100644
--- a/package/wilc-driver/Config.in
+++ b/package/wilc-driver/Config.in
@@ -17,9 +17,6 @@ config BR2_PACKAGE_WILC_DRIVER
https://github.com/embeddedTS/wilc3000-external-module
-comment "wilc kernel module needs a Linux kernel to be built"
- depends on !BR2_LINUX_KERNEL
-
if BR2_PACKAGE_WILC_DRIVER
config BR2_PACKAGE_WILC_DRIVER_SPI
@@ -60,3 +57,6 @@ config BR2_PACKAGE_WILC_DRIVER_SDIO_OOB
time division interrupt.
endif
endif
+
+comment "wilc kernel module needs a Linux kernel to be built"
+ depends on !BR2_LINUX_KERNEL
--
2.11.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/wilc-driver: fix kconfig syntax
2022-07-15 21:10 [Buildroot] [PATCH 1/1] package/wilc-driver: fix kconfig syntax Kris Bahnsen via buildroot
@ 2022-07-16 22:08 ` Yann E. MORIN
2022-08-04 15:05 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2022-07-16 22:08 UTC (permalink / raw)
To: Kris Bahnsen; +Cc: James Hilliard, Mark Featherston, buildroot
Kris, All,
On 2022-07-15 14:10 -0700, Kris Bahnsen via buildroot spake thusly:
> Sub-options SPI and SDIO weren't rendering as nested options for
> wilc-driver, instead showing on the same indent level. Move the
> comment and depends on to bottom of file to correct this.
>
> Fixes: 1a47c42b33 ("package/wilc-driver: add missing BR2_LINUX_KERNEL dependency")
> Signed-off-by: Kris Bahnsen <kris@embeddedTS.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/wilc-driver/Config.in | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/wilc-driver/Config.in b/package/wilc-driver/Config.in
> index 24a7b05b17..7ed062bb66 100644
> --- a/package/wilc-driver/Config.in
> +++ b/package/wilc-driver/Config.in
> @@ -17,9 +17,6 @@ config BR2_PACKAGE_WILC_DRIVER
>
> https://github.com/embeddedTS/wilc3000-external-module
>
> -comment "wilc kernel module needs a Linux kernel to be built"
> - depends on !BR2_LINUX_KERNEL
> -
> if BR2_PACKAGE_WILC_DRIVER
>
> config BR2_PACKAGE_WILC_DRIVER_SPI
> @@ -60,3 +57,6 @@ config BR2_PACKAGE_WILC_DRIVER_SDIO_OOB
> time division interrupt.
> endif
> endif
> +
> +comment "wilc kernel module needs a Linux kernel to be built"
> + depends on !BR2_LINUX_KERNEL
> --
> 2.11.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/wilc-driver: fix kconfig syntax
2022-07-15 21:10 [Buildroot] [PATCH 1/1] package/wilc-driver: fix kconfig syntax Kris Bahnsen via buildroot
2022-07-16 22:08 ` Yann E. MORIN
@ 2022-08-04 15:05 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2022-08-04 15:05 UTC (permalink / raw)
To: Kris Bahnsen via buildroot; +Cc: James Hilliard, Mark Featherston, Kris Bahnsen
>>>>> "Kris" == Kris Bahnsen via buildroot <buildroot@buildroot.org> writes:
> Sub-options SPI and SDIO weren't rendering as nested options for
> wilc-driver, instead showing on the same indent level. Move the
> comment and depends on to bottom of file to correct this.
> Fixes: 1a47c42b33 ("package/wilc-driver: add missing BR2_LINUX_KERNEL dependency")
> Signed-off-by: Kris Bahnsen <kris@embeddedTS.com>
Committed to 2022.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-04 15:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-15 21:10 [Buildroot] [PATCH 1/1] package/wilc-driver: fix kconfig syntax Kris Bahnsen via buildroot
2022-07-16 22:08 ` Yann E. MORIN
2022-08-04 15:05 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox