[Buildroot] [PATCH] package/uclibc: Prevent config with unsupported RISC-V float ABI

[Buildroot] [PATCH] package/uclibc: Prevent config with unsupported RISC-V float ABI

[Ben Hutchings]

uClibc currently supports RISC-V with a soft-float or 64-bit
hard-float ABI, but not 32-bit hard-float.  Selecting
BR2_RISCV_ABI_LP64F results in a build failure:

./include/sys/asm.h:42:4: error: #error unsupported FLEN
   42 | #  error unsupported FLEN
      |    ^~~~~

Change the conditions for BR2_PACKAGE_UCLIBC_ARCH_SUPPORTS
accordingly.

Signed-off-by: Ben Hutchings <ben.hutchings@mind.be>
---
 package/uclibc/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/uclibc/Config.in b/package/uclibc/Config.in
index 754c3ea014..221aa18a80 100644
--- a/package/uclibc/Config.in
+++ b/package/uclibc/Config.in
@@ -15,7 +15,7 @@ config BR2_PACKAGE_UCLIBC_ARCH_SUPPORTS
 	default y if BR2_mips64el
 	default y if BR2_or1k
 	default y if BR2_powerpc
-	default y if BR2_RISCV_64
+	default y if BR2_RISCV_64 && !BR2_RISCV_ABI_LP64F
 	default y if BR2_sh4
 	default y if BR2_sh4eb
 	default y if BR2_sparc
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/uclibc: Prevent config with unsupported RISC-V float ABI

[Thomas Petazzoni via buildroot]

On Tue, 14 Jun 2022 19:10:15 +0200
Ben Hutchings <ben.hutchings@mind.be> wrote:

> uClibc currently supports RISC-V with a soft-float or 64-bit
> hard-float ABI, but not 32-bit hard-float.  Selecting
> BR2_RISCV_ABI_LP64F results in a build failure:
> 
> ./include/sys/asm.h:42:4: error: #error unsupported FLEN
>    42 | #  error unsupported FLEN
>       |    ^~~~~
> 
> Change the conditions for BR2_PACKAGE_UCLIBC_ARCH_SUPPORTS
> accordingly.
> 
> Signed-off-by: Ben Hutchings <ben.hutchings@mind.be>
> ---
>  package/uclibc/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks a lot for this patch! I have changed the !LP64F to a LP64 ||
LP64D, and added a reference to a build failure in our autobuilders.
Patch committed with those changes, many thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/uclibc: Prevent config with unsupported RISC-V float ABI

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:

 > On Tue, 14 Jun 2022 19:10:15 +0200
 > Ben Hutchings <ben.hutchings@mind.be> wrote:

 >> uClibc currently supports RISC-V with a soft-float or 64-bit
 >> hard-float ABI, but not 32-bit hard-float.  Selecting
 >> BR2_RISCV_ABI_LP64F results in a build failure:
 >> 
 >> ./include/sys/asm.h:42:4: error: #error unsupported FLEN
 >> 42 | #  error unsupported FLEN
 >> |    ^~~~~
 >> 
 >> Change the conditions for BR2_PACKAGE_UCLIBC_ARCH_SUPPORTS
 >> accordingly.
 >> 
 >> Signed-off-by: Ben Hutchings <ben.hutchings@mind.be>
 >> ---
 >> package/uclibc/Config.in | 2 +-
 >> 1 file changed, 1 insertion(+), 1 deletion(-)

 > Thanks a lot for this patch! I have changed the !LP64F to a LP64 ||
 > LP64D, and added a reference to a build failure in our autobuilders.
 > Patch committed with those changes, many thanks!

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot