Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/libvpx: vp8 encoder needs c++
@ 2022-07-09  7:07 Bernd Kuhls
  2022-07-20 11:44 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 2+ messages in thread
From: Bernd Kuhls @ 2022-07-09  7:07 UTC (permalink / raw)
  To: buildroot; +Cc: Spenser Gilliland

Encoding rate control interface for v8 is implemented in c++:
https://github.com/webmproject/libvpx/commit/65a1751e5b98bf7f1d21bcbfdef352af34fb205d
and was added to libvpx in v1.12.0 which was added to buildroot with
https://git.busybox.net/buildroot/commit/?id=e4ff284ba88ea0cb41c190165cb42a174c5faa23

Disable vp8 encoding when toolchain lacks c++.

Fixes:
http://autobuild.buildroot.net/results/a3524b954e53002973b423ce23b4c43ff5281ab5/

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/libvpx/libvpx.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/libvpx/libvpx.mk b/package/libvpx/libvpx.mk
index 1845f2bc5e..c8a22b9ab2 100644
--- a/package/libvpx/libvpx.mk
+++ b/package/libvpx/libvpx.mk
@@ -21,11 +21,11 @@ LIBVPX_CONF_OPTS = \
 	--disable-docs \
 	--disable-unit-tests
 
-# vp9/ratectrl_rtc.cc
+# vp8/ratectrl_rtc.cc vp9/ratectrl_rtc.cc
 ifeq ($(BR2_INSTALL_LIBSTDCPP),y)
-LIBVPX_CONF_OPTS += --enable-vp9-encoder
+LIBVPX_CONF_OPTS += --enable-vp8-encoder --enable-vp9-encoder
 else
-LIBVPX_CONF_OPTS += --disable-vp9-encoder
+LIBVPX_CONF_OPTS += --disable-vp8-encoder --disable-vp9-encoder
 endif
 
 # This is not a true autotools package.  It is based on the ffmpeg build system
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/libvpx: vp8 encoder needs c++
  2022-07-09  7:07 [Buildroot] [PATCH 1/1] package/libvpx: vp8 encoder needs c++ Bernd Kuhls
@ 2022-07-20 11:44 ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-07-20 11:44 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: Spenser Gilliland, buildroot

On Sat,  9 Jul 2022 09:07:08 +0200
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:

> Encoding rate control interface for v8 is implemented in c++:
> https://github.com/webmproject/libvpx/commit/65a1751e5b98bf7f1d21bcbfdef352af34fb205d
> and was added to libvpx in v1.12.0 which was added to buildroot with
> https://git.busybox.net/buildroot/commit/?id=e4ff284ba88ea0cb41c190165cb42a174c5faa23
> 
> Disable vp8 encoding when toolchain lacks c++.
> 
> Fixes:
> http://autobuild.buildroot.net/results/a3524b954e53002973b423ce23b4c43ff5281ab5/
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/libvpx/libvpx.mk | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-07-20 11:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-09  7:07 [Buildroot] [PATCH 1/1] package/libvpx: vp8 encoder needs c++ Bernd Kuhls
2022-07-20 11:44 ` Thomas Petazzoni via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox