* [Buildroot] [PATCH 1/1] package/{webkitgtk, wpewebkit}: select subenc for multimedia
@ 2022-06-27 7:33 James Hilliard
2022-07-01 11:33 ` Adrian Perez de Castro
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: James Hilliard @ 2022-06-27 7:33 UTC (permalink / raw)
To: buildroot; +Cc: Adrian Perez de Castro, James Hilliard
When using webkit with multimedia support the subenc element may
be needed, as such we should select the subenc plugin.
Fixes runtime warning:
isGStreamerPluginAvailable: Plugin subenc not found. Please check your GStreamer installation
WebKit wasn't able to find a WebVTT encoder. Subtitles handling will be degraded unless gst-plugins-bad is installed.
See:
https://github.com/WebKit/WebKit/blob/72b59ad50e079037073722bbdf469c0952e399fa/Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp#L221
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
package/webkitgtk/Config.in | 1 +
package/wpewebkit/Config.in | 1 +
2 files changed, 2 insertions(+)
diff --git a/package/webkitgtk/Config.in b/package/webkitgtk/Config.in
index 2575108363..2219aa353e 100644
--- a/package/webkitgtk/Config.in
+++ b/package/webkitgtk/Config.in
@@ -97,6 +97,7 @@ config BR2_PACKAGE_WEBKITGTK_MULTIMEDIA
select BR2_PACKAGE_GST1_PLUGINS_BAD
select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_DEBUGUTILS
select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MPEGTSDEMUX
+ select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SUBENC
select BR2_PACKAGE_GST1_PLUGINS_BASE
select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA
select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_APP
diff --git a/package/wpewebkit/Config.in b/package/wpewebkit/Config.in
index f50e0da21c..fac7672939 100644
--- a/package/wpewebkit/Config.in
+++ b/package/wpewebkit/Config.in
@@ -90,6 +90,7 @@ config BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA
select BR2_PACKAGE_GST1_PLUGINS_BAD
select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_DEBUGUTILS
select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MPEGTSDEMUX
+ select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SUBENC
select BR2_PACKAGE_GST1_PLUGINS_BASE
select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA
select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_APP
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/{webkitgtk, wpewebkit}: select subenc for multimedia
2022-06-27 7:33 [Buildroot] [PATCH 1/1] package/{webkitgtk, wpewebkit}: select subenc for multimedia James Hilliard
@ 2022-07-01 11:33 ` Adrian Perez de Castro
2022-07-20 21:23 ` Thomas Petazzoni via buildroot
2022-08-11 17:31 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Adrian Perez de Castro @ 2022-07-01 11:33 UTC (permalink / raw)
To: James Hilliard; +Cc: James Hilliard, buildroot
[-- Attachment #1.1: Type: text/plain, Size: 2254 bytes --]
On Mon, 27 Jun 2022 01:33:06 -0600 James Hilliard <james.hilliard1@gmail.com> wrote:
> When using webkit with multimedia support the subenc element may
> be needed, as such we should select the subenc plugin.
>
> Fixes runtime warning:
> isGStreamerPluginAvailable: Plugin subenc not found. Please check your GStreamer installation
> WebKit wasn't able to find a WebVTT encoder. Subtitles handling will be degraded unless gst-plugins-bad is installed.
>
> See:
> https://github.com/WebKit/WebKit/blob/72b59ad50e079037073722bbdf469c0952e399fa/Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp#L221
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Acked-by: Adrian Perez de Castro <aperez@igalia.com>
> ---
> package/webkitgtk/Config.in | 1 +
> package/wpewebkit/Config.in | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/package/webkitgtk/Config.in b/package/webkitgtk/Config.in
> index 2575108363..2219aa353e 100644
> --- a/package/webkitgtk/Config.in
> +++ b/package/webkitgtk/Config.in
> @@ -97,6 +97,7 @@ config BR2_PACKAGE_WEBKITGTK_MULTIMEDIA
> select BR2_PACKAGE_GST1_PLUGINS_BAD
> select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_DEBUGUTILS
> select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MPEGTSDEMUX
> + select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SUBENC
> select BR2_PACKAGE_GST1_PLUGINS_BASE
> select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA
> select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_APP
> diff --git a/package/wpewebkit/Config.in b/package/wpewebkit/Config.in
> index f50e0da21c..fac7672939 100644
> --- a/package/wpewebkit/Config.in
> +++ b/package/wpewebkit/Config.in
> @@ -90,6 +90,7 @@ config BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA
> select BR2_PACKAGE_GST1_PLUGINS_BAD
> select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_DEBUGUTILS
> select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MPEGTSDEMUX
> + select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SUBENC
> select BR2_PACKAGE_GST1_PLUGINS_BASE
> select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA
> select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_APP
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
>
Cheers,
—Adrián
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/{webkitgtk, wpewebkit}: select subenc for multimedia
2022-06-27 7:33 [Buildroot] [PATCH 1/1] package/{webkitgtk, wpewebkit}: select subenc for multimedia James Hilliard
2022-07-01 11:33 ` Adrian Perez de Castro
@ 2022-07-20 21:23 ` Thomas Petazzoni via buildroot
2022-08-11 17:31 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-07-20 21:23 UTC (permalink / raw)
To: James Hilliard; +Cc: Adrian Perez de Castro, buildroot
On Mon, 27 Jun 2022 01:33:06 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> When using webkit with multimedia support the subenc element may
> be needed, as such we should select the subenc plugin.
>
> Fixes runtime warning:
> isGStreamerPluginAvailable: Plugin subenc not found. Please check your GStreamer installation
> WebKit wasn't able to find a WebVTT encoder. Subtitles handling will be degraded unless gst-plugins-bad is installed.
>
> See:
> https://github.com/WebKit/WebKit/blob/72b59ad50e079037073722bbdf469c0952e399fa/Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp#L221
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/webkitgtk/Config.in | 1 +
> package/wpewebkit/Config.in | 1 +
> 2 files changed, 2 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/{webkitgtk, wpewebkit}: select subenc for multimedia
2022-06-27 7:33 [Buildroot] [PATCH 1/1] package/{webkitgtk, wpewebkit}: select subenc for multimedia James Hilliard
2022-07-01 11:33 ` Adrian Perez de Castro
2022-07-20 21:23 ` Thomas Petazzoni via buildroot
@ 2022-08-11 17:31 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2022-08-11 17:31 UTC (permalink / raw)
To: James Hilliard; +Cc: Adrian Perez de Castro, buildroot
>>>>> "James" == James Hilliard <james.hilliard1@gmail.com> writes:
> When using webkit with multimedia support the subenc element may
> be needed, as such we should select the subenc plugin.
> Fixes runtime warning:
> isGStreamerPluginAvailable: Plugin subenc not found. Please check your GStreamer installation
> WebKit wasn't able to find a WebVTT encoder. Subtitles handling will
> be degraded unless gst-plugins-bad is installed.
> See:
> https://github.com/WebKit/WebKit/blob/72b59ad50e079037073722bbdf469c0952e399fa/Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp#L221
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Committed to 2022.05.x and 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-11 17:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-27 7:33 [Buildroot] [PATCH 1/1] package/{webkitgtk, wpewebkit}: select subenc for multimedia James Hilliard
2022-07-01 11:33 ` Adrian Perez de Castro
2022-07-20 21:23 ` Thomas Petazzoni via buildroot
2022-08-11 17:31 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox