Re: [Buildroot] [PATCH 1/1] package/ntpsec: depends on python3

Re: [Buildroot] [PATCH 1/1] package/ntpsec: depends on python3

[Thomas Petazzoni via buildroot]

On Sat, 23 Jul 2022 23:28:07 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Depends on python3 instead of selecting it to avoid the following build
> failure raised since the addition of the package in commit
> 27b8d0ba8c4004819e092fb81c0f64f284b3aa4a:
> 
> Makefile:576: *** libffi is in the dependency chain of python3 that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in.  Stop.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/2893c213f49d37a0878dcf14ec68ef991471c70f
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Gaah, my bad, I forgot to propagate the dependencies of python3.

The correct fix is:

        depends on BR2_USE_MMU # python3
        depends on BR2_TOOLCHAIN_HAS_THREADS # python3
        depends on !BR2_STATIC_LIBS # python3
	select BR2_PACKAGE_PYTHON3

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 1/1] package/ntpsec: depends on python3

[Fabrice Fontaine]

Depends on python3 instead of selecting it to avoid the following build
failure raised since the addition of the package in commit
27b8d0ba8c4004819e092fb81c0f64f284b3aa4a:

Makefile:576: *** libffi is in the dependency chain of python3 that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in.  Stop.

Fixes:
 - http://autobuild.buildroot.org/results/2893c213f49d37a0878dcf14ec68ef991471c70f

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/ntpsec/Config.in | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/package/ntpsec/Config.in b/package/ntpsec/Config.in
index 1e88046420..febfc31a76 100644
--- a/package/ntpsec/Config.in
+++ b/package/ntpsec/Config.in
@@ -1,8 +1,8 @@
 config BR2_PACKAGE_NTPSEC
 	bool "ntpsec"
+	depends on BR2_PACKAGE_PYTHON3
 	select BR2_PACKAGE_LIBCAP
 	select BR2_PACKAGE_OPENSSL
-	select BR2_PACKAGE_PYTHON3
 	help
 	  NTPsec project - a secure, hardened, and improved
 	  implementation of Network Time Protocol derived
@@ -26,3 +26,6 @@ config BR2_PACKAGE_NTPSEC_NTS
 	  Enable Network Time Security (NTS) support.
 
 endif
+
+comment "ntpsec depends on python3"
+	depends on !BR2_PACKAGE_PYTHON3
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot