Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Baruch Siach <baruch@tkos.co.il>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [git commit] package/rustc: fix target names for i586 and i686
Date: Sun, 24 Jul 2022 12:33:42 +0200	[thread overview]
Message-ID: <20220724103342.GS2641@scaer> (raw)
In-Reply-To: <87y1wihl1f.fsf@tarshish>

Baruch, All,

On 2022-07-24 13:15 +0300, Baruch Siach spake thusly:
> On Sun, Jul 24 2022, Yann E. MORIN wrote:
> > commit: https://git.buildroot.net/buildroot/commit/?id=b4e706a6e320d5035cf05e8af3c6d9b8bb74fc33
> > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> >
> > Commit d69d40c029dc (package/rustc: add support for Tier 1 and Tier 2
> > platforms) misspelled the config options for i586 and i686.
> >
> > They are BR2_x86_i586 and BR2_x86_i686, not BR2_i586 or BR2_i686.
> >
> > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> > Cc: Baruch Siach <baruch@tkos.co.il>
> > Reviewed-by: Romain Naour <romain.naour@smile.fr>
> >
> > ---
> > Changes v1 -> v2:
> >   - in commit log: s/BR2_i386_/BR2_x86_/g  (Baruch)
> Did you mean to push this commit to master with the changelog?

No, indeed.

I wrote the changelogs before we discussed IRL and Arnout said I should
just pushed, so the changelogs sneaked in...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2022-07-24 10:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-24  9:30 [Buildroot] [git commit] package/rustc: fix target names for i586 and i686 Yann E. MORIN
2022-07-24 10:15 ` Baruch Siach via buildroot
2022-07-24 10:33   ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220724103342.GS2641@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=baruch@tkos.co.il \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox