From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [git commit] package/rustc: fix target names for i586 and i686
Date: Sun, 24 Jul 2022 13:15:59 +0300 [thread overview]
Message-ID: <87y1wihl1f.fsf@tarshish> (raw)
In-Reply-To: <20220724095505.6CAA485B23@busybox.osuosl.org>
Hi Yann,
On Sun, Jul 24 2022, Yann E. MORIN wrote:
> commit: https://git.buildroot.net/buildroot/commit/?id=b4e706a6e320d5035cf05e8af3c6d9b8bb74fc33
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> Commit d69d40c029dc (package/rustc: add support for Tier 1 and Tier 2
> platforms) misspelled the config options for i586 and i686.
>
> They are BR2_x86_i586 and BR2_x86_i686, not BR2_i586 or BR2_i686.
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Baruch Siach <baruch@tkos.co.il>
> Reviewed-by: Romain Naour <romain.naour@smile.fr>
>
> ---
> Changes v1 -> v2:
> - in commit log: s/BR2_i386_/BR2_x86_/g (Baruch)
Did you mean to push this commit to master with the changelog?
baruch
> ---
> package/rustc/Config.in.host | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/package/rustc/Config.in.host b/package/rustc/Config.in.host
> index 27c3a3cdeb..fec8726aee 100644
> --- a/package/rustc/Config.in.host
> +++ b/package/rustc/Config.in.host
> @@ -25,7 +25,7 @@ config BR2_PACKAGE_HOST_RUSTC_TARGET_TIER1_PLATFORMS
> # aarch64-unknown-linux-gnu
> default y if BR2_aarch64 && BR2_TOOLCHAIN_USES_GLIBC
> # i686-unknown-linux-gnu
> - default y if (BR2_i686 || BR2_x86_pentiumpro || BR2_X86_CPU_HAS_MMX) && BR2_TOOLCHAIN_USES_GLIBC
> + default y if (BR2_x86_i686 || BR2_x86_pentiumpro || BR2_X86_CPU_HAS_MMX) && BR2_TOOLCHAIN_USES_GLIBC
> # x86_64-unknown-linux-gnu
> default y if BR2_x86_64 && BR2_TOOLCHAIN_USES_GLIBC
>
> @@ -93,11 +93,11 @@ config BR2_PACKAGE_HOST_RUSTC_TARGET_TIER2_PLATFORMS
> # userspace
> default y if BR2_arm && BR2_ARM_CPU_ARMV8A && BR2_ARM_EABIHF && BR2_TOOLCHAIN_USES_MUSL
> # i586-unknown-linux-gnu
> - default y if BR2_i586 && BR2_TOOLCHAIN_USES_GLIBC
> + default y if BR2_x86_i586 && BR2_TOOLCHAIN_USES_GLIBC
> # i586-unknown-linux-musl
> - default y if BR2_i586 && BR2_TOOLCHAIN_USES_MUSL
> + default y if BR2_x86_i586 && BR2_TOOLCHAIN_USES_MUSL
> # i686-unknown-linux-musl
> - default y if (BR2_i686 || BR2_x86_pentiumpro || BR2_X86_CPU_HAS_MMX) && BR2_TOOLCHAIN_USES_MUSL
> + default y if (BR2_x86_i686 || BR2_x86_pentiumpro || BR2_X86_CPU_HAS_MMX) && BR2_TOOLCHAIN_USES_MUSL
> # mips-unknown-linux-musl
> default y if BR2_mips && BR2_TOOLCHAIN_USES_MUSL && !BR2_MIPS_CPU_MIPS32R6
> # mips64-unknown-linux-muslabi64
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-07-24 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-24 9:30 [Buildroot] [git commit] package/rustc: fix target names for i586 and i686 Yann E. MORIN
2022-07-24 10:15 ` Baruch Siach via buildroot [this message]
2022-07-24 10:33 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1wihl1f.fsf@tarshish \
--to=buildroot@buildroot.org \
--cc=baruch@tkos.co.il \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox