* [Buildroot] [git commit] package/rustc: fix target names for i586 and i686
@ 2022-07-24 9:30 Yann E. MORIN
2022-07-24 10:15 ` Baruch Siach via buildroot
0 siblings, 1 reply; 3+ messages in thread
From: Yann E. MORIN @ 2022-07-24 9:30 UTC (permalink / raw)
To: buildroot
commit: https://git.buildroot.net/buildroot/commit/?id=b4e706a6e320d5035cf05e8af3c6d9b8bb74fc33
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
Commit d69d40c029dc (package/rustc: add support for Tier 1 and Tier 2
platforms) misspelled the config options for i586 and i686.
They are BR2_x86_i586 and BR2_x86_i686, not BR2_i586 or BR2_i686.
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Baruch Siach <baruch@tkos.co.il>
Reviewed-by: Romain Naour <romain.naour@smile.fr>
---
Changes v1 -> v2:
- in commit log: s/BR2_i386_/BR2_x86_/g (Baruch)
---
package/rustc/Config.in.host | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/package/rustc/Config.in.host b/package/rustc/Config.in.host
index 27c3a3cdeb..fec8726aee 100644
--- a/package/rustc/Config.in.host
+++ b/package/rustc/Config.in.host
@@ -25,7 +25,7 @@ config BR2_PACKAGE_HOST_RUSTC_TARGET_TIER1_PLATFORMS
# aarch64-unknown-linux-gnu
default y if BR2_aarch64 && BR2_TOOLCHAIN_USES_GLIBC
# i686-unknown-linux-gnu
- default y if (BR2_i686 || BR2_x86_pentiumpro || BR2_X86_CPU_HAS_MMX) && BR2_TOOLCHAIN_USES_GLIBC
+ default y if (BR2_x86_i686 || BR2_x86_pentiumpro || BR2_X86_CPU_HAS_MMX) && BR2_TOOLCHAIN_USES_GLIBC
# x86_64-unknown-linux-gnu
default y if BR2_x86_64 && BR2_TOOLCHAIN_USES_GLIBC
@@ -93,11 +93,11 @@ config BR2_PACKAGE_HOST_RUSTC_TARGET_TIER2_PLATFORMS
# userspace
default y if BR2_arm && BR2_ARM_CPU_ARMV8A && BR2_ARM_EABIHF && BR2_TOOLCHAIN_USES_MUSL
# i586-unknown-linux-gnu
- default y if BR2_i586 && BR2_TOOLCHAIN_USES_GLIBC
+ default y if BR2_x86_i586 && BR2_TOOLCHAIN_USES_GLIBC
# i586-unknown-linux-musl
- default y if BR2_i586 && BR2_TOOLCHAIN_USES_MUSL
+ default y if BR2_x86_i586 && BR2_TOOLCHAIN_USES_MUSL
# i686-unknown-linux-musl
- default y if (BR2_i686 || BR2_x86_pentiumpro || BR2_X86_CPU_HAS_MMX) && BR2_TOOLCHAIN_USES_MUSL
+ default y if (BR2_x86_i686 || BR2_x86_pentiumpro || BR2_X86_CPU_HAS_MMX) && BR2_TOOLCHAIN_USES_MUSL
# mips-unknown-linux-musl
default y if BR2_mips && BR2_TOOLCHAIN_USES_MUSL && !BR2_MIPS_CPU_MIPS32R6
# mips64-unknown-linux-muslabi64
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [git commit] package/rustc: fix target names for i586 and i686
2022-07-24 9:30 [Buildroot] [git commit] package/rustc: fix target names for i586 and i686 Yann E. MORIN
@ 2022-07-24 10:15 ` Baruch Siach via buildroot
2022-07-24 10:33 ` Yann E. MORIN
0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach via buildroot @ 2022-07-24 10:15 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: buildroot
Hi Yann,
On Sun, Jul 24 2022, Yann E. MORIN wrote:
> commit: https://git.buildroot.net/buildroot/commit/?id=b4e706a6e320d5035cf05e8af3c6d9b8bb74fc33
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> Commit d69d40c029dc (package/rustc: add support for Tier 1 and Tier 2
> platforms) misspelled the config options for i586 and i686.
>
> They are BR2_x86_i586 and BR2_x86_i686, not BR2_i586 or BR2_i686.
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Baruch Siach <baruch@tkos.co.il>
> Reviewed-by: Romain Naour <romain.naour@smile.fr>
>
> ---
> Changes v1 -> v2:
> - in commit log: s/BR2_i386_/BR2_x86_/g (Baruch)
Did you mean to push this commit to master with the changelog?
baruch
> ---
> package/rustc/Config.in.host | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/package/rustc/Config.in.host b/package/rustc/Config.in.host
> index 27c3a3cdeb..fec8726aee 100644
> --- a/package/rustc/Config.in.host
> +++ b/package/rustc/Config.in.host
> @@ -25,7 +25,7 @@ config BR2_PACKAGE_HOST_RUSTC_TARGET_TIER1_PLATFORMS
> # aarch64-unknown-linux-gnu
> default y if BR2_aarch64 && BR2_TOOLCHAIN_USES_GLIBC
> # i686-unknown-linux-gnu
> - default y if (BR2_i686 || BR2_x86_pentiumpro || BR2_X86_CPU_HAS_MMX) && BR2_TOOLCHAIN_USES_GLIBC
> + default y if (BR2_x86_i686 || BR2_x86_pentiumpro || BR2_X86_CPU_HAS_MMX) && BR2_TOOLCHAIN_USES_GLIBC
> # x86_64-unknown-linux-gnu
> default y if BR2_x86_64 && BR2_TOOLCHAIN_USES_GLIBC
>
> @@ -93,11 +93,11 @@ config BR2_PACKAGE_HOST_RUSTC_TARGET_TIER2_PLATFORMS
> # userspace
> default y if BR2_arm && BR2_ARM_CPU_ARMV8A && BR2_ARM_EABIHF && BR2_TOOLCHAIN_USES_MUSL
> # i586-unknown-linux-gnu
> - default y if BR2_i586 && BR2_TOOLCHAIN_USES_GLIBC
> + default y if BR2_x86_i586 && BR2_TOOLCHAIN_USES_GLIBC
> # i586-unknown-linux-musl
> - default y if BR2_i586 && BR2_TOOLCHAIN_USES_MUSL
> + default y if BR2_x86_i586 && BR2_TOOLCHAIN_USES_MUSL
> # i686-unknown-linux-musl
> - default y if (BR2_i686 || BR2_x86_pentiumpro || BR2_X86_CPU_HAS_MMX) && BR2_TOOLCHAIN_USES_MUSL
> + default y if (BR2_x86_i686 || BR2_x86_pentiumpro || BR2_X86_CPU_HAS_MMX) && BR2_TOOLCHAIN_USES_MUSL
> # mips-unknown-linux-musl
> default y if BR2_mips && BR2_TOOLCHAIN_USES_MUSL && !BR2_MIPS_CPU_MIPS32R6
> # mips64-unknown-linux-muslabi64
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Buildroot] [git commit] package/rustc: fix target names for i586 and i686
2022-07-24 10:15 ` Baruch Siach via buildroot
@ 2022-07-24 10:33 ` Yann E. MORIN
0 siblings, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2022-07-24 10:33 UTC (permalink / raw)
To: Baruch Siach; +Cc: buildroot
Baruch, All,
On 2022-07-24 13:15 +0300, Baruch Siach spake thusly:
> On Sun, Jul 24 2022, Yann E. MORIN wrote:
> > commit: https://git.buildroot.net/buildroot/commit/?id=b4e706a6e320d5035cf05e8af3c6d9b8bb74fc33
> > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> >
> > Commit d69d40c029dc (package/rustc: add support for Tier 1 and Tier 2
> > platforms) misspelled the config options for i586 and i686.
> >
> > They are BR2_x86_i586 and BR2_x86_i686, not BR2_i586 or BR2_i686.
> >
> > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> > Cc: Baruch Siach <baruch@tkos.co.il>
> > Reviewed-by: Romain Naour <romain.naour@smile.fr>
> >
> > ---
> > Changes v1 -> v2:
> > - in commit log: s/BR2_i386_/BR2_x86_/g (Baruch)
> Did you mean to push this commit to master with the changelog?
No, indeed.
I wrote the changelogs before we discussed IRL and Arnout said I should
just pushed, so the changelogs sneaked in...
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-24 10:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-24 9:30 [Buildroot] [git commit] package/rustc: fix target names for i586 and i686 Yann E. MORIN
2022-07-24 10:15 ` Baruch Siach via buildroot
2022-07-24 10:33 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox