[Buildroot] [PATCH 1/1] package/pkg-cargo.mk: fix building cargo packages on 32bit arm

[Buildroot] [PATCH 1/1] package/pkg-cargo.mk: fix building cargo packages on 32bit arm

[Moritz Bitsch via buildroot]

From: Moritz Bitsch <moritz@h6t.eu>

there are duplicated symbols between rustc and gcc. Specifying
--allow-multiple-definition to the linker as workaround until
rustc is fixed.

rust-lang issue: https://github.com/rust-lang/compiler-builtins/issues/420

Fixes: http://autobuild.buildroot.net/results/53f/53f5598b8e520caaa135fb4923c09da382dab329
Signed-off-by: Moritz Bitsch <moritz@h6t.eu>
---
 package/pkg-cargo.mk | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/package/pkg-cargo.mk b/package/pkg-cargo.mk
index e74a8358bc..71d695d926 100644
--- a/package/pkg-cargo.mk
+++ b/package/pkg-cargo.mk
@@ -46,6 +46,14 @@ PKG_CARGO_ENV = \
 	CARGO_BUILD_TARGET="$(RUSTC_TARGET_NAME)" \
 	CARGO_TARGET_$(call UPPERCASE,$(RUSTC_TARGET_NAME))_LINKER=$(notdir $(TARGET_CROSS))gcc
 
+#
+# This is a workaround for https://github.com/rust-lang/compiler-builtins/issues/420
+# and should be removed when fixed upstream
+#
+ifeq ($(NORMALIZED_ARCH),arm)
+	PKG_CARGO_ENV += RUSTFLAGS="-Clink-arg=-Wl,--allow-multiple-definition"
+endif
+
 HOST_PKG_CARGO_ENV = \
 	$(PKG_COMMON_CARGO_ENV)
 
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/pkg-cargo.mk: fix building cargo packages on 32bit arm

[Arnout Vandecappelle]

On 18/02/2022 00:06, Moritz Bitsch via buildroot wrote:
> From: Moritz Bitsch <moritz@h6t.eu>
> 
> there are duplicated symbols between rustc and gcc. Specifying
> --allow-multiple-definition to the linker as workaround until
> rustc is fixed.
> 
> rust-lang issue: https://github.com/rust-lang/compiler-builtins/issues/420
> 
> Fixes: http://autobuild.buildroot.net/results/53f/53f5598b8e520caaa135fb4923c09da382dab329
> Signed-off-by: Moritz Bitsch <moritz@h6t.eu>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/pkg-cargo.mk | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/package/pkg-cargo.mk b/package/pkg-cargo.mk
> index e74a8358bc..71d695d926 100644
> --- a/package/pkg-cargo.mk
> +++ b/package/pkg-cargo.mk
> @@ -46,6 +46,14 @@ PKG_CARGO_ENV = \
>   	CARGO_BUILD_TARGET="$(RUSTC_TARGET_NAME)" \
>   	CARGO_TARGET_$(call UPPERCASE,$(RUSTC_TARGET_NAME))_LINKER=$(notdir $(TARGET_CROSS))gcc
>   
> +#
> +# This is a workaround for https://github.com/rust-lang/compiler-builtins/issues/420
> +# and should be removed when fixed upstream
> +#
> +ifeq ($(NORMALIZED_ARCH),arm)
> +	PKG_CARGO_ENV += RUSTFLAGS="-Clink-arg=-Wl,--allow-multiple-definition"
> +endif
> +
>   HOST_PKG_CARGO_ENV = \
>   	$(PKG_COMMON_CARGO_ENV)
>   
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/pkg-cargo.mk: fix building cargo packages on 32bit arm

[Yann E. MORIN]

Moritz, All,

On 2022-02-18 00:06 +0100, Moritz Bitsch via buildroot spake thusly:
> From: Moritz Bitsch <moritz@h6t.eu>
> 
> there are duplicated symbols between rustc and gcc. Specifying
> --allow-multiple-definition to the linker as workaround until
> rustc is fixed.
> 
> rust-lang issue: https://github.com/rust-lang/compiler-builtins/issues/420

This is supposedly fixed upstream:
    https://github.com/rust-lang/compiler-builtins/issues/420

which leads to:
    https://github.com/rust-lang/compiler-builtins/issues/412

which leads to:
    https://github.com/rust-lang/compiler-builtins/pull/452

and:
    https://github.com/rust-lang/rust/pull/93696

which is now merged.

We recently bumped to using rust 1.62.0.

Do you think that this workaround can now be dropped?

Regards,
Yann E. MORIN.

> Fixes: http://autobuild.buildroot.net/results/53f/53f5598b8e520caaa135fb4923c09da382dab329
> Signed-off-by: Moritz Bitsch <moritz@h6t.eu>
> ---
>  package/pkg-cargo.mk | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/package/pkg-cargo.mk b/package/pkg-cargo.mk
> index e74a8358bc..71d695d926 100644
> --- a/package/pkg-cargo.mk
> +++ b/package/pkg-cargo.mk
> @@ -46,6 +46,14 @@ PKG_CARGO_ENV = \
>  	CARGO_BUILD_TARGET="$(RUSTC_TARGET_NAME)" \
>  	CARGO_TARGET_$(call UPPERCASE,$(RUSTC_TARGET_NAME))_LINKER=$(notdir $(TARGET_CROSS))gcc
>  
> +#
> +# This is a workaround for https://github.com/rust-lang/compiler-builtins/issues/420
> +# and should be removed when fixed upstream
> +#
> +ifeq ($(NORMALIZED_ARCH),arm)
> +	PKG_CARGO_ENV += RUSTFLAGS="-Clink-arg=-Wl,--allow-multiple-definition"
> +endif
> +
>  HOST_PKG_CARGO_ENV = \
>  	$(PKG_COMMON_CARGO_ENV)
>  
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/pkg-cargo.mk: fix building cargo packages on 32bit arm

[Moritz Bitsch via buildroot]

Hello Yann, All,


it seems that the original autobuild error still requires the workaround 
with rust 1.62.0. I think we should keep the workaround in place.

If I get some time Ill have a look at what is going on, as the mentioned 
github issues are fixed.


Regards,

Moritz Bitsch

Am 24.07.22 um 18:08 schrieb Yann E. MORIN:
> Moritz, All,
>
> On 2022-02-18 00:06 +0100, Moritz Bitsch via buildroot spake thusly:
>> From: Moritz Bitsch <moritz@h6t.eu>
>>
>> there are duplicated symbols between rustc and gcc. Specifying
>> --allow-multiple-definition to the linker as workaround until
>> rustc is fixed.
>>
>> rust-lang issue: https://github.com/rust-lang/compiler-builtins/issues/420
> This is supposedly fixed upstream:
>      https://github.com/rust-lang/compiler-builtins/issues/420
>
> which leads to:
>      https://github.com/rust-lang/compiler-builtins/issues/412
>
> which leads to:
>      https://github.com/rust-lang/compiler-builtins/pull/452
>
> and:
>      https://github.com/rust-lang/rust/pull/93696
>
> which is now merged.
>
> We recently bumped to using rust 1.62.0.
>
> Do you think that this workaround can now be dropped?
>
> Regards,
> Yann E. MORIN.
>
>> Fixes: http://autobuild.buildroot.net/results/53f/53f5598b8e520caaa135fb4923c09da382dab329
>> Signed-off-by: Moritz Bitsch <moritz@h6t.eu>
>> ---
>>   package/pkg-cargo.mk | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/package/pkg-cargo.mk b/package/pkg-cargo.mk
>> index e74a8358bc..71d695d926 100644
>> --- a/package/pkg-cargo.mk
>> +++ b/package/pkg-cargo.mk
>> @@ -46,6 +46,14 @@ PKG_CARGO_ENV = \
>>   	CARGO_BUILD_TARGET="$(RUSTC_TARGET_NAME)" \
>>   	CARGO_TARGET_$(call UPPERCASE,$(RUSTC_TARGET_NAME))_LINKER=$(notdir $(TARGET_CROSS))gcc
>>   
>> +#
>> +# This is a workaround for https://github.com/rust-lang/compiler-builtins/issues/420
>> +# and should be removed when fixed upstream
>> +#
>> +ifeq ($(NORMALIZED_ARCH),arm)
>> +	PKG_CARGO_ENV += RUSTFLAGS="-Clink-arg=-Wl,--allow-multiple-definition"
>> +endif
>> +
>>   HOST_PKG_CARGO_ENV = \
>>   	$(PKG_COMMON_CARGO_ENV)
>>   
>> -- 
>> 2.35.1
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot