* [Buildroot] [PATCH v4 1/1] package/runc: add host package
@ 2022-07-25 0:24 Christian Stewart via buildroot
2022-07-25 7:33 ` Christian Stewart via buildroot
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Christian Stewart via buildroot @ 2022-07-25 0:24 UTC (permalink / raw)
To: buildroot; +Cc: Christian Stewart, Yann E . MORIN, Thomas Petazzoni
Adds support for building runc as a host package.
The bin name and gomod have to be specified as the pkg-golang infrastructure
assumes the bin name will be "host-runc" on default.
Signed-off-by: Christian Stewart <christian@paral.in>
---
changes v3 -> v4:
- drop unnecessary GOMOD line
- remove seccomp and apparmor tags for host package
- thanks Thomas for the review.
Signed-off-by: Christian Stewart <christian@paral.in>
---
package/Config.in.host | 1 +
package/runc/Config.in.host | 8 ++++++++
package/runc/runc.mk | 6 ++++++
3 files changed, 15 insertions(+)
create mode 100644 package/runc/Config.in.host
diff --git a/package/Config.in.host b/package/Config.in.host
index 71f2a9311c..8078a8304d 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -82,6 +82,7 @@ menu "Host utilities"
source "package/raspberrypi-usbboot/Config.in.host"
source "package/rauc/Config.in.host"
source "package/riscv-isa-sim/Config.in.host"
+ source "package/runc/Config.in.host"
source "package/rustc/Config.in.host"
source "package/s6-rc/Config.in.host"
source "package/sam-ba/Config.in.host"
diff --git a/package/runc/Config.in.host b/package/runc/Config.in.host
new file mode 100644
index 0000000000..ce0dd518a6
--- /dev/null
+++ b/package/runc/Config.in.host
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_HOST_RUNC
+ bool "host runc"
+ depends on BR2_PACKAGE_HOST_GO_HOST_ARCH_SUPPORTS
+ help
+ runC is a CLI tool for spawning and running containers
+ according to the OCP specification.
+
+ https://github.com/opencontainers/runc
diff --git a/package/runc/runc.mk b/package/runc/runc.mk
index 5faa8b683d..8ccff13a3e 100644
--- a/package/runc/runc.mk
+++ b/package/runc/runc.mk
@@ -23,4 +23,10 @@ RUNC_TAGS += seccomp
RUNC_DEPENDENCIES += libseccomp host-pkgconf
endif
+HOST_RUNC_BIN_NAME = runc
+HOST_RUNC_LDFLAGS = $(RUNC_LDFLAGS)
+HOST_RUNC_TAGS = cgo static_build
+HOST_RUNC_INSTALL_BINS = $(HOST_RUNC_BIN_NAME)
+
$(eval $(golang-package))
+$(eval $(host-golang-package))
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Buildroot] [PATCH v4 1/1] package/runc: add host package
2022-07-25 0:24 [Buildroot] [PATCH v4 1/1] package/runc: add host package Christian Stewart via buildroot
@ 2022-07-25 7:33 ` Christian Stewart via buildroot
2022-07-25 8:38 ` Yann E. MORIN
2022-07-25 9:37 ` Yann E. MORIN
2 siblings, 0 replies; 4+ messages in thread
From: Christian Stewart via buildroot @ 2022-07-25 7:33 UTC (permalink / raw)
To: Christian Stewart
Cc: Yann E . MORIN, Thomas Petazzoni, Buildroot Mailing List
Hi all,
On Sun, Jul 24, 2022 at 5:24 PM Christian Stewart <christian@paral.in> wrote:
Minor typo:
> + help
> + runC is a CLI tool for spawning and running containers
> + according to the OCP specification.
Replace OCP w/ OCI.
Similar patch was submitted to fix it in the existing Config.in as well.
Thanks & best,
Christian Stewart
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH v4 1/1] package/runc: add host package
2022-07-25 0:24 [Buildroot] [PATCH v4 1/1] package/runc: add host package Christian Stewart via buildroot
2022-07-25 7:33 ` Christian Stewart via buildroot
@ 2022-07-25 8:38 ` Yann E. MORIN
2022-07-25 9:37 ` Yann E. MORIN
2 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2022-07-25 8:38 UTC (permalink / raw)
To: Christian Stewart; +Cc: Thomas Petazzoni, buildroot
Christian, All,
On 2022-07-24 17:24 -0700, Christian Stewart spake thusly:
> Adds support for building runc as a host package.
>
> The bin name and gomod have to be specified as the pkg-golang infrastructure
> assumes the bin name will be "host-runc" on default.
Is that still true, even after 8539378771f (package/pkg-golang: default
to rawname to install binaries) ?
Regards,
Yann E. MORIN.
> Signed-off-by: Christian Stewart <christian@paral.in>
>
> ---
>
> changes v3 -> v4:
>
> - drop unnecessary GOMOD line
> - remove seccomp and apparmor tags for host package
> - thanks Thomas for the review.
>
> Signed-off-by: Christian Stewart <christian@paral.in>
> ---
> package/Config.in.host | 1 +
> package/runc/Config.in.host | 8 ++++++++
> package/runc/runc.mk | 6 ++++++
> 3 files changed, 15 insertions(+)
> create mode 100644 package/runc/Config.in.host
>
> diff --git a/package/Config.in.host b/package/Config.in.host
> index 71f2a9311c..8078a8304d 100644
> --- a/package/Config.in.host
> +++ b/package/Config.in.host
> @@ -82,6 +82,7 @@ menu "Host utilities"
> source "package/raspberrypi-usbboot/Config.in.host"
> source "package/rauc/Config.in.host"
> source "package/riscv-isa-sim/Config.in.host"
> + source "package/runc/Config.in.host"
> source "package/rustc/Config.in.host"
> source "package/s6-rc/Config.in.host"
> source "package/sam-ba/Config.in.host"
> diff --git a/package/runc/Config.in.host b/package/runc/Config.in.host
> new file mode 100644
> index 0000000000..ce0dd518a6
> --- /dev/null
> +++ b/package/runc/Config.in.host
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_HOST_RUNC
> + bool "host runc"
> + depends on BR2_PACKAGE_HOST_GO_HOST_ARCH_SUPPORTS
> + help
> + runC is a CLI tool for spawning and running containers
> + according to the OCP specification.
> +
> + https://github.com/opencontainers/runc
> diff --git a/package/runc/runc.mk b/package/runc/runc.mk
> index 5faa8b683d..8ccff13a3e 100644
> --- a/package/runc/runc.mk
> +++ b/package/runc/runc.mk
> @@ -23,4 +23,10 @@ RUNC_TAGS += seccomp
> RUNC_DEPENDENCIES += libseccomp host-pkgconf
> endif
>
> +HOST_RUNC_BIN_NAME = runc
> +HOST_RUNC_LDFLAGS = $(RUNC_LDFLAGS)
> +HOST_RUNC_TAGS = cgo static_build
> +HOST_RUNC_INSTALL_BINS = $(HOST_RUNC_BIN_NAME)
> +
> $(eval $(golang-package))
> +$(eval $(host-golang-package))
> --
> 2.35.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH v4 1/1] package/runc: add host package
2022-07-25 0:24 [Buildroot] [PATCH v4 1/1] package/runc: add host package Christian Stewart via buildroot
2022-07-25 7:33 ` Christian Stewart via buildroot
2022-07-25 8:38 ` Yann E. MORIN
@ 2022-07-25 9:37 ` Yann E. MORIN
2 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2022-07-25 9:37 UTC (permalink / raw)
To: Christian Stewart; +Cc: Thomas Petazzoni, buildroot
Christian, All,
On 2022-07-24 17:24 -0700, Christian Stewart via buildroot spake thusly:
> Adds support for building runc as a host package.
>
> The bin name and gomod have to be specified as the pkg-golang infrastructure
> assumes the bin name will be "host-runc" on default.
After a test build here, _BIN_NAME and _INSTALL_BINS really do not seem
needed, so I dropped them.
Applied to master, thanks.
Regards,
Yann E. MORIN.
> Signed-off-by: Christian Stewart <christian@paral.in>
>
> ---
>
> changes v3 -> v4:
>
> - drop unnecessary GOMOD line
> - remove seccomp and apparmor tags for host package
> - thanks Thomas for the review.
>
> Signed-off-by: Christian Stewart <christian@paral.in>
> ---
> package/Config.in.host | 1 +
> package/runc/Config.in.host | 8 ++++++++
> package/runc/runc.mk | 6 ++++++
> 3 files changed, 15 insertions(+)
> create mode 100644 package/runc/Config.in.host
>
> diff --git a/package/Config.in.host b/package/Config.in.host
> index 71f2a9311c..8078a8304d 100644
> --- a/package/Config.in.host
> +++ b/package/Config.in.host
> @@ -82,6 +82,7 @@ menu "Host utilities"
> source "package/raspberrypi-usbboot/Config.in.host"
> source "package/rauc/Config.in.host"
> source "package/riscv-isa-sim/Config.in.host"
> + source "package/runc/Config.in.host"
> source "package/rustc/Config.in.host"
> source "package/s6-rc/Config.in.host"
> source "package/sam-ba/Config.in.host"
> diff --git a/package/runc/Config.in.host b/package/runc/Config.in.host
> new file mode 100644
> index 0000000000..ce0dd518a6
> --- /dev/null
> +++ b/package/runc/Config.in.host
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_HOST_RUNC
> + bool "host runc"
> + depends on BR2_PACKAGE_HOST_GO_HOST_ARCH_SUPPORTS
> + help
> + runC is a CLI tool for spawning and running containers
> + according to the OCP specification.
> +
> + https://github.com/opencontainers/runc
> diff --git a/package/runc/runc.mk b/package/runc/runc.mk
> index 5faa8b683d..8ccff13a3e 100644
> --- a/package/runc/runc.mk
> +++ b/package/runc/runc.mk
> @@ -23,4 +23,10 @@ RUNC_TAGS += seccomp
> RUNC_DEPENDENCIES += libseccomp host-pkgconf
> endif
>
> +HOST_RUNC_BIN_NAME = runc
> +HOST_RUNC_LDFLAGS = $(RUNC_LDFLAGS)
> +HOST_RUNC_TAGS = cgo static_build
> +HOST_RUNC_INSTALL_BINS = $(HOST_RUNC_BIN_NAME)
> +
> $(eval $(golang-package))
> +$(eval $(host-golang-package))
> --
> 2.35.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-25 9:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-25 0:24 [Buildroot] [PATCH v4 1/1] package/runc: add host package Christian Stewart via buildroot
2022-07-25 7:33 ` Christian Stewart via buildroot
2022-07-25 8:38 ` Yann E. MORIN
2022-07-25 9:37 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox