From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>,
Samuel Martin <s.martin49@gmail.com>,
Sen Hastings <sen@phobosdpl.com>,
buildroot@buildroot.org, Norbert Lange <nolange79@gmail.com>,
"Yann E . MORIN" <yann.morin.1998@free.fr>,
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Subject: Re: [Buildroot] [PATCH v4 2/2] package/pkg-meson: use meson to build/install packages
Date: Tue, 26 Jul 2022 08:25:03 +0200 [thread overview]
Message-ID: <20220726082503.48ce118f@windsurf> (raw)
In-Reply-To: <20220726044425.72570-2-james.hilliard1@gmail.com>
Hello James,
On Mon, 25 Jul 2022 22:44:25 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> Note that we need to avoid setting HOST_DIR in paths when configuring
> as these will get appended to the destdir during installation which
> will result in incorrect paths.
I *think* this is wrong, at least in the classical autotools sense of
prefix vs. DESTDIR.
> @@ -156,10 +157,11 @@ define $(2)_CONFIGURE_CMDS
> mkdir -p $$($$(PKG)_SRCDIR)/build
> $$(HOST_CONFIGURE_OPTS) \
> $$($$(PKG)_CONF_ENV) $$(MESON) \
> - --prefix=$$(HOST_DIR) \
--prefix=$$(HOST_DIR)
should stay here.
> ifndef $(2)_INSTALL_CMDS
> define $(2)_INSTALL_CMDS
> - $$(HOST_MAKE_ENV) $$($$(PKG)_NINJA_ENV) \
> - $$(NINJA) $$(NINJA_OPTS) -C $$($$(PKG)_SRCDIR)/build install
> + $$(HOST_MAKE_ENV) \
> + $$($$(PKG)_MESON_ENV) \
> + $$(MESON) \
> + install \
> + $$(MESON_INSTALL_OPTS) \
> + --destdir $$(HOST_DIR) \
And you should drop --destdir $$(HOST_DIR) here.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-07-26 6:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 4:44 [Buildroot] [PATCH v4 1/2] support/misc/toolchainfile.cmake.in: don't set PKG_CONFIG_SYSROOT_DIR James Hilliard
2022-07-26 4:44 ` [Buildroot] [PATCH v4 2/2] package/pkg-meson: use meson to build/install packages James Hilliard
2022-07-26 6:25 ` Thomas Petazzoni via buildroot [this message]
2022-07-26 6:38 ` James Hilliard
2022-07-26 7:07 ` Thomas Petazzoni via buildroot
2022-07-26 17:26 ` James Hilliard
2022-07-26 17:34 ` Thomas Petazzoni via buildroot
2022-07-27 7:18 ` James Hilliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220726082503.48ce118f@windsurf \
--to=buildroot@buildroot.org \
--cc=eric.le.bihan.dev@free.fr \
--cc=james.hilliard1@gmail.com \
--cc=nolange79@gmail.com \
--cc=s.martin49@gmail.com \
--cc=sen@phobosdpl.com \
--cc=thomas.de_schampheleire@nokia.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox