From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>,
Samuel Martin <s.martin49@gmail.com>,
Sen Hastings <sen@phobosdpl.com>,
buildroot <buildroot@buildroot.org>,
Norbert Lange <nolange79@gmail.com>,
"Yann E . MORIN" <yann.morin.1998@free.fr>,
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Subject: Re: [Buildroot] [PATCH v4 2/2] package/pkg-meson: use meson to build/install packages
Date: Tue, 26 Jul 2022 19:34:02 +0200 [thread overview]
Message-ID: <20220726193402.4df88a69@windsurf> (raw)
In-Reply-To: <CADvTj4oay+SKPqUojKnuoG-XKk7D+GaiAgcT4Pj-mCic8SKXhw@mail.gmail.com>
On Tue, 26 Jul 2022 11:26:50 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> > prefix is the path where the software will be located when executed.
>
> We install to the package's per-package directory $(HOST_DIR) but
> we don't actually execute it from there AFAIU.
>
> Since the execution location changes for each per-package build I thought
> we wanted the prefix to be independent of the absolute installation path.
>
> >
> > DESTDIR is here to divert the installation.
> >
> > For host packages, we use prefix=$(HOST_DIR) and no DESTDIR because the
> > software will be located in $(HOST_DIR) when executed.
>
> But the $(HOST_DIR) it's installed to is not the same $(HOST_DIR) it's executed
> from when BR2_PER_PACKAGE_DIRECTORIES is enabled, at least when
> it's executed from a reverse dependency.
That is indeed true, but this usage of prefix/DESTDIR is also what we
do in CMake, autotools, and everywhere else, and it did work fine until
now with Meson. I wouldn't want Meson to stand out from
CMake/autotools, unless we have a solid reason to do so. It's not clear
why switching to calling meson to do the build/install requires this
change.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-07-26 17:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 4:44 [Buildroot] [PATCH v4 1/2] support/misc/toolchainfile.cmake.in: don't set PKG_CONFIG_SYSROOT_DIR James Hilliard
2022-07-26 4:44 ` [Buildroot] [PATCH v4 2/2] package/pkg-meson: use meson to build/install packages James Hilliard
2022-07-26 6:25 ` Thomas Petazzoni via buildroot
2022-07-26 6:38 ` James Hilliard
2022-07-26 7:07 ` Thomas Petazzoni via buildroot
2022-07-26 17:26 ` James Hilliard
2022-07-26 17:34 ` Thomas Petazzoni via buildroot [this message]
2022-07-27 7:18 ` James Hilliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220726193402.4df88a69@windsurf \
--to=buildroot@buildroot.org \
--cc=eric.le.bihan.dev@free.fr \
--cc=james.hilliard1@gmail.com \
--cc=nolange79@gmail.com \
--cc=s.martin49@gmail.com \
--cc=sen@phobosdpl.com \
--cc=thomas.de_schampheleire@nokia.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox