Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/volk: new package
@ 2022-02-08 16:24 Gwenhael Goavec-Merou
  2022-02-08 16:24 ` [Buildroot] [PATCH 2/2] package/gnuradio: move to package/volk instead of using the internal one Gwenhael Goavec-Merou
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Gwenhael Goavec-Merou @ 2022-02-08 16:24 UTC (permalink / raw)
  To: buildroot; +Cc: Gwenhael Goavec-Merou

From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>

VOLK is the Vector-Optimized Library of Kernels

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
---
 DEVELOPERS             |  1 +
 package/Config.in      |  1 +
 package/volk/Config.in | 31 +++++++++++++++++++++++++++++++
 package/volk/volk.hash |  3 +++
 package/volk/volk.mk   | 39 +++++++++++++++++++++++++++++++++++++++
 5 files changed, 75 insertions(+)
 create mode 100644 package/volk/Config.in
 create mode 100644 package/volk/volk.hash
 create mode 100644 package/volk/volk.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 1d1cf99898..c8a9b87c47 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1181,6 +1181,7 @@ F:	package/python-markdown/
 F:	package/python-remi/
 F:	package/python-sip/
 F:	package/uhd/
+F:	package/volk/
 
 N:	Heiko Thiery <heiko.thiery@gmail.com>
 F:	board/kontron/pitx-imx8m/
diff --git a/package/Config.in b/package/Config.in
index d631ed784a..c0353829a3 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -2062,6 +2062,7 @@ endif
 	source "package/tz/Config.in"
 	source "package/tzdata/Config.in"
 	source "package/uvw/Config.in"
+	source "package/volk/Config.in"
 	source "package/xapian/Config.in"
 endmenu
 
diff --git a/package/volk/Config.in b/package/volk/Config.in
new file mode 100644
index 0000000000..4539cd2153
--- /dev/null
+++ b/package/volk/Config.in
@@ -0,0 +1,31 @@
+comment "volk needs a toolchain w/ C++, NPTL, wchar, dynamic library"
+	depends on BR2_USE_MMU
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
+		!BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
+
+config BR2_PACKAGE_VOLK
+	bool "volk"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on !BR2_STATIC_LIBS
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
+	depends on BR2_USE_MMU # use fork()
+	depends on BR2_USE_WCHAR # boost
+	select BR2_PACKAGE_BOOST
+	select BR2_PACKAGE_BOOST_FILESYSTEM
+	select BR2_PACKAGE_BOOST_SYSTEM
+	help
+	  VOLK is the Vector-Optimized Library of Kernels. It is a
+	  library that contains kernels of hand-written SIMD code
+	  for different mathematical operations. Since each SIMD
+	  architecture can be very different and no compiler has yet
+	  come along to handle vectorization properly or highly
+	  efficiently, VOLK approaches the problem differently.
+
+	  For each architecture or platform that a developer wishes
+	  to vectorize for, a new proto-kernel is added to VOLK. At
+	  runtime, VOLK will select the correct proto-kernel. In this
+	  way, the users of VOLK call a kernel for performing the
+	  operation that is platform/architecture agnostic. This
+	  allows us to write portable SIMD code.
+
+	  https://www.libvolk.org/
diff --git a/package/volk/volk.hash b/package/volk/volk.hash
new file mode 100644
index 0000000000..9fca6c1b33
--- /dev/null
+++ b/package/volk/volk.hash
@@ -0,0 +1,3 @@
+# Locally computed
+sha256  d9183b9f86a32cdbb8698cbbeb15de574962c05200ccf445c1058629073521f8  volk-2.5.0.tar.gz
+sha256  8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903  COPYING
diff --git a/package/volk/volk.mk b/package/volk/volk.mk
new file mode 100644
index 0000000000..cdb0ea9a77
--- /dev/null
+++ b/package/volk/volk.mk
@@ -0,0 +1,39 @@
+################################################################################
+#
+# volk
+#
+################################################################################
+
+VOLK_VERSION = 2.5.0
+VOLK_SITE = https://github.com/gnuradio/volk/releases/download/v$(VOLK_VERSION)
+VOLK_LICENSE = GPL-3.0+
+VOLK_LICENSE_FILES = COPYING
+
+VOLK_SUPPORTS_IN_SOURCE_BUILD = NO
+
+# host-python-mako are needed for volk to compile
+VOLK_DEPENDENCIES = host-python3 host-python-mako boost
+
+VOLK_CONF_OPTS = \
+	-DPYTHON_EXECUTABLE=$(HOST_DIR)/bin/python3 \
+	-DENABLE_MODTOOL=OFF \
+	-DENABLE_TESTING=OFF \
+	-DENABLE_PROFILING=OFF \
+	-DVOLK_PYTHON_DIR=lib/python$(PYTHON3_VERSION_MAJOR)/site-packages
+
+# For third-party blocks, the volk library is mandatory at
+# compile time.
+VOLK_INSTALL_STAGING = YES
+
+ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
+VOLK_CONF_OPTS += -DCMAKE_EXE_LINKER_FLAGS=-latomic
+endif
+
+ifeq ($(BR2_PACKAGE_ORC),y)
+VOLK_DEPENDENCIES += orc
+VOLK_CONF_OPTS += -DENABLE_ORC=ON
+else
+VOLK_CONF_OPTS += -DENABLE_ORC=OFF
+endif
+
+$(eval $(cmake-package))
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 2/2] package/gnuradio: move to package/volk instead of using the internal one
  2022-02-08 16:24 [Buildroot] [PATCH 1/2] package/volk: new package Gwenhael Goavec-Merou
@ 2022-02-08 16:24 ` Gwenhael Goavec-Merou
  2022-07-26 17:41   ` Romain Naour
  2022-07-26 18:50   ` Thomas Petazzoni via buildroot
  2022-07-26 17:34 ` [Buildroot] [PATCH 1/2] package/volk: new package Romain Naour
  2022-07-26 18:41 ` Thomas Petazzoni via buildroot
  2 siblings, 2 replies; 8+ messages in thread
From: Gwenhael Goavec-Merou @ 2022-02-08 16:24 UTC (permalink / raw)
  To: buildroot; +Cc: Gwenhael Goavec-Merou

From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>

Until recent releases GNURadio was shipped with volk as a submodule. With 3.9
and 3.10 this is no more true and requires building volk before GNURadio.

This patch disable internal's volk, and add a dependency to the corresponding
package, to use inconditionnaly the one build by buildroot 

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
---
 package/gnuradio/Config.in   | 1 +
 package/gnuradio/gnuradio.mk | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/package/gnuradio/Config.in b/package/gnuradio/Config.in
index 1896d1326a..103175946c 100644
--- a/package/gnuradio/Config.in
+++ b/package/gnuradio/Config.in
@@ -28,6 +28,7 @@ config BR2_PACKAGE_GNURADIO
 	select BR2_PACKAGE_BOOST_THREAD
 	select BR2_PACKAGE_LOG4CPP
 	select BR2_PACKAGE_GMP
+	select BR2_PACKAGE_VOLK
 	help
 	  GNU Radio is a free & open-source software development
 	  toolkit that provides signal processing blocks to implement
diff --git a/package/gnuradio/gnuradio.mk b/package/gnuradio/gnuradio.mk
index 417a51e067..ed7060b85c 100644
--- a/package/gnuradio/gnuradio.mk
+++ b/package/gnuradio/gnuradio.mk
@@ -19,13 +19,15 @@ GNURADIO_DEPENDENCIES = \
 	host-swig \
 	boost \
 	log4cpp \
-	gmp
+	gmp \
+	volk
 
 GNURADIO_CONF_OPTS = \
 	-DPYTHON_EXECUTABLE=$(HOST_DIR)/bin/python3 \
 	-DENABLE_DEFAULT=OFF \
 	-DENABLE_VOLK=ON \
 	-DENABLE_GNURADIO_RUNTIME=ON \
+	-DENABLE_INTERNAL_VOLK=OFF \
 	-DENABLE_TESTING=OFF \
 	-DXMLTO_EXECUTABLE=NOTFOUND
 
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/volk: new package
  2022-02-08 16:24 [Buildroot] [PATCH 1/2] package/volk: new package Gwenhael Goavec-Merou
  2022-02-08 16:24 ` [Buildroot] [PATCH 2/2] package/gnuradio: move to package/volk instead of using the internal one Gwenhael Goavec-Merou
@ 2022-07-26 17:34 ` Romain Naour
  2022-07-26 18:41 ` Thomas Petazzoni via buildroot
  2 siblings, 0 replies; 8+ messages in thread
From: Romain Naour @ 2022-07-26 17:34 UTC (permalink / raw)
  To: Gwenhael Goavec-Merou, buildroot; +Cc: Gwenhael Goavec-Merou

Hello Gwenhael,

Le 08/02/2022 à 17:24, Gwenhael Goavec-Merou a écrit :
> From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> 
> VOLK is the Vector-Optimized Library of Kernels
> 
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> ---
>  DEVELOPERS             |  1 +
>  package/Config.in      |  1 +
>  package/volk/Config.in | 31 +++++++++++++++++++++++++++++++
>  package/volk/volk.hash |  3 +++
>  package/volk/volk.mk   | 39 +++++++++++++++++++++++++++++++++++++++
>  5 files changed, 75 insertions(+)
>  create mode 100644 package/volk/Config.in
>  create mode 100644 package/volk/volk.hash
>  create mode 100644 package/volk/volk.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 1d1cf99898..c8a9b87c47 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1181,6 +1181,7 @@ F:	package/python-markdown/
>  F:	package/python-remi/
>  F:	package/python-sip/
>  F:	package/uhd/
> +F:	package/volk/
>  
>  N:	Heiko Thiery <heiko.thiery@gmail.com>
>  F:	board/kontron/pitx-imx8m/
> diff --git a/package/Config.in b/package/Config.in
> index d631ed784a..c0353829a3 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -2062,6 +2062,7 @@ endif
>  	source "package/tz/Config.in"
>  	source "package/tzdata/Config.in"
>  	source "package/uvw/Config.in"
> +	source "package/volk/Config.in"
>  	source "package/xapian/Config.in"
>  endmenu
>  
> diff --git a/package/volk/Config.in b/package/volk/Config.in
> new file mode 100644
> index 0000000000..4539cd2153
> --- /dev/null
> +++ b/package/volk/Config.in
> @@ -0,0 +1,31 @@
> +comment "volk needs a toolchain w/ C++, NPTL, wchar, dynamic library"
> +	depends on BR2_USE_MMU
> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
> +		!BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
> +
> +config BR2_PACKAGE_VOLK
> +	bool "volk"
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on !BR2_STATIC_LIBS
> +	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
> +	depends on BR2_USE_MMU # use fork()
> +	depends on BR2_USE_WCHAR # boost
> +	select BR2_PACKAGE_BOOST
> +	select BR2_PACKAGE_BOOST_FILESYSTEM
> +	select BR2_PACKAGE_BOOST_SYSTEM
> +	help
> +	  VOLK is the Vector-Optimized Library of Kernels. It is a
> +	  library that contains kernels of hand-written SIMD code
> +	  for different mathematical operations. Since each SIMD
> +	  architecture can be very different and no compiler has yet
> +	  come along to handle vectorization properly or highly
> +	  efficiently, VOLK approaches the problem differently.
> +
> +	  For each architecture or platform that a developer wishes
> +	  to vectorize for, a new proto-kernel is added to VOLK. At
> +	  runtime, VOLK will select the correct proto-kernel. In this
> +	  way, the users of VOLK call a kernel for performing the
> +	  operation that is platform/architecture agnostic. This
> +	  allows us to write portable SIMD code.
> +
> +	  https://www.libvolk.org/
> diff --git a/package/volk/volk.hash b/package/volk/volk.hash
> new file mode 100644
> index 0000000000..9fca6c1b33
> --- /dev/null
> +++ b/package/volk/volk.hash
> @@ -0,0 +1,3 @@
> +# Locally computed
> +sha256  d9183b9f86a32cdbb8698cbbeb15de574962c05200ccf445c1058629073521f8  volk-2.5.0.tar.gz

When available, we prefer the tar.xz archive

https://github.com/gnuradio/volk/releases/download/v2.5.0/volk-2.5.0.tar.xz

Note: the 2.5.1 has been released few days after your contribution.

> +sha256  8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903  COPYING
> diff --git a/package/volk/volk.mk b/package/volk/volk.mk
> new file mode 100644
> index 0000000000..cdb0ea9a77
> --- /dev/null
> +++ b/package/volk/volk.mk
> @@ -0,0 +1,39 @@
> +################################################################################
> +#
> +# volk
> +#
> +################################################################################
> +
> +VOLK_VERSION = 2.5.0
> +VOLK_SITE = https://github.com/gnuradio/volk/releases/download/v$(VOLK_VERSION)
> +VOLK_LICENSE = GPL-3.0+
> +VOLK_LICENSE_FILES = COPYING

There are two other license file present in the root directory:
COPYING-GPL
COPYING-LGPL

About the licensing status:

https://github.com/gnuradio/volk/tree/v2.5.1#license

So GPL-3.0+ is still correct.

Otherwise:
Reviewed-by: Romain Naour <romain.naour@smile.fr>

Best regards,
Romain


> +
> +VOLK_SUPPORTS_IN_SOURCE_BUILD = NO
> +
> +# host-python-mako are needed for volk to compile
> +VOLK_DEPENDENCIES = host-python3 host-python-mako boost
> +
> +VOLK_CONF_OPTS = \
> +	-DPYTHON_EXECUTABLE=$(HOST_DIR)/bin/python3 \
> +	-DENABLE_MODTOOL=OFF \
> +	-DENABLE_TESTING=OFF \
> +	-DENABLE_PROFILING=OFF \
> +	-DVOLK_PYTHON_DIR=lib/python$(PYTHON3_VERSION_MAJOR)/site-packages
> +
> +# For third-party blocks, the volk library is mandatory at
> +# compile time.
> +VOLK_INSTALL_STAGING = YES
> +
> +ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
> +VOLK_CONF_OPTS += -DCMAKE_EXE_LINKER_FLAGS=-latomic
> +endif
> +
> +ifeq ($(BR2_PACKAGE_ORC),y)
> +VOLK_DEPENDENCIES += orc
> +VOLK_CONF_OPTS += -DENABLE_ORC=ON
> +else
> +VOLK_CONF_OPTS += -DENABLE_ORC=OFF
> +endif
> +
> +$(eval $(cmake-package))

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 2/2] package/gnuradio: move to package/volk instead of using the internal one
  2022-02-08 16:24 ` [Buildroot] [PATCH 2/2] package/gnuradio: move to package/volk instead of using the internal one Gwenhael Goavec-Merou
@ 2022-07-26 17:41   ` Romain Naour
  2022-07-26 18:56     ` Gwenhael Goavec-Merou
  2022-07-26 18:50   ` Thomas Petazzoni via buildroot
  1 sibling, 1 reply; 8+ messages in thread
From: Romain Naour @ 2022-07-26 17:41 UTC (permalink / raw)
  To: Gwenhael Goavec-Merou, buildroot; +Cc: Gwenhael Goavec-Merou

Hello Gwenhael,

Le 08/02/2022 à 17:24, Gwenhael Goavec-Merou a écrit :
> From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> 
> Until recent releases GNURadio was shipped with volk as a submodule. With 3.9
> and 3.10 this is no more true and requires building volk before GNURadio.

Currently Buildroot still provide gnuradio 3.8, adding volk dependency here is a
preliminary work before bumping gnuradio to a newer version.

> 
> This patch disable internal's volk, and add a dependency to the corresponding
> package, to use inconditionnaly the one build by buildroot 
> 
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> ---
>  package/gnuradio/Config.in   | 1 +
>  package/gnuradio/gnuradio.mk | 4 +++-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/package/gnuradio/Config.in b/package/gnuradio/Config.in
> index 1896d1326a..103175946c 100644
> --- a/package/gnuradio/Config.in
> +++ b/package/gnuradio/Config.in
> @@ -28,6 +28,7 @@ config BR2_PACKAGE_GNURADIO
>  	select BR2_PACKAGE_BOOST_THREAD
>  	select BR2_PACKAGE_LOG4CPP
>  	select BR2_PACKAGE_GMP
> +	select BR2_PACKAGE_VOLK

Maybe you could update the comment on wchar dependency:

depends on BR2_USE_WCHAR # boost, volk

Reviewed-by: Romain Naour <romain.naour@smile.fr>

Best regards,
Romain


>  	help
>  	  GNU Radio is a free & open-source software development
>  	  toolkit that provides signal processing blocks to implement
> diff --git a/package/gnuradio/gnuradio.mk b/package/gnuradio/gnuradio.mk
> index 417a51e067..ed7060b85c 100644
> --- a/package/gnuradio/gnuradio.mk
> +++ b/package/gnuradio/gnuradio.mk
> @@ -19,13 +19,15 @@ GNURADIO_DEPENDENCIES = \
>  	host-swig \
>  	boost \
>  	log4cpp \
> -	gmp
> +	gmp \
> +	volk
>  
>  GNURADIO_CONF_OPTS = \
>  	-DPYTHON_EXECUTABLE=$(HOST_DIR)/bin/python3 \
>  	-DENABLE_DEFAULT=OFF \
>  	-DENABLE_VOLK=ON \
>  	-DENABLE_GNURADIO_RUNTIME=ON \
> +	-DENABLE_INTERNAL_VOLK=OFF \
>  	-DENABLE_TESTING=OFF \
>  	-DXMLTO_EXECUTABLE=NOTFOUND
>  

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/volk: new package
  2022-02-08 16:24 [Buildroot] [PATCH 1/2] package/volk: new package Gwenhael Goavec-Merou
  2022-02-08 16:24 ` [Buildroot] [PATCH 2/2] package/gnuradio: move to package/volk instead of using the internal one Gwenhael Goavec-Merou
  2022-07-26 17:34 ` [Buildroot] [PATCH 1/2] package/volk: new package Romain Naour
@ 2022-07-26 18:41 ` Thomas Petazzoni via buildroot
  2022-07-26 18:51   ` Gwenhael Goavec-Merou
  2 siblings, 1 reply; 8+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-07-26 18:41 UTC (permalink / raw)
  To: Gwenhael Goavec-Merou; +Cc: Gwenhael Goavec-Merou, buildroot

On Tue,  8 Feb 2022 17:24:08 +0100
Gwenhael Goavec-Merou <gwenj@trabucayre.com> wrote:

> From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> 
> VOLK is the Vector-Optimized Library of Kernels
> 
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> ---
>  DEVELOPERS             |  1 +
>  package/Config.in      |  1 +
>  package/volk/Config.in | 31 +++++++++++++++++++++++++++++++
>  package/volk/volk.hash |  3 +++
>  package/volk/volk.mk   | 39 +++++++++++++++++++++++++++++++++++++++
>  5 files changed, 75 insertions(+)
>  create mode 100644 package/volk/Config.in
>  create mode 100644 package/volk/volk.hash
>  create mode 100644 package/volk/volk.mk

I've updated to version 2.5.1, switched to the .tar.xz tarball, added
COPYING-LGPL as a license file, added a missing
BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS dependency, and
applied.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 2/2] package/gnuradio: move to package/volk instead of using the internal one
  2022-02-08 16:24 ` [Buildroot] [PATCH 2/2] package/gnuradio: move to package/volk instead of using the internal one Gwenhael Goavec-Merou
  2022-07-26 17:41   ` Romain Naour
@ 2022-07-26 18:50   ` Thomas Petazzoni via buildroot
  1 sibling, 0 replies; 8+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-07-26 18:50 UTC (permalink / raw)
  To: Gwenhael Goavec-Merou; +Cc: Gwenhael Goavec-Merou, buildroot

On Tue,  8 Feb 2022 17:24:09 +0100
Gwenhael Goavec-Merou <gwenj@trabucayre.com> wrote:

> From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> 
> Until recent releases GNURadio was shipped with volk as a submodule. With 3.9
> and 3.10 this is no more true and requires building volk before GNURadio.
> 
> This patch disable internal's volk, and add a dependency to the corresponding
> package, to use inconditionnaly the one build by buildroot 
> 
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> ---
>  package/gnuradio/Config.in   | 1 +
>  package/gnuradio/gnuradio.mk | 4 +++-
>  2 files changed, 4 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/volk: new package
  2022-07-26 18:41 ` Thomas Petazzoni via buildroot
@ 2022-07-26 18:51   ` Gwenhael Goavec-Merou
  0 siblings, 0 replies; 8+ messages in thread
From: Gwenhael Goavec-Merou @ 2022-07-26 18:51 UTC (permalink / raw)
  To: Thomas Petazzoni; +Cc: Gwenhael Goavec-Merou, buildroot

On Tue, 26 Jul 2022 20:41:25 +0200
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> On Tue,  8 Feb 2022 17:24:08 +0100
> Gwenhael Goavec-Merou <gwenj@trabucayre.com> wrote:
> 
> > From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> > 
> > VOLK is the Vector-Optimized Library of Kernels
> > 
> > Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> > ---
> >  DEVELOPERS             |  1 +
> >  package/Config.in      |  1 +
> >  package/volk/Config.in | 31 +++++++++++++++++++++++++++++++
> >  package/volk/volk.hash |  3 +++
> >  package/volk/volk.mk   | 39 +++++++++++++++++++++++++++++++++++++++
> >  5 files changed, 75 insertions(+)
> >  create mode 100644 package/volk/Config.in
> >  create mode 100644 package/volk/volk.hash
> >  create mode 100644 package/volk/volk.mk  
> 
> I've updated to version 2.5.1, switched to the .tar.xz tarball, added
> COPYING-LGPL as a license file, added a missing
> BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS dependency, and
> applied.
> 
> Thanks a lot!
> 
> Thomas

Thanks to all!
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 2/2] package/gnuradio: move to package/volk instead of using the internal one
  2022-07-26 17:41   ` Romain Naour
@ 2022-07-26 18:56     ` Gwenhael Goavec-Merou
  0 siblings, 0 replies; 8+ messages in thread
From: Gwenhael Goavec-Merou @ 2022-07-26 18:56 UTC (permalink / raw)
  To: Romain Naour; +Cc: Gwenhael Goavec-Merou, buildroot

Hello Romain,

On Tue, 26 Jul 2022 19:41:17 +0200
Romain Naour <romain.naour@smile.fr> wrote:

> Hello Gwenhael,
> 
> Le 08/02/2022 à 17:24, Gwenhael Goavec-Merou a écrit :
> > From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> > 
> > Until recent releases GNURadio was shipped with volk as a submodule. With
> > 3.9 and 3.10 this is no more true and requires building volk before
> > GNURadio.  
> 
> Currently Buildroot still provide gnuradio 3.8, adding volk dependency here
> is a preliminary work before bumping gnuradio to a newer version.
> 
Yes. I have postponed gnuradio update because at this time many OOT blocks
wasn't compatibles, and more recently a problem with python-pybind (can't built
with a 64bits host for 32bits target and reciprocal). Now It's fixed and I have
to update this patch and complete serie with a bump for gnuradio and uhd.

Gwenhael

> > 
> > This patch disable internal's volk, and add a dependency to the
> > corresponding package, to use inconditionnaly the one build by buildroot 
> > 
> > Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> > ---
> >  package/gnuradio/Config.in   | 1 +
> >  package/gnuradio/gnuradio.mk | 4 +++-
> >  2 files changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/package/gnuradio/Config.in b/package/gnuradio/Config.in
> > index 1896d1326a..103175946c 100644
> > --- a/package/gnuradio/Config.in
> > +++ b/package/gnuradio/Config.in
> > @@ -28,6 +28,7 @@ config BR2_PACKAGE_GNURADIO
> >  	select BR2_PACKAGE_BOOST_THREAD
> >  	select BR2_PACKAGE_LOG4CPP
> >  	select BR2_PACKAGE_GMP
> > +	select BR2_PACKAGE_VOLK  
> 
> Maybe you could update the comment on wchar dependency:
> 
> depends on BR2_USE_WCHAR # boost, volk
> 
Thanks!
> Reviewed-by: Romain Naour <romain.naour@smile.fr>
> 
> Best regards,
> Romain
> 
> 
> >  	help
> >  	  GNU Radio is a free & open-source software development
> >  	  toolkit that provides signal processing blocks to implement
> > diff --git a/package/gnuradio/gnuradio.mk b/package/gnuradio/gnuradio.mk
> > index 417a51e067..ed7060b85c 100644
> > --- a/package/gnuradio/gnuradio.mk
> > +++ b/package/gnuradio/gnuradio.mk
> > @@ -19,13 +19,15 @@ GNURADIO_DEPENDENCIES = \
> >  	host-swig \
> >  	boost \
> >  	log4cpp \
> > -	gmp
> > +	gmp \
> > +	volk
> >  
> >  GNURADIO_CONF_OPTS = \
> >  	-DPYTHON_EXECUTABLE=$(HOST_DIR)/bin/python3 \
> >  	-DENABLE_DEFAULT=OFF \
> >  	-DENABLE_VOLK=ON \
> >  	-DENABLE_GNURADIO_RUNTIME=ON \
> > +	-DENABLE_INTERNAL_VOLK=OFF \
> >  	-DENABLE_TESTING=OFF \
> >  	-DXMLTO_EXECUTABLE=NOTFOUND
> >    
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-07-26 18:56 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-08 16:24 [Buildroot] [PATCH 1/2] package/volk: new package Gwenhael Goavec-Merou
2022-02-08 16:24 ` [Buildroot] [PATCH 2/2] package/gnuradio: move to package/volk instead of using the internal one Gwenhael Goavec-Merou
2022-07-26 17:41   ` Romain Naour
2022-07-26 18:56     ` Gwenhael Goavec-Merou
2022-07-26 18:50   ` Thomas Petazzoni via buildroot
2022-07-26 17:34 ` [Buildroot] [PATCH 1/2] package/volk: new package Romain Naour
2022-07-26 18:41 ` Thomas Petazzoni via buildroot
2022-07-26 18:51   ` Gwenhael Goavec-Merou

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox