Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Mark Corbin <mark@dibsco.co.uk>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/4] arch/Config.in.riscv: lp64f ABI is only supported if MMU is enabled
Date: Wed, 27 Jul 2022 09:57:17 +0200	[thread overview]
Message-ID: <20220727075717.GA1085273@scaer> (raw)
In-Reply-To: <20220726163951.2111731-1-thomas.petazzoni@bootlin.com>

Thomas, All,

On 2022-07-26 18:39 +0200, Thomas Petazzoni via buildroot spake thusly:
> Even though that seems weird, the LP64F ABI is only supported when MMU
> support is enabled. Indeed, as per commit
> 9a51381cedc16e6d70cb85e1144f6e0fa89af69a ("package/uclibc: prevent
> config with unsupported RISC-V float ABI"), uClibc does not support
> LP64F. But uClibc is the only C library that support RISC-V 64-bit
> noMMU.
> 
> So the selection of LP64F and !MMU is impossible. Right now this
> selection causes a build failure as no C library is enabled.
> 
> This commit fixes this by ensuring we cannot use LP64F when MMU
> support is not available.
> 
> Fixes:
> 
>   http://autobuild.buildroot.net/results/6320dcc655f1871eb8bf6a9689bddde7447385f5/
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  arch/Config.in.riscv | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/Config.in.riscv b/arch/Config.in.riscv
> index 288ed833eb..30bdcaa80b 100644
> --- a/arch/Config.in.riscv
> +++ b/arch/Config.in.riscv
> @@ -108,6 +108,7 @@ config BR2_RISCV_ABI_LP64
>  config BR2_RISCV_ABI_LP64F
>  	bool "lp64f"
>  	depends on BR2_ARCH_IS_64 && BR2_RISCV_ISA_RVF
> +	depends on BR2_USE_MMU
>  
>  config BR2_RISCV_ABI_LP64D
>  	bool "lp64d"
> -- 
> 2.37.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2022-07-27  7:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-26 16:39 [Buildroot] [PATCH v2 1/4] arch/Config.in.riscv: lp64f ABI is only supported if MMU is enabled Thomas Petazzoni via buildroot
2022-07-26 16:39 ` [Buildroot] [PATCH v2 2/4] package/Makefile.in: add detection for the lack of C library Thomas Petazzoni via buildroot
2022-07-27  7:58   ` Yann E. MORIN
2022-07-27  8:24     ` Thomas Petazzoni via buildroot
2022-08-29 20:15   ` Peter Korsgaard
2022-07-26 16:39 ` [Buildroot] [PATCH v2 3/4] arch/Config.in: move the binary format selection further down Thomas Petazzoni via buildroot
2022-07-27  7:58   ` Yann E. MORIN
2022-07-26 16:39 ` [Buildroot] [PATCH v2 4/4] arch: rework MMU option handling and move to "Target architecture" menu Thomas Petazzoni via buildroot
2022-07-27  7:03   ` Damien Le Moal via buildroot
2022-07-27  8:30   ` Yann E. MORIN
2022-07-27  9:22     ` Thomas Petazzoni via buildroot
2022-07-27  9:35       ` Yann E. MORIN
2022-07-27  9:43   ` Yann E. MORIN
2022-07-27  9:55     ` Thomas Petazzoni via buildroot
2022-07-27  7:57 ` Yann E. MORIN [this message]
2022-08-29 20:13 ` [Buildroot] [PATCH v2 1/4] arch/Config.in.riscv: lp64f ABI is only supported if MMU is enabled Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220727075717.GA1085273@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=mark@dibsco.co.uk \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox