Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/bluez-alsa: needs alsa-lib mixer
@ 2022-07-28 15:45 Fabrice Fontaine
  2022-07-28 20:57 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2022-07-28 15:45 UTC (permalink / raw)
  To: buildroot; +Cc: Jörg Krause, Fabrice Fontaine

aplay needs alsa-lib mixer since bump to version 4.0.0 in commit
e843433e186c6802ae0c31cb501b2212972ed725 and
https://github.com/Arkq/bluez-alsa/commit/7050c9a81895500fe2d59ec6e4859633d4353e36:

In file included from alsa-mixer.c:11:
alsa-mixer.h:16:21: error: unknown type name 'snd_mixer_t'; did you mean
'snd_timer_t'?
   16 | int alsa_mixer_open(snd_mixer_t **mixer, snd_mixer_elem_t
      **elem,
      |                     ^~~~~~~~~~~
      |                     snd_timer_t

So select BR2_PACKAGE_ALSA_LIB_MIXER instead of building aplay
conditionally to keep backward compatibility

Fixes:
 - http://autobuild.buildroot.org/results/d3faac6e49fe9cc21091a5dfa44780b8c63189be

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/bluez-alsa/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/bluez-alsa/Config.in b/package/bluez-alsa/Config.in
index 42bb9133bf..73ae3d5333 100644
--- a/package/bluez-alsa/Config.in
+++ b/package/bluez-alsa/Config.in
@@ -8,6 +8,7 @@ config BR2_PACKAGE_BLUEZ_ALSA
 	depends on BR2_USE_MMU # bluez5 -> dbus
 	depends on BR2_USE_WCHAR # libglib2
 	select BR2_PACKAGE_ALSA_LIB
+	select BR2_PACKAGE_ALSA_LIB_MIXER
 	select BR2_PACKAGE_BLUEZ5_UTILS
 	select BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_AUDIO
 	select BR2_PACKAGE_LIBGLIB2
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/bluez-alsa: needs alsa-lib mixer
  2022-07-28 15:45 [Buildroot] [PATCH 1/1] package/bluez-alsa: needs alsa-lib mixer Fabrice Fontaine
@ 2022-07-28 20:57 ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-07-28 20:57 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Jörg Krause, buildroot

On Thu, 28 Jul 2022 17:45:42 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> aplay needs alsa-lib mixer since bump to version 4.0.0 in commit
> e843433e186c6802ae0c31cb501b2212972ed725 and
> https://github.com/Arkq/bluez-alsa/commit/7050c9a81895500fe2d59ec6e4859633d4353e36:
> 
> In file included from alsa-mixer.c:11:
> alsa-mixer.h:16:21: error: unknown type name 'snd_mixer_t'; did you mean
> 'snd_timer_t'?
>    16 | int alsa_mixer_open(snd_mixer_t **mixer, snd_mixer_elem_t
>       **elem,
>       |                     ^~~~~~~~~~~
>       |                     snd_timer_t
> 
> So select BR2_PACKAGE_ALSA_LIB_MIXER instead of building aplay
> conditionally to keep backward compatibility
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/d3faac6e49fe9cc21091a5dfa44780b8c63189be
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/bluez-alsa/Config.in | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-07-28 20:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-28 15:45 [Buildroot] [PATCH 1/1] package/bluez-alsa: needs alsa-lib mixer Fabrice Fontaine
2022-07-28 20:57 ` Thomas Petazzoni via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox