Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2] package/libdill: new package
@ 2022-03-26 22:07 Angelo Compagnucci
  2022-07-26 21:49 ` Romain Naour
  0 siblings, 1 reply; 8+ messages in thread
From: Angelo Compagnucci @ 2022-03-26 22:07 UTC (permalink / raw)
  To: buildroot; +Cc: Angelo Compagnucci

Libdill is a C library that makes writing structured concurrent programs
easy.

Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
---
v1-v2:
Better configuration options handling:
libdill build can actually be customized only when using configure
indeed cmake doesn't offer the same configuration option,

 DEVELOPERS                   |  1 +
 package/Config.in            |  1 +
 package/libdill/Config.in    |  7 +++++++
 package/libdill/libdill.hash |  3 +++
 package/libdill/libdill.mk   | 25 +++++++++++++++++++++++++
 5 files changed, 37 insertions(+)
 create mode 100644 package/libdill/Config.in
 create mode 100644 package/libdill/libdill.hash
 create mode 100644 package/libdill/libdill.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 70d71186ed..9410944584 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -167,6 +167,7 @@ F:	package/i2c-tools/
 F:	package/jq/
 F:	package/libapparmor/
 F:	package/libb64/
+F:	package/libdill/
 F:	package/mender/
 F:	package/mender-artifact/
 F:	package/mono/
diff --git a/package/Config.in b/package/Config.in
index 0d5d763180..47f84a08dc 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1968,6 +1968,7 @@ menu "Other"
 	source "package/libcrossguid/Config.in"
 	source "package/libcsv/Config.in"
 	source "package/libdaemon/Config.in"
+	source "package/libdill/Config.in"
 	source "package/libeastl/Config.in"
 	source "package/libee/Config.in"
 	source "package/libev/Config.in"
diff --git a/package/libdill/Config.in b/package/libdill/Config.in
new file mode 100644
index 0000000000..0e6757b809
--- /dev/null
+++ b/package/libdill/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBDILL
+	bool "libdill"
+	help
+	  Libdill is a C library that makes writing structured concurrent
+	  programs easy.
+
+	  http://libdill.org
diff --git a/package/libdill/libdill.hash b/package/libdill/libdill.hash
new file mode 100644
index 0000000000..4a1fb91a57
--- /dev/null
+++ b/package/libdill/libdill.hash
@@ -0,0 +1,3 @@
+# sha256 locally computed
+sha256  6df7527e8f1e91f5106c21c5bfeaa69eee470bec476c74585143e3e439864404  libdill-fa01648cf2a8d06e53c965b45eeacfb3ac57bd04.tar.gz
+sha256  3f78d9c42c8919cb6dc63e51de17b9eb40a49d9cdd876ce59e77392721e8c2c6  COPYING
diff --git a/package/libdill/libdill.mk b/package/libdill/libdill.mk
new file mode 100644
index 0000000000..8efe1ff356
--- /dev/null
+++ b/package/libdill/libdill.mk
@@ -0,0 +1,25 @@
+################################################################################
+#
+# libdill
+#
+################################################################################
+
+LIBDILL_VERSION = fa01648cf2a8d06e53c965b45eeacfb3ac57bd04
+LIBDILL_SITE = $(call github,sustrik,libdill,$(LIBDILL_VERSION))
+LIBDILL_LICENSE = MIT
+LIBDILL_LICENSE_FILES = COPYING
+LIBDILL_CPE_ID_VENDOR = libdill
+LIBDILL_CPE_ID_PRODUCT = libdill
+LIBDILL_INSTALL_STAGING = YES
+LIBDILL_AUTORECONF = YES
+
+ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
+LIBDILL_CONF_OPTS += --disable-threads
+endif
+
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LIBDILL_DEPENDENCIES = openssl
+LIBDILL_CONF_OPTS += --enable-tls
+endif
+
+$(eval $(autotools-package))
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH v2] package/libdill: new package
  2022-03-26 22:07 Angelo Compagnucci
@ 2022-07-26 21:49 ` Romain Naour
  2022-07-28 21:11   ` Angelo Compagnucci
  0 siblings, 1 reply; 8+ messages in thread
From: Romain Naour @ 2022-07-26 21:49 UTC (permalink / raw)
  To: Angelo Compagnucci, buildroot

Hello Angelo,

Le 26/03/2022 à 23:07, Angelo Compagnucci a écrit :
> Libdill is a C library that makes writing structured concurrent programs
> easy.
> 
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
> ---
> v1-v2:
> Better configuration options handling:
> libdill build can actually be customized only when using configure
> indeed cmake doesn't offer the same configuration option,
> 
>  DEVELOPERS                   |  1 +
>  package/Config.in            |  1 +
>  package/libdill/Config.in    |  7 +++++++
>  package/libdill/libdill.hash |  3 +++
>  package/libdill/libdill.mk   | 25 +++++++++++++++++++++++++
>  5 files changed, 37 insertions(+)
>  create mode 100644 package/libdill/Config.in
>  create mode 100644 package/libdill/libdill.hash
>  create mode 100644 package/libdill/libdill.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 70d71186ed..9410944584 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -167,6 +167,7 @@ F:	package/i2c-tools/
>  F:	package/jq/
>  F:	package/libapparmor/
>  F:	package/libb64/
> +F:	package/libdill/
>  F:	package/mender/
>  F:	package/mender-artifact/
>  F:	package/mono/
> diff --git a/package/Config.in b/package/Config.in
> index 0d5d763180..47f84a08dc 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1968,6 +1968,7 @@ menu "Other"
>  	source "package/libcrossguid/Config.in"
>  	source "package/libcsv/Config.in"
>  	source "package/libdaemon/Config.in"
> +	source "package/libdill/Config.in"
>  	source "package/libeastl/Config.in"
>  	source "package/libee/Config.in"
>  	source "package/libev/Config.in"
> diff --git a/package/libdill/Config.in b/package/libdill/Config.in
> new file mode 100644
> index 0000000000..0e6757b809
> --- /dev/null
> +++ b/package/libdill/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_LIBDILL

Have you checked with test-pkg ?

> +	bool "libdill"
> +	help
> +	  Libdill is a C library that makes writing structured concurrent
> +	  programs easy.
> +
> +	  http://libdill.org
> diff --git a/package/libdill/libdill.hash b/package/libdill/libdill.hash
> new file mode 100644
> index 0000000000..4a1fb91a57
> --- /dev/null
> +++ b/package/libdill/libdill.hash
> @@ -0,0 +1,3 @@
> +# sha256 locally computed
> +sha256  6df7527e8f1e91f5106c21c5bfeaa69eee470bec476c74585143e3e439864404  libdill-fa01648cf2a8d06e53c965b45eeacfb3ac57bd04.tar.gz
> +sha256  3f78d9c42c8919cb6dc63e51de17b9eb40a49d9cdd876ce59e77392721e8c2c6  COPYING
> diff --git a/package/libdill/libdill.mk b/package/libdill/libdill.mk
> new file mode 100644
> index 0000000000..8efe1ff356
> --- /dev/null
> +++ b/package/libdill/libdill.mk
> @@ -0,0 +1,25 @@
> +################################################################################
> +#
> +# libdill
> +#
> +################################################################################
> +
> +LIBDILL_VERSION = fa01648cf2a8d06e53c965b45eeacfb3ac57bd04
> +LIBDILL_SITE = $(call github,sustrik,libdill,$(LIBDILL_VERSION))
> +LIBDILL_LICENSE = MIT
> +LIBDILL_LICENSE_FILES = COPYING
> +LIBDILL_CPE_ID_VENDOR = libdill
> +LIBDILL_CPE_ID_PRODUCT = libdill
> +LIBDILL_INSTALL_STAGING = YES
> +LIBDILL_AUTORECONF = YES

Usually we requires a comment to remember why autoreconf is needed.
Here it's directly fetched from github and we need autoreconf to generate the
configure script.

> +
> +ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> +LIBDILL_CONF_OPTS += --disable-threads
> +endif
> +
> +ifeq ($(BR2_PACKAGE_OPENSSL),y)
> +LIBDILL_DEPENDENCIES = openssl

Openssl is a virtual package. Did you check with other ssl provided such libressl ?

Best regards,
Romain


> +LIBDILL_CONF_OPTS += --enable-tls
> +endif
> +
> +$(eval $(autotools-package))

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH v2] package/libdill: new package
  2022-07-26 21:49 ` Romain Naour
@ 2022-07-28 21:11   ` Angelo Compagnucci
  0 siblings, 0 replies; 8+ messages in thread
From: Angelo Compagnucci @ 2022-07-28 21:11 UTC (permalink / raw)
  To: Romain Naour; +Cc: buildroot, Angelo Compagnucci

Il giorno mar 26 lug 2022 alle ore 23:49 Romain Naour
<romain.naour@smile.fr> ha scritto:
>
> Hello Angelo,
>
> Le 26/03/2022 à 23:07, Angelo Compagnucci a écrit :
> > Libdill is a C library that makes writing structured concurrent programs
> > easy.
> >
> > Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
> > ---
> > v1-v2:
> > Better configuration options handling:
> > libdill build can actually be customized only when using configure
> > indeed cmake doesn't offer the same configuration option,
> >
> >  DEVELOPERS                   |  1 +
> >  package/Config.in            |  1 +
> >  package/libdill/Config.in    |  7 +++++++
> >  package/libdill/libdill.hash |  3 +++
> >  package/libdill/libdill.mk   | 25 +++++++++++++++++++++++++
> >  5 files changed, 37 insertions(+)
> >  create mode 100644 package/libdill/Config.in
> >  create mode 100644 package/libdill/libdill.hash
> >  create mode 100644 package/libdill/libdill.mk
> >
> > diff --git a/DEVELOPERS b/DEVELOPERS
> > index 70d71186ed..9410944584 100644
> > --- a/DEVELOPERS
> > +++ b/DEVELOPERS
> > @@ -167,6 +167,7 @@ F:        package/i2c-tools/
> >  F:   package/jq/
> >  F:   package/libapparmor/
> >  F:   package/libb64/
> > +F:   package/libdill/
> >  F:   package/mender/
> >  F:   package/mender-artifact/
> >  F:   package/mono/
> > diff --git a/package/Config.in b/package/Config.in
> > index 0d5d763180..47f84a08dc 100644
> > --- a/package/Config.in
> > +++ b/package/Config.in
> > @@ -1968,6 +1968,7 @@ menu "Other"
> >       source "package/libcrossguid/Config.in"
> >       source "package/libcsv/Config.in"
> >       source "package/libdaemon/Config.in"
> > +     source "package/libdill/Config.in"
> >       source "package/libeastl/Config.in"
> >       source "package/libee/Config.in"
> >       source "package/libev/Config.in"
> > diff --git a/package/libdill/Config.in b/package/libdill/Config.in
> > new file mode 100644
> > index 0000000000..0e6757b809
> > --- /dev/null
> > +++ b/package/libdill/Config.in
> > @@ -0,0 +1,7 @@
> > +config BR2_PACKAGE_LIBDILL
>
> Have you checked with test-pkg ?

Not really, I tested it with some configuration I'm working with. I'll
do a run with test-pkg too.

>
> > +     bool "libdill"
> > +     help
> > +       Libdill is a C library that makes writing structured concurrent
> > +       programs easy.
> > +
> > +       http://libdill.org
> > diff --git a/package/libdill/libdill.hash b/package/libdill/libdill.hash
> > new file mode 100644
> > index 0000000000..4a1fb91a57
> > --- /dev/null
> > +++ b/package/libdill/libdill.hash
> > @@ -0,0 +1,3 @@
> > +# sha256 locally computed
> > +sha256  6df7527e8f1e91f5106c21c5bfeaa69eee470bec476c74585143e3e439864404  libdill-fa01648cf2a8d06e53c965b45eeacfb3ac57bd04.tar.gz
> > +sha256  3f78d9c42c8919cb6dc63e51de17b9eb40a49d9cdd876ce59e77392721e8c2c6  COPYING
> > diff --git a/package/libdill/libdill.mk b/package/libdill/libdill.mk
> > new file mode 100644
> > index 0000000000..8efe1ff356
> > --- /dev/null
> > +++ b/package/libdill/libdill.mk
> > @@ -0,0 +1,25 @@
> > +################################################################################
> > +#
> > +# libdill
> > +#
> > +################################################################################
> > +
> > +LIBDILL_VERSION = fa01648cf2a8d06e53c965b45eeacfb3ac57bd04
> > +LIBDILL_SITE = $(call github,sustrik,libdill,$(LIBDILL_VERSION))
> > +LIBDILL_LICENSE = MIT
> > +LIBDILL_LICENSE_FILES = COPYING
> > +LIBDILL_CPE_ID_VENDOR = libdill
> > +LIBDILL_CPE_ID_PRODUCT = libdill
> > +LIBDILL_INSTALL_STAGING = YES
> > +LIBDILL_AUTORECONF = YES
>
> Usually we requires a comment to remember why autoreconf is needed.
> Here it's directly fetched from github and we need autoreconf to generate the
> configure script.

I'll add to V2

>
> > +
> > +ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> > +LIBDILL_CONF_OPTS += --disable-threads
> > +endif
> > +
> > +ifeq ($(BR2_PACKAGE_OPENSSL),y)
> > +LIBDILL_DEPENDENCIES = openssl
>
> Openssl is a virtual package. Did you check with other ssl provided such libressl ?

Yes and it work with both open/libressl

>
> Best regards,
> Romain
>
>
> > +LIBDILL_CONF_OPTS += --enable-tls
> > +endif
> > +
> > +$(eval $(autotools-package))
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot



-- 
Profile: http://it.linkedin.com/in/compagnucciangelo
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v2] package/libdill: new package
@ 2022-07-28 21:12 Angelo Compagnucci
  2022-07-29  8:47 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 8+ messages in thread
From: Angelo Compagnucci @ 2022-07-28 21:12 UTC (permalink / raw)
  To: buildroot; +Cc: Angelo Compagnucci

Libdill is a C library that makes writing structured concurrent programs
easy.

Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
---
Changelog

v1->v2:
* Added comment to autoreconf (Romain)

 DEVELOPERS                   |  1 +
 package/Config.in            |  1 +
 package/libdill/Config.in    |  7 +++++++
 package/libdill/libdill.hash |  3 +++
 package/libdill/libdill.mk   | 26 ++++++++++++++++++++++++++
 5 files changed, 38 insertions(+)
 create mode 100644 package/libdill/Config.in
 create mode 100644 package/libdill/libdill.hash
 create mode 100644 package/libdill/libdill.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index cb98c3883d..f32eb6babf 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -164,6 +164,7 @@ F:	package/i2c-tools/
 F:	package/jq/
 F:	package/libapparmor/
 F:	package/libb64/
+F:	package/libdill/
 F:	package/mender/
 F:	package/mender-artifact/
 F:	package/mono/
diff --git a/package/Config.in b/package/Config.in
index 4ff1fb2f3c..fd0598c537 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1999,6 +1999,7 @@ menu "Other"
 	source "package/libcrossguid/Config.in"
 	source "package/libcsv/Config.in"
 	source "package/libdaemon/Config.in"
+	source "package/libdill/Config.in"
 	source "package/libeastl/Config.in"
 	source "package/libee/Config.in"
 	source "package/libev/Config.in"
diff --git a/package/libdill/Config.in b/package/libdill/Config.in
new file mode 100644
index 0000000000..0e6757b809
--- /dev/null
+++ b/package/libdill/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBDILL
+	bool "libdill"
+	help
+	  Libdill is a C library that makes writing structured concurrent
+	  programs easy.
+
+	  http://libdill.org
diff --git a/package/libdill/libdill.hash b/package/libdill/libdill.hash
new file mode 100644
index 0000000000..4a1fb91a57
--- /dev/null
+++ b/package/libdill/libdill.hash
@@ -0,0 +1,3 @@
+# sha256 locally computed
+sha256  6df7527e8f1e91f5106c21c5bfeaa69eee470bec476c74585143e3e439864404  libdill-fa01648cf2a8d06e53c965b45eeacfb3ac57bd04.tar.gz
+sha256  3f78d9c42c8919cb6dc63e51de17b9eb40a49d9cdd876ce59e77392721e8c2c6  COPYING
diff --git a/package/libdill/libdill.mk b/package/libdill/libdill.mk
new file mode 100644
index 0000000000..822f07b939
--- /dev/null
+++ b/package/libdill/libdill.mk
@@ -0,0 +1,26 @@
+################################################################################
+#
+# libdill
+#
+################################################################################
+
+LIBDILL_VERSION = fa01648cf2a8d06e53c965b45eeacfb3ac57bd04
+LIBDILL_SITE = $(call github,sustrik,libdill,$(LIBDILL_VERSION))
+LIBDILL_LICENSE = MIT
+LIBDILL_LICENSE_FILES = COPYING
+LIBDILL_CPE_ID_VENDOR = libdill
+LIBDILL_CPE_ID_PRODUCT = libdill
+LIBDILL_INSTALL_STAGING = YES
+# Fetched from Github, with no configure script
+LIBDILL_AUTORECONF = YES
+
+ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
+LIBDILL_CONF_OPTS += --disable-threads
+endif
+
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LIBDILL_DEPENDENCIES = openssl
+LIBDILL_CONF_OPTS += --enable-tls
+endif
+
+$(eval $(autotools-package))
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH v2] package/libdill: new package
  2022-07-28 21:12 [Buildroot] [PATCH v2] package/libdill: new package Angelo Compagnucci
@ 2022-07-29  8:47 ` Thomas Petazzoni via buildroot
  2022-07-29 19:00   ` Arnout Vandecappelle
  2022-07-29 22:06   ` Angelo Compagnucci
  0 siblings, 2 replies; 8+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-07-29  8:47 UTC (permalink / raw)
  To: Angelo Compagnucci; +Cc: buildroot

Hello Angelo,

On Thu, 28 Jul 2022 23:12:59 +0200
Angelo Compagnucci <angelo@amarulasolutions.com> wrote:

> Libdill is a C library that makes writing structured concurrent programs
> easy.
> 
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>

Looks good. A few comments/questions.


> diff --git a/package/libdill/Config.in b/package/libdill/Config.in
> new file mode 100644
> index 0000000000..0e6757b809
> --- /dev/null
> +++ b/package/libdill/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_LIBDILL
> +	bool "libdill"

No dependencies at all? Tested with test-pkg?

> diff --git a/package/libdill/libdill.mk b/package/libdill/libdill.mk
> new file mode 100644
> index 0000000000..822f07b939
> --- /dev/null
> +++ b/package/libdill/libdill.mk
> @@ -0,0 +1,26 @@
> +################################################################################
> +#
> +# libdill
> +#
> +################################################################################
> +
> +LIBDILL_VERSION = fa01648cf2a8d06e53c965b45eeacfb3ac57bd04
> +LIBDILL_SITE = $(call github,sustrik,libdill,$(LIBDILL_VERSION))
> +LIBDILL_LICENSE = MIT
> +LIBDILL_LICENSE_FILES = COPYING
> +LIBDILL_CPE_ID_VENDOR = libdill
> +LIBDILL_CPE_ID_PRODUCT = libdill

Could you add a link in the commit log that shows you have verified these?

> +LIBDILL_INSTALL_STAGING = YES
> +# Fetched from Github, with no configure script
> +LIBDILL_AUTORECONF = YES
> +
> +ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)

ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),)

> +LIBDILL_CONF_OPTS += --disable-threads
> +endif
> +
> +ifeq ($(BR2_PACKAGE_OPENSSL),y)
> +LIBDILL_DEPENDENCIES = openssl
> +LIBDILL_CONF_OPTS += --enable-tls

No "else" clause to explicitly disable?

> +endif

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH v2] package/libdill: new package
  2022-07-29  8:47 ` Thomas Petazzoni via buildroot
@ 2022-07-29 19:00   ` Arnout Vandecappelle
  2022-07-29 22:04     ` Angelo Compagnucci
  2022-07-29 22:06   ` Angelo Compagnucci
  1 sibling, 1 reply; 8+ messages in thread
From: Arnout Vandecappelle @ 2022-07-29 19:00 UTC (permalink / raw)
  To: Thomas Petazzoni, Angelo Compagnucci; +Cc: buildroot



On 29/07/2022 10:47, Thomas Petazzoni via buildroot wrote:
> Hello Angelo,
> 
> On Thu, 28 Jul 2022 23:12:59 +0200
> Angelo Compagnucci <angelo@amarulasolutions.com> wrote:
> 
>> Libdill is a C library that makes writing structured concurrent programs
>> easy.
>>
>> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
[snip]
>> diff --git a/package/libdill/libdill.mk b/package/libdill/libdill.mk
>> new file mode 100644
>> index 0000000000..822f07b939
>> --- /dev/null
>> +++ b/package/libdill/libdill.mk
>> @@ -0,0 +1,26 @@
>> +################################################################################
>> +#
>> +# libdill
>> +#
>> +################################################################################
>> +
>> +LIBDILL_VERSION = fa01648cf2a8d06e53c965b45eeacfb3ac57bd04
>> +LIBDILL_SITE = $(call github,sustrik,libdill,$(LIBDILL_VERSION))
>> +LIBDILL_LICENSE = MIT
>> +LIBDILL_LICENSE_FILES = COPYING
>> +LIBDILL_CPE_ID_VENDOR = libdill
>> +LIBDILL_CPE_ID_PRODUCT = libdill
> 
> Could you add a link in the commit log that shows you have verified these?

  See for example how Fabrice does it:

cpe:2.3:a:osgeo:gdal is a valid CPE identifier for this package:

 
https://nvd.nist.gov/products/cpe/search/results?namingFormat=2.3&keyword=cpe%3A2.3%3Aa%3Aosgeo%3Agdal


  (We should add this to the manual as well.)


>> +LIBDILL_INSTALL_STAGING = YES
>> +# Fetched from Github, with no configure script
>> +LIBDILL_AUTORECONF = YES
>> +
>> +ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> 
> ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),)
> 
>> +LIBDILL_CONF_OPTS += --disable-threads

  What kind of concurrent programming can you do without threads?

  Regards,
  Arnout

>> +endif
>> +
>> +ifeq ($(BR2_PACKAGE_OPENSSL),y)
>> +LIBDILL_DEPENDENCIES = openssl
>> +LIBDILL_CONF_OPTS += --enable-tls
> 
> No "else" clause to explicitly disable?
> 
>> +endif
> 
> Thanks!
> 
> Thomas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH v2] package/libdill: new package
  2022-07-29 19:00   ` Arnout Vandecappelle
@ 2022-07-29 22:04     ` Angelo Compagnucci
  0 siblings, 0 replies; 8+ messages in thread
From: Angelo Compagnucci @ 2022-07-29 22:04 UTC (permalink / raw)
  To: Arnout Vandecappelle; +Cc: Thomas Petazzoni, buildroot


[-- Attachment #1.1: Type: text/plain, Size: 2589 bytes --]

On Fri, Jul 29, 2022 at 9:00 PM Arnout Vandecappelle <arnout@mind.be> wrote:

>
>
> On 29/07/2022 10:47, Thomas Petazzoni via buildroot wrote:
> > Hello Angelo,
> >
> > On Thu, 28 Jul 2022 23:12:59 +0200
> > Angelo Compagnucci <angelo@amarulasolutions.com> wrote:
> >
> >> Libdill is a C library that makes writing structured concurrent programs
> >> easy.
> >>
> >> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
> [snip]
> >> diff --git a/package/libdill/libdill.mk b/package/libdill/libdill.mk
> >> new file mode 100644
> >> index 0000000000..822f07b939
> >> --- /dev/null
> >> +++ b/package/libdill/libdill.mk
> >> @@ -0,0 +1,26 @@
> >>
> +################################################################################
> >> +#
> >> +# libdill
> >> +#
> >>
> +################################################################################
> >> +
> >> +LIBDILL_VERSION = fa01648cf2a8d06e53c965b45eeacfb3ac57bd04
> >> +LIBDILL_SITE = $(call github,sustrik,libdill,$(LIBDILL_VERSION))
> >> +LIBDILL_LICENSE = MIT
> >> +LIBDILL_LICENSE_FILES = COPYING
> >> +LIBDILL_CPE_ID_VENDOR = libdill
> >> +LIBDILL_CPE_ID_PRODUCT = libdill
> >
> > Could you add a link in the commit log that shows you have verified
> these?
>
>   See for example how Fabrice does it:
>
> cpe:2.3:a:osgeo:gdal is a valid CPE identifier for this package:
>
>
>
> https://nvd.nist.gov/products/cpe/search/results?namingFormat=2.3&keyword=cpe%3A2.3%3Aa%3Aosgeo%3Agdal
>
>
>   (We should add this to the manual as well.)
>

Indeed. I did a research and I was unable to find a proper CPE id so I
removed the CPE info from the package.


>
> >> +LIBDILL_INSTALL_STAGING = YES
> >> +# Fetched from Github, with no configure script
> >> +LIBDILL_AUTORECONF = YES
> >> +
> >> +ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> >
> > ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),)
> >
> >> +LIBDILL_CONF_OPTS += --disable-threads
>
>   What kind of concurrent programming can you do without threads?
>

Async coroutines with cooperative scheduling. Extremely fast indeed!


>
>   Regards,
>   Arnout
>
> >> +endif
> >> +
> >> +ifeq ($(BR2_PACKAGE_OPENSSL),y)
> >> +LIBDILL_DEPENDENCIES = openssl
> >> +LIBDILL_CONF_OPTS += --enable-tls
> >
> > No "else" clause to explicitly disable?
> >
> >> +endif
> >
> > Thanks!
> >
> > Thomas
>


-- 

Angelo Compagnucci

Software Engineer

angelo@amarulasolutions.com
__________________________________
Amarula Solutions SRL

Via le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 (0)42 243 5310
info@amarulasolutions.com

www.amarulasolutions.com
[`as] https://www.amarulasolutions.com|

[-- Attachment #1.2: Type: text/html, Size: 7970 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH v2] package/libdill: new package
  2022-07-29  8:47 ` Thomas Petazzoni via buildroot
  2022-07-29 19:00   ` Arnout Vandecappelle
@ 2022-07-29 22:06   ` Angelo Compagnucci
  1 sibling, 0 replies; 8+ messages in thread
From: Angelo Compagnucci @ 2022-07-29 22:06 UTC (permalink / raw)
  To: Thomas Petazzoni; +Cc: buildroot


[-- Attachment #1.1: Type: text/plain, Size: 2526 bytes --]

On Fri, Jul 29, 2022 at 10:47 AM Thomas Petazzoni <
thomas.petazzoni@bootlin.com> wrote:

> Hello Angelo,
>
> On Thu, 28 Jul 2022 23:12:59 +0200
> Angelo Compagnucci <angelo@amarulasolutions.com> wrote:
>
> > Libdill is a C library that makes writing structured concurrent programs
> > easy.
> >
> > Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
>
> Looks good. A few comments/questions.
>
>
> > diff --git a/package/libdill/Config.in b/package/libdill/Config.in
> > new file mode 100644
> > index 0000000000..0e6757b809
> > --- /dev/null
> > +++ b/package/libdill/Config.in
> > @@ -0,0 +1,7 @@
> > +config BR2_PACKAGE_LIBDILL
> > +     bool "libdill"
>
> No dependencies at all? Tested with test-pkg?
>

Yes. tested with

BR2_PACKAGE_OPENSSL=y
BR2_PACKAGE_LIBDILL=y


>
> > diff --git a/package/libdill/libdill.mk b/package/libdill/libdill.mk
> > new file mode 100644
> > index 0000000000..822f07b939
> > --- /dev/null
> > +++ b/package/libdill/libdill.mk
> > @@ -0,0 +1,26 @@
> >
> +################################################################################
> > +#
> > +# libdill
> > +#
> >
> +################################################################################
> > +
> > +LIBDILL_VERSION = fa01648cf2a8d06e53c965b45eeacfb3ac57bd04
> > +LIBDILL_SITE = $(call github,sustrik,libdill,$(LIBDILL_VERSION))
> > +LIBDILL_LICENSE = MIT
> > +LIBDILL_LICENSE_FILES = COPYING
> > +LIBDILL_CPE_ID_VENDOR = libdill
> > +LIBDILL_CPE_ID_PRODUCT = libdill
>
> Could you add a link in the commit log that shows you have verified these?
>

I removed those in V3 because I was unable to find proper CPE id.


>
> > +LIBDILL_INSTALL_STAGING = YES
> > +# Fetched from Github, with no configure script
> > +LIBDILL_AUTORECONF = YES
> > +
> > +ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
>
> ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),)
>
> > +LIBDILL_CONF_OPTS += --disable-threads
> > +endif
> > +
> > +ifeq ($(BR2_PACKAGE_OPENSSL),y)
> > +LIBDILL_DEPENDENCIES = openssl
> > +LIBDILL_CONF_OPTS += --enable-tls
>
> No "else" clause to explicitly disable?
>

Done.


> > +endif
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
>


-- 

Angelo Compagnucci

Software Engineer

angelo@amarulasolutions.com
__________________________________
Amarula Solutions SRL

Via le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 (0)42 243 5310
info@amarulasolutions.com

www.amarulasolutions.com
[`as] https://www.amarulasolutions.com|

[-- Attachment #1.2: Type: text/html, Size: 7904 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-07-29 22:06 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-28 21:12 [Buildroot] [PATCH v2] package/libdill: new package Angelo Compagnucci
2022-07-29  8:47 ` Thomas Petazzoni via buildroot
2022-07-29 19:00   ` Arnout Vandecappelle
2022-07-29 22:04     ` Angelo Compagnucci
2022-07-29 22:06   ` Angelo Compagnucci
  -- strict thread matches above, loose matches on Subject: below --
2022-03-26 22:07 Angelo Compagnucci
2022-07-26 21:49 ` Romain Naour
2022-07-28 21:11   ` Angelo Compagnucci

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox