* [Buildroot] [PATCH 1/2] package/cog: add udev dependency to drm platform support
@ 2022-07-27 8:19 Alexandru Ardelean
2022-07-27 8:19 ` [Buildroot] [PATCH 2/2] package/cog: add dep on libgbm's dmabuf & plane-count-modifier features Alexandru Ardelean
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Alexandru Ardelean @ 2022-07-27 8:19 UTC (permalink / raw)
To: buildroot; +Cc: aperez, michael, thomas.petazzoni, Alexandru Ardelean
The DRM platform support already has the 'BR2_PACKAGE_HAS_UDEV' symbol in
package/cog/Config.in
We just need to specify 'udev' as a dependency in the cog.mk file.
The udev virtual package is pulled by libinput anyway, but this makes it
more explicit.
Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
---
In continuation of:
https://patchwork.ozlabs.org/project/buildroot/patch/20220722070150.40715-1-ardeleanalex@gmail.com/
package/cog/cog.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/cog/cog.mk b/package/cog/cog.mk
index da660eb7c1..95b6220629 100644
--- a/package/cog/cog.mk
+++ b/package/cog/cog.mk
@@ -28,7 +28,7 @@ endif
ifeq ($(BR2_PACKAGE_COG_PLATFORM_DRM),y)
COG_CONF_OPTS += -DCOG_PLATFORM_DRM=ON
-COG_DEPENDENCIES += libdrm libinput libgbm libegl
+COG_DEPENDENCIES += libdrm libinput libgbm libegl udev
else
COG_CONF_OPTS += -DCOG_PLATFORM_DRM=OFF
endif
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 2/2] package/cog: add dep on libgbm's dmabuf & plane-count-modifier features
2022-07-27 8:19 [Buildroot] [PATCH 1/2] package/cog: add udev dependency to drm platform support Alexandru Ardelean
@ 2022-07-27 8:19 ` Alexandru Ardelean
2022-09-14 7:33 ` Peter Korsgaard
2022-08-01 20:53 ` [Buildroot] [PATCH 1/2] package/cog: add udev dependency to drm platform support Thomas Petazzoni via buildroot
2022-09-14 7:33 ` Peter Korsgaard
2 siblings, 1 reply; 5+ messages in thread
From: Alexandru Ardelean @ 2022-07-27 8:19 UTC (permalink / raw)
To: buildroot; +Cc: aperez, michael, thomas.petazzoni, Alexandru Ardelean
cog uses the dmabuf and plane-count-modifier features from libgbm.
These are provided by mesa3d, but may not be provided by other libgbm
providers.
So, make this a dependency.
Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
---
package/cog/Config.in | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/package/cog/Config.in b/package/cog/Config.in
index 484eb85c70..d2a910f9b8 100644
--- a/package/cog/Config.in
+++ b/package/cog/Config.in
@@ -41,6 +41,8 @@ config BR2_PACKAGE_COG_PLATFORM_DRM
depends on BR2_PACKAGE_HAS_UDEV # libinput
depends on BR2_PACKAGE_HAS_LIBEGL
depends on BR2_PACKAGE_HAS_LIBGBM
+ depends on BR2_PACKAGE_LIBGBM_HAS_FEATURE_DMA_BUF
+ depends on BR2_PACKAGE_LIBGBM_HAS_FEATURE_FORMAT_MODIFIER_PLANE_COUNT
select BR2_PACKAGE_LIBDRM
select BR2_PACKAGE_LIBINPUT
help
@@ -56,6 +58,8 @@ config BR2_PACKAGE_COG_USE_SYSTEM_DBUS
comment "DRM platform needs EGL and GBM"
depends on \
!BR2_PACKAGE_HAS_LIBEGL || \
- !BR2_PACKAGE_HAS_LIBGBM
+ !BR2_PACKAGE_HAS_LIBGBM || \
+ !BR2_PACKAGE_LIBGBM_HAS_FEATURE_DMA_BUF || \
+ !BR2_PACKAGE_LIBGBM_HAS_FEATURE_FORMAT_MODIFIER_PLANE_COUNT
endif
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/cog: add udev dependency to drm platform support
2022-07-27 8:19 [Buildroot] [PATCH 1/2] package/cog: add udev dependency to drm platform support Alexandru Ardelean
2022-07-27 8:19 ` [Buildroot] [PATCH 2/2] package/cog: add dep on libgbm's dmabuf & plane-count-modifier features Alexandru Ardelean
@ 2022-08-01 20:53 ` Thomas Petazzoni via buildroot
2022-09-14 7:33 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-08-01 20:53 UTC (permalink / raw)
To: Alexandru Ardelean; +Cc: aperez, michael, buildroot
On Wed, 27 Jul 2022 11:19:52 +0300
Alexandru Ardelean <ardeleanalex@gmail.com> wrote:
> The DRM platform support already has the 'BR2_PACKAGE_HAS_UDEV' symbol in
> package/cog/Config.in
>
> We just need to specify 'udev' as a dependency in the cog.mk file.
> The udev virtual package is pulled by libinput anyway, but this makes it
> more explicit.
>
> Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
> ---
Both applied, thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/cog: add udev dependency to drm platform support
2022-07-27 8:19 [Buildroot] [PATCH 1/2] package/cog: add udev dependency to drm platform support Alexandru Ardelean
2022-07-27 8:19 ` [Buildroot] [PATCH 2/2] package/cog: add dep on libgbm's dmabuf & plane-count-modifier features Alexandru Ardelean
2022-08-01 20:53 ` [Buildroot] [PATCH 1/2] package/cog: add udev dependency to drm platform support Thomas Petazzoni via buildroot
@ 2022-09-14 7:33 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2022-09-14 7:33 UTC (permalink / raw)
To: Alexandru Ardelean; +Cc: aperez, michael, thomas.petazzoni, buildroot
>>>>> "Alexandru" == Alexandru Ardelean <ardeleanalex@gmail.com> writes:
> The DRM platform support already has the 'BR2_PACKAGE_HAS_UDEV' symbol in
> package/cog/Config.in
> We just need to specify 'udev' as a dependency in the cog.mk file.
> The udev virtual package is pulled by libinput anyway, but this makes it
> more explicit.
> Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
> ---
> In continuation of:
> https://patchwork.ozlabs.org/project/buildroot/patch/20220722070150.40715-1-ardeleanalex@gmail.com/
Committed to 2022.05.x and 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-14 7:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-27 8:19 [Buildroot] [PATCH 1/2] package/cog: add udev dependency to drm platform support Alexandru Ardelean
2022-07-27 8:19 ` [Buildroot] [PATCH 2/2] package/cog: add dep on libgbm's dmabuf & plane-count-modifier features Alexandru Ardelean
2022-09-14 7:33 ` Peter Korsgaard
2022-08-01 20:53 ` [Buildroot] [PATCH 1/2] package/cog: add udev dependency to drm platform support Thomas Petazzoni via buildroot
2022-09-14 7:33 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox