Re: [Buildroot] [arc-buildroot] [PATCH] arch: remove support for BR2_ARC_PAGE_SIZE_4K

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

Re-adding Buildroot mailing list in Cc.

On Thu, 28 Jul 2022 20:25:47 +0000
Alexey Brodkin <Alexey.Brodkin@synopsys.com> wrote:

> > I don't understand what you mean here. Today, we are setting
> > max-page-size, and that doesn't work because the common-page-size value
> > is higher. As I mentioned in my initial patch, passing
> > -Wl,-z,max-page-size=4096 (already done) and
> > -Wl,-z,common-page-size=4096 would most likely fix the error, but I
> > wasn't sure it was the correct thing to do.  
> 
> So, right, suggested change of explicit setup of "common-page-size=max-page-size"
> is a good fix as it is compatible with older Binutils (before the change
> referred above, i.e. before 2.38).

Could you provide the patch?

Keep in mind that this block of code:

# Explicitly set LD's "max-page-size" instead of relying on some defaults
ifeq ($(BR2_ARC_PAGE_SIZE_4K)$(BR2_ARM64_PAGE_SIZE_4K),y)
ARCH_TOOLCHAIN_WRAPPER_OPTS += -Wl,-z,max-page-size=4096
else ifeq ($(BR2_ARC_PAGE_SIZE_8K),y)
ARCH_TOOLCHAIN_WRAPPER_OPTS += -Wl,-z,max-page-size=8192
else ifeq ($(BR2_ARC_PAGE_SIZE_16K),y)
ARCH_TOOLCHAIN_WRAPPER_OPTS += -Wl,-z,max-page-size=16384
else ifeq ($(BR2_ARM64_PAGE_SIZE_64K),y)
ARCH_TOOLCHAIN_WRAPPER_OPTS += -Wl,-z,max-page-size=65536
endif

in arch/arch.mk, has been recently modified to be used for configurable
page sizes on ARM64. So, if we decide to add
-Wl,-z,common-page-size=XYZ, it also needs to work for ARM64 (I think
it should, but I just want to warn that this code is no longer
ARC-specific).

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot