Re: [Buildroot] [arc-buildroot] [PATCH] arch: remove support for BR2_ARC_PAGE_SIZE_4K

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Alexey,

On Wed, 3 Aug 2022 19:22:29 +0200
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> > So, right, suggested change of explicit setup of "common-page-size=max-page-size"
> > is a good fix as it is compatible with older Binutils (before the change
> > referred above, i.e. before 2.38).  
> 
> Could you provide the patch?
> 
> Keep in mind that this block of code:
> 
> # Explicitly set LD's "max-page-size" instead of relying on some defaults
> ifeq ($(BR2_ARC_PAGE_SIZE_4K)$(BR2_ARM64_PAGE_SIZE_4K),y)
> ARCH_TOOLCHAIN_WRAPPER_OPTS += -Wl,-z,max-page-size=4096
> else ifeq ($(BR2_ARC_PAGE_SIZE_8K),y)
> ARCH_TOOLCHAIN_WRAPPER_OPTS += -Wl,-z,max-page-size=8192
> else ifeq ($(BR2_ARC_PAGE_SIZE_16K),y)
> ARCH_TOOLCHAIN_WRAPPER_OPTS += -Wl,-z,max-page-size=16384
> else ifeq ($(BR2_ARM64_PAGE_SIZE_64K),y)
> ARCH_TOOLCHAIN_WRAPPER_OPTS += -Wl,-z,max-page-size=65536
> endif
> 
> in arch/arch.mk, has been recently modified to be used for configurable
> page sizes on ARM64. So, if we decide to add
> -Wl,-z,common-page-size=XYZ, it also needs to work for ARM64 (I think
> it should, but I just want to warn that this code is no longer
> ARC-specific).

Do you think you will be able to provide a patch to fix support for 4K
page size support on ARC in Buildroot?

It is not really a major feature of Buildroot, and it's causing some
build failures in our autobuilders, so if no fix is provided, we'll
probably end up dropping support, as proposed by my patch posted on
July 17.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot