Re: [Buildroot] [PATCH] [master] boot/grub2: fix build race condition

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Stefan,

On Thu,  4 Aug 2022 13:45:27 +0200
Stefan Agner <stefan@agner.ch> wrote:

> Sometimes buildroot fails with:
> ../grub-core/kern/emu/hostfs.c:20:10: fatal error: config-util.h: No such file or directory
>    20 | #include <config-util.h>
>       |          ^~~~~~~~~~~~~~~
> 
> Add a patch which fixes the Makefile to correctly generate config-util.h
> first.
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>

Thanks for this patch.

> ---
>  ...ub_fstest.pp-depend-on-config-util.h.patch | 24 +++++++++++++++++++
>  boot/grub2/grub2.mk                           |  6 +++++
>  2 files changed, 30 insertions(+)
>  create mode 100644 boot/grub2/0001-Makefile-Make-grub_fstest.pp-depend-on-config-util.h.patch
> 
> diff --git a/boot/grub2/0001-Makefile-Make-grub_fstest.pp-depend-on-config-util.h.patch b/boot/grub2/0001-Makefile-Make-grub_fstest.pp-depend-on-config-util.h.patch
> new file mode 100644
> index 0000000000..96e6852e86
> --- /dev/null
> +++ b/boot/grub2/0001-Makefile-Make-grub_fstest.pp-depend-on-config-util.h.patch

We require all patches to have a proper commit log, with commit title +
description, and a Signed-off-by line. Also, we need to have the
upstream status of the patch, i.e where it has been submitted (or taken
from).

Could you rework your patch accordingly?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot