Re: [Buildroot] [PATCH] [master] boot/grub2: fix build race condition

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Thu, 04 Aug 2022 15:38:28 +0200
Stefan Agner <stefan@agner.ch> wrote:

> > We require all patches to have a proper commit log, with commit title +
> > description, and a Signed-off-by line. Also, we need to have the
> > upstream status of the patch, i.e where it has been submitted (or taken
> > from).  
> 
> The problem is, this patch is not generated from a source repository but
> simply using patch from the release tarball. The source repository does
> not contain Makefile.in, which needs to be patched...
> 
> So a "proper commit log" as such is not possible. I can of course fake
> it and make it look like the patch got generated from a commit, but not
> sure if that is sensible?

Regardless of how the patch is generated, we want it to have a commit
log + description as well as an upstream status.

A basic way:

	tar xf grub-2.06.tar.xz
	cd grub-2.06
	git init
	git add .
	git commit -s -m "Initial import"
	and now do your changes

Of course, it's not going to be a patch that we can apply to the
upstream Git repository, but at least you will have the proper tooling to
create a patch that a commit title, description, SoB and contains an
indicate of its upstream status.

Alternatively, I see you're avoiding autoreconf. Any reason to do so?
Autoreconf doesn't work? (I know with some older grub versions,
autoreconf was problematic, so perhaps it is still the case).

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot