Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Thomas Ruschival <thomas@ruschival.de>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/pistache: fix dependency on rapidjson
Date: Fri, 5 Aug 2022 18:29:53 +0200	[thread overview]
Message-ID: <20220805162953.GD3621445@scaer> (raw)
In-Reply-To: <20220804203555.29029-1-thomas.petazzoni@bootlin.com>

Thomas², All,

On 2022-08-04 22:35 +0200, Thomas Petazzoni via buildroot spake thusly:
> rapidjson has been added as a dependency of pistache as part of commit
> 2f3218567953185008ec862f814bebecb9d6ed82 ("package/pistache: bump
> version & switch to meson build"), using a "depends on". However, as
> it is a library dependency, a "select" is normally used in Buildroot.
> 
> rapidjson's only dependency is on C++ support, which is already a
> dependency of pistache.
> 
> In addition, use = instead of += for the rapidjson dependency in the
> .mk file, as it's an unconditional dependency.
> 
> Cc: Thomas Ruschival <thomas@ruschival.de>
> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/pistache/Config.in   | 2 +-
>  package/pistache/pistache.mk | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/pistache/Config.in b/package/pistache/Config.in
> index 806c27077a..53a4b73a58 100644
> --- a/package/pistache/Config.in
> +++ b/package/pistache/Config.in
> @@ -4,9 +4,9 @@ config BR2_PACKAGE_PISTACHE
>  	depends on BR2_USE_WCHAR
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	depends on BR2_INSTALL_LIBSTDCPP
> -	depends on BR2_PACKAGE_RAPIDJSON
>  	depends on !BR2_TOOLCHAIN_USES_UCLIBC
>  	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
> +	select BR2_PACKAGE_RAPIDJSON
>  	help
>  	  Pistache is a modern and elegant HTTP and REST framework
>  	  for C++. It is entirely written in pure C++17 and provides
> diff --git a/package/pistache/pistache.mk b/package/pistache/pistache.mk
> index 65d9b2412c..f4de5e3b2a 100644
> --- a/package/pistache/pistache.mk
> +++ b/package/pistache/pistache.mk
> @@ -10,7 +10,7 @@ PISTACHE_LICENSE = Apache-2.0
>  PISTACHE_LICENSE_FILES = LICENSE
>  
>  PISTACHE_INSTALL_STAGING = YES
> -PISTACHE_DEPENDENCIES += rapidjson
> +PISTACHE_DEPENDENCIES = rapidjson
>  
>  ifeq ($(BR2_PACKAGE_OPENSSL),y)
>  PISTACHE_DEPENDENCIES += openssl
> -- 
> 2.37.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2022-08-05 16:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-04 20:35 [Buildroot] [PATCH 1/2] package/pistache: fix dependency on rapidjson Thomas Petazzoni via buildroot
2022-08-04 20:35 ` [Buildroot] [PATCH 2/2] package/pistache: enable on uClibc Thomas Petazzoni via buildroot
2022-08-05 16:29   ` Yann E. MORIN
2022-08-06 13:45     ` Thomas Petazzoni via buildroot
2022-08-06 14:15   ` Yann E. MORIN
2022-08-05 16:29 ` Yann E. MORIN [this message]
2022-09-14  9:46 ` [Buildroot] [PATCH 1/2] package/pistache: fix dependency on rapidjson Peter Korsgaard
2022-09-14  9:47   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220805162953.GD3621445@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=thomas@ruschival.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox